Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement specialized nth_back() for Bytes, Fuse and Enumerate #60023

Merged
merged 3 commits into from Apr 19, 2019

Conversation

Projects
None yet
7 participants
@koalatux
Copy link
Contributor

commented Apr 16, 2019

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in #54054.

koalatux added some commits Apr 16, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@rust-highfive rust-highfive assigned scottmcm and unassigned shepmaster Apr 16, 2019

@scottmcm

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Looks good, thanks!

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

📌 Commit 2605537 has been approved by scottmcm

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

bors added a commit that referenced this pull request Apr 18, 2019

Auto merge of #60092 - Centril:rollup-rmwr418, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60038 (Add codegen test for PGO instrumentation.)
 - #60041 (Simplify the returning of a Result a bit)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60088 (Feature gate async methods)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

bors added a commit that referenced this pull request Apr 19, 2019

Auto merge of #60100 - Centril:rollup-svdiddz, r=Centril
Rollup of 17 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60038 (Add codegen test for PGO instrumentation.)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60088 (Feature gate async methods)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

bors added a commit that referenced this pull request Apr 19, 2019

Auto merge of #60101 - Centril:rollup-zmi4r8m, r=Centril
Rollup of 15 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60038 (Add codegen test for PGO instrumentation.)
 - #60041 (Simplify the returning of a Result a bit)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019

Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.

bors added a commit that referenced this pull request Apr 19, 2019

Auto merge of #60104 - Centril:rollup-7vmae1a, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost

@bors bors merged commit 2605537 into rust-lang:master Apr 19, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@koalatux koalatux deleted the koalatux:nth-back branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.