Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement specialized nth_back() for Bytes, Fuse and Enumerate #60023

Merged
merged 3 commits into from
Apr 19, 2019
Merged

implement specialized nth_back() for Bytes, Fuse and Enumerate #60023

merged 3 commits into from
Apr 19, 2019

Conversation

koalatux
Copy link
Contributor

@koalatux koalatux commented Apr 16, 2019 •
edited
Loading

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in #54054.

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2019
@Centril
Copy link
Contributor

Centril commented Apr 16, 2019

r? @scottmcm

@rust-highfive rust-highfive assigned scottmcm and unassigned shepmaster Apr 16, 2019
@koalatux koalatux mentioned this pull request Apr 17, 2019
Open
25 tasks
@scottmcm
Copy link
Member

Looks good, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit 2605537 has been approved by scottmcm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
02492df 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
f41ed55 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
f38b9c9 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
28cf45f 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
7e17c91 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
5f1cedf 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
686399f 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
fe13059 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
b388682 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
47f14f7 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60023 - koalatux:nth-back, r=scottmcm
291e44b 
implement specialized nth_back() for Bytes, Fuse and Enumerate

Hi,

After my first PR has been successfully merged, here is my second pull request :-)

Also this PR contains some specializations for the problem discussed in rust-lang#54054.
@Centril Centril mentioned this pull request Apr 19, 2019
Merged
bors added a commit that referenced this pull request Apr 19, 2019
@bors
Auto merge of #60104 - Centril:rollup-7vmae1a, r=Centril
316a391 
Rollup of 16 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost
@bors bors merged commit 2605537 into rust-lang:master Apr 19, 2019
@koalatux koalatux deleted the nth-back branch April 19, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@tesuji tesuji tesuji left review comments

Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@koalatux @rust-highfive @Centril @scottmcm @bors @tesuji @shepmaster