Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tidy check for leading newlines #60168

Merged
merged 3 commits into from
Apr 22, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Apr 22, 2019

This is fairly uncommon, but it can slip through when refactoring (as evidenced by the files with leading newlines here).

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 22, 2019

📌 Commit 5347ab4 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2019
bors added a commit that referenced this pull request Apr 22, 2019
Add a tidy check for leading newlines

This is fairly uncommon, but it can slip through when refactoring (as evidenced by the files with leading newlines here).
@bors
Copy link
Contributor

bors commented Apr 22, 2019

⌛ Testing commit 5347ab4 with merge 93b0aa1...

@rust-highfive

This comment has been minimized.

@varkor
Copy link
Member Author

varkor commented Apr 22, 2019

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Apr 22, 2019

📌 Commit 0964955 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 22, 2019

⌛ Testing commit 0964955 with merge 6d59933...

bors added a commit that referenced this pull request Apr 22, 2019
Add a tidy check for leading newlines

This is fairly uncommon, but it can slip through when refactoring (as evidenced by the files with leading newlines here).
@bors
Copy link
Contributor

bors commented Apr 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 6d59933 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants