Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard for missing comma in macro call suggestion #60248

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Add guard for missing comma in macro call suggestion #60248

merged 1 commit into from
Apr 25, 2019

Conversation

estebank
Copy link
Contributor

Fix #60233. Follow up to #58796.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Apr 25, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2019

📌 Commit 0e505d4 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2019
@bors
Copy link
Contributor

bors commented Apr 25, 2019

⌛ Testing commit 0e505d4 with merge 112f7e9...

bors added a commit that referenced this pull request Apr 25, 2019
@bors
Auto merge of #60248 - estebank:macro-comma, r=oli-obk
112f7e9 
Add guard for missing comma in macro call suggestion

Fix #60233. Follow up to #58796.

r? @oli-obk
@bors
Copy link
Contributor

bors commented Apr 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 112f7e9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2019
@bors bors merged commit 0e505d4 into rust-lang:master Apr 25, 2019
@estebank estebank deleted the macro-comma branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong span/confusing error for comma in macro pattern
4 participants
@estebank @oli-obk @bors @rust-highfive