Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize pointer::align_offset #60303

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
7 participants
@CryZe
Copy link
Contributor

commented Apr 26, 2019

Closes #44488

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0d4bfb9c:start=1556273915600535475,finish=1556273916360033329,duration=759497854
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:end:09130aac:start=1556274223649350277,finish=1556274223653849083,duration=4498806
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:077830bf
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ba14d21
travis_time:start:0ba14d21
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:s

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added this to the 1.36 milestone Apr 26, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

r? @Centril @bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

📌 Commit cf9d667 has been approved by Centril

bors added a commit that referenced this pull request Apr 26, 2019

Auto merge of #60303 - CryZe:patch-6, r=Centril
Stabilize pointer::align_offset

Closes #44488
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

⌛️ Testing commit cf9d667 with merge 597f432...

@RalfJung

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Just like with align_to, the docs should say that the method is allowed to fail (return max) even if aligning was possible -- this is a best-effort operation.

(In practice, it will always return max when running in CTFE/Miri.)

@RalfJung

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@CryZe Can you do that docs change in a follow-up PR?

@CryZe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@RalfJung

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

That doesn't say that this may happen "spuriously".

align_to says

The method does a best effort to make the middle slice the greatest length possible for a given type and input slice, but only your algorithm's performance should depend on that, not its correctness.

to make sure that this gets across.

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 597f432 to master...

@bors bors added the merged-by-bors label Apr 26, 2019

@bors bors merged commit cf9d667 into rust-lang:master Apr 26, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.