Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilized vectored IO #60334

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
5 participants
@sfackler
Copy link
Member

commented Apr 27, 2019

This renames std::io::IoVec to std::io::IoSlice and
std::io::IoVecMut to std::io::IoSliceMut, and stabilizes
std::io::IoSlice, std::io::IoSliceMut,
std::io::Read::read_vectored, and std::io::Write::write_vectored.

Closes #58452

r? @alexcrichton

Stabilized vectored IO
This renames `std::io::IoVec` to `std::io::IoSlice` and
`std::io::IoVecMut` to `std::io::IoSliceMut`, and stabilizes
`std::io::IoSlice`, `std::io::IoSliceMut`,
`std::io::Read::read_vectored`, and `std::io::Write::write_vectored`.

Closes #58452
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Apr 27, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1714cc53:start=1556379477220789431,finish=1556379478075675524,duration=854886093
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:03] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:03] tidy error: /checkout/src/libstd/io/impls.rs:2: line longer than 100 chars
[00:04:03] tidy error: /checkout/src/libstd/io/buffered.rs:8: line longer than 100 chars
[00:04:03] tidy error: /checkout/src/libstd/io/cursor.rs:458: line longer than 100 chars
[00:04:03] tidy error: /checkout/src/libstd/io/cursor.rs:585: line longer than 100 chars
[00:04:03] tidy error: /checkout/src/libstd/io/cursor.rs:636: line longer than 100 chars
[00:04:03] tidy error: /checkout/src/libstd/io/cursor.rs:695: line longer than 100 chars
[00:04:05] some tidy checks failed
[00:04:05] 
[00:04:05] 
[00:04:05] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:05] 
[00:04:05] 
[00:04:05] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:05] Build completed unsuccessfully in 0:00:45
[00:04:05] Build completed unsuccessfully in 0:00:45
[00:04:05] make: *** [tidy] Error 1
[00:04:05] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:12e23a64
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Apr 27 15:42:15 UTC 2019
---
travis_time:end:0737a1ec:start=1556379737254543678,finish=1556379737259266627,duration=4722949
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:18800070
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1bd06f2c
travis_time:start:1bd06f2c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2d165cf4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added this to the 1.36 milestone Apr 27, 2019

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

📌 Commit 89ff7cd has been approved by alexcrichton

Centril added a commit to Centril/rust that referenced this pull request Apr 29, 2019

Rollup merge of rust-lang#60334 - sfackler:stable-iovec, r=alexcrichton
Stabilized vectored IO

This renames `std::io::IoVec` to `std::io::IoSlice` and
`std::io::IoVecMut` to `std::io::IoSliceMut`, and stabilizes
`std::io::IoSlice`, `std::io::IoSliceMut`,
`std::io::Read::read_vectored`, and `std::io::Write::write_vectored`.

Closes rust-lang#58452

r? @alexcrichton

bors added a commit that referenced this pull request Apr 29, 2019

Auto merge of #60377 - Centril:rollup-42fxe9u, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #59946 (Fix equivalent string in escape_default docs)
 - #60256 (Option::flatten)
 - #60305 (hir: remove LoweredNodeId)
 - #60334 (Stabilized vectored IO)
 - #60353 (Add test not to forget resolved ICE)
 - #60356 (Stabilize str::as_mut_ptr)
 - #60358 (Clarify the short explanation of E0207)
 - #60359 (resolve: Consider erroneous imports used to avoid duplicate diagnostics)
 - #60360 (Add test case for labeled break in const assignment)

Failed merges:

r? @ghost

@bors bors merged commit 89ff7cd into rust-lang:master Apr 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@Thomasdezeeuw Thomasdezeeuw referenced this pull request Apr 30, 2019

Open

Add vectored I/O #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.