Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing issue with negative literals as const generic arguments #60583

Merged
merged 2 commits into from
May 7, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented May 6, 2019

No description provided.

varkor added 2 commits May 6, 2019 17:00
`<-` may indicate the start of a negative const argument.
@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2019
@petrochenkov petrochenkov self-assigned this May 6, 2019
@petrochenkov
Copy link
Contributor

Ok, it's probably safe to assume that T <- U will never be a valid type.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 6, 2019

📌 Commit e570fe5 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2019
Centril added a commit to Centril/rust that referenced this pull request May 7, 2019
…trochenkov

Fix parsing issue with negative literals as const generic arguments
bors added a commit that referenced this pull request May 7, 2019
Rollup of 5 pull requests

Successful merges:

 - #60489 (Remove hamburger button from source code page)
 - #60535 (Correct handling of arguments in async fn)
 - #60579 (Rename `ParamTy::idx` to `ParamTy::index`)
 - #60583 (Fix parsing issue with negative literals as const generic arguments)
 - #60609 (Be a bit more explicit asserting over the vec rather than the len)

Failed merges:

r? @ghost
@bors bors merged commit e570fe5 into rust-lang:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants