Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexer: Disallow bare CR in raw byte strings #60793

Merged
merged 11 commits into from Jun 11, 2019

Conversation

Projects
None yet
6 participants
@Xanewok
Copy link
Member

commented May 13, 2019

Handles bare CR but doesn't translate \r\n to \n yet in raw strings yet and translates CRLF to LF in raw strings.

As a side-note I think it'd be good to change the unescape_ to return plain iterators to reduce some boilerplate (e.g. has_error could benefit from collecting Result<T> and aborting early on errors) but will do that separately, unless I missed something here that prevents it.

@matklad @petrochenkov thoughts?

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -18,6 +18,7 @@
#![feature(step_trait)]
#![feature(try_trait)]
#![feature(unicode_internals)]
#![feature(rustc_private)]

This comment has been minimized.

Copy link
@Xanewok

Xanewok May 13, 2019

Author Member

The changes from the first commit (so cargo check works) were of drive-by nature, can remove them if needed

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov May 15, 2019

Contributor

Yes, please remove.

This comment has been minimized.

Copy link
@Xanewok

Xanewok Jun 8, 2019

Author Member

Done. Out of curiosity, why should we skip this? Is it because it adds noise and is somewhat obvious? (after all we're in the compiler code)

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Jun 10, 2019

Contributor

Less noise and impossible to forget something if it's added automatically.
rustc crates are not supposed to be built in isolation, outside of the rustc build system, so boilerplate common for all rustc crates is regularly moved to the workspace or rustbuild.
The rustc_private features in particular were moved in #41847.

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Jun 10, 2019

Contributor

IIRC, x.py check should provide the same functionality as cargo check.

Show resolved Hide resolved src/libsyntax/parse/unescape.rs Outdated
Show resolved Hide resolved src/libsyntax/parse/unescape.rs Outdated
Show resolved Hide resolved src/test/ui/parser/raw-byte-string-literals.rs
@matklad

This comment has been minimized.

Copy link
Member

commented May 13, 2019

As a side-note I think it'd be good to change the unescape_ to return plain iterators to reduce some boilerplate (e.g. has_error could benefit from collecting Result and aborting early on errors) but will do that separately, unless I missed something here that prevents it.

I think changing unescape_ to usual, external iterators, will make implementation trickier and slower in the common case: one would have to reify the state, instead of keeping it implicitly on the stack. If I am mistaking and the impl turns out not significantly worse, I am all for flipping to external iterators!

However, I think here it's counter-intiutively more important to preserve implementation simplicity (that's where all interesting bits are) rather than interface simplicity (interface is a glue code, which is isolated), so if internal iteration is easier to implement, I'd keep it.

@petrochenkov petrochenkov self-assigned this May 13, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Closes #60604.

I'd keep #60604 open until the \r\n -> \n translation is moved to the file loading stage (or a decision that we don't want to move it is made).

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

The direction seems right (same as #60261 basically).
I'll wait with review until this fully ready.

r? @petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

☔️ The latest upstream changes (presumably #60965) made this pull request unmergeable. Please resolve the merge conflicts.

@Xanewok Xanewok force-pushed the Xanewok:raw-string-cleanup branch 2 times, most recently from 9085079 to 03e4521 Jun 8, 2019

Xanewok added some commits May 13, 2019

Remove redundant, commented out code
It was commented out as part of
8a8e497.
Done probably by accident, since the code in question was moved to a
match arm, along with newly introduced logic to detect bare CRs in raw
strings.

@Xanewok Xanewok force-pushed the Xanewok:raw-string-cleanup branch from 03e4521 to 6d7bc3b Jun 8, 2019

@Xanewok Xanewok marked this pull request as ready for review Jun 8, 2019

@Xanewok

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

(...) will make implementation trickier and slower in the common case: one would have to reify the state, instead of keeping it implicitly on the stack

@matklad maybe we could use iter::from_fn?

Rebased the PR and would like for this to land and then land a separate one which translates \r\n -> \n if possible.
@petrochenkov this should be ready for review now

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2bd09510:start=1560017242083832836,finish=1560017331892705772,duration=89808872936
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:12] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:12] tidy error: /checkout/src/libsyntax/parse/literal.rs:7: line longer than 100 chars
[00:04:13] tidy error: /checkout/src/test/ui/parser/raw-byte-string-literals.rs:3: CR character
[00:04:17] some tidy checks failed
[00:04:17] 
[00:04:17] 
[00:04:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:17] 
[00:04:17] 
[00:04:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:17] Build completed unsuccessfully in 0:01:16
---
travis_time:end:05adf9bc:start=1560017599003094722,finish=1560017599008008025,duration=4913303
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04afd132
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02450e10
travis_time:start:02450e10
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:058c44c0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:13322194:start=1560018496448215263,finish=1560018585083139017,duration=88634923754
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:58:16] .................................................................................................... 3800/5657
[00:58:19] .........................................................ii......................................... 3900/5657
[00:58:22] ..............................................................................i..................... 4000/5657
[00:58:24] .................................................................................................... 4100/5657
[00:58:26] ..........................................i..........................................F.............. 4200/5657
[00:58:41] .................................................................................................... 4400/5657
[00:58:47] .................................................................................................... 4500/5657
[00:58:50] .................................................................................................... 4600/5657
[00:58:54] .................................................................................................... 4700/5657
---
[00:59:32] 
[00:59:32] ---- [ui] ui/parser/raw-byte-string-literals.rs stdout ----
[00:59:32] diff of stderr:
[00:59:32] 
[00:59:32] 1 error: bare CR not allowed in string, use \r instead
[00:59:32] +   --> $DIR/raw-byte-string-literals.rs:4:9
[00:59:32] 3    |
[00:59:32] 4 LL |     br"a
";
---
[00:59:32] 10 LL |     br"é";
[00:59:32] 11    |        ^
[00:59:32] 
[00:59:32] 12 
[00:59:32] 13 error: found invalid character; only `#` is allowed in raw string delimitation: ~
[00:59:32] +   --> $DIR/raw-byte-string-literals.rs:6:6
[00:59:32] 15    |
[00:59:32] 15    |
[00:59:32] 16 LL |     br##~"a"~##;
[00:59:32] 
[00:59:32] 
[00:59:32] The actual stderr differed from the expected stderr.
[00:59:32] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/raw-byte-string-literals/raw-byte-string-literals.stderr
[00:59:32] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/raw-byte-string-literals/raw-byte-string-literals.stderr
[00:59:32] To update references, rerun the tests and pass the `--bless` flag
[00:59:32] To only update this specific test, also pass `--test-args parser/raw-byte-string-literals.rs`
[00:59:32] error: 1 errors occurred comparing output.
[00:59:32] status: exit code: 1
[00:59:32] status: exit code: 1
[00:59:32] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/raw-byte-string-literals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/raw-byte-string-literals" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "continue-parse-after-error" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/raw-byte-string-literals/auxiliary" "-A" "unused"
[00:59:32] ------------------------------------------
[00:59:32] 
[00:59:32] ------------------------------------------
[00:59:32] stderr:
[00:59:32] stderr:
[00:59:32] ------------------------------------------
[00:59:32] error: bare CR not allowed in string, use \r instead
[00:59:32]    |
[00:59:32] LL |     br"a
[00:59:32] LL |     br"a
"; //~ ERROR bare CR not allowed in string
[00:59:32] 
[00:59:32] error: raw byte string must be ASCII
[00:59:32]   --> /checkout/src/test/ui/parser/raw-byte-string-literals.rs:5:8
[00:59:32]    |
[00:59:32]    |
[00:59:32] LL |     br"é";  //~ ERROR raw byte string must be ASCII
[00:59:32] 
[00:59:32] 
[00:59:32] error: found invalid character; only `#` is allowed in raw string delimitation: ~
[00:59:32]    |
[00:59:32]    |
[00:59:32] LL |     br##~"a"~##;  //~ ERROR only `#` is allowed in raw string delimitation
[00:59:32] 
[00:59:32] error: aborting due to 3 previous errors
[00:59:32] 
[00:59:32] 
---
[00:59:32] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[00:59:32] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:59:32] 
[00:59:32] 
[00:59:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:59:32] 
[00:59:32] 
[00:59:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:59:32] Build completed unsuccessfully in 0:55:36
---
travis_time:end:05477f8e:start=1560022168009779236,finish=1560022168014750157,duration=4970921
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:23233db1
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:243bd2dc
travis_time:start:243bd2dc
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2b0162c8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Xanewok Xanewok force-pushed the Xanewok:raw-string-cleanup branch from 7e5ef6d to e5d5a08 Jun 8, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:03079aba:start=1560023244962839850,finish=1560023342162488535,duration=97199648685
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:01:33] .....................ii............................................................................. 1400/2925
[01:01:45] .................................................................................................... 1500/2925
[01:01:54] .........................................................................i.......i.................. 1600/2925
[01:02:08] .................................................................................................... 1700/2925
[01:02:22] ..............................F..................................................................... 1800/2925
[01:02:46] ....i.......................................................................i....................... 2000/2925
[01:03:12] .................................................................................................... 2100/2925
[01:03:34] ........................................................................................test [run-pass] run-pass/mpsc_stress.rs has been running for over 60 seconds
[01:03:35] ............ 2200/2925
---
[01:05:24] ------------------------------------------
[01:05:24] stderr:
[01:05:24] ------------------------------------------
[01:05:24] thread 'main' panicked at 'assertion failed: `(left == right)`
[01:05:24]   left: `"string\r\nliteral"`,
[01:05:24]  right: `"string\nliteral"`', /checkout/src/test/run-pass/lexer-crlf-line-endings-string-literal-doc-comment.rs:32:5
[01:05:24] 
[01:05:24] ------------------------------------------
[01:05:24] 
[01:05:24] 
---
[01:05:24] test result: FAILED. 2915 passed; 1 failed; 9 ignored; 0 measured; 0 filtered out
[01:05:24] 
[01:05:24] 
[01:05:24] 
[01:05:24] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:05:24] 
[01:05:24] 
[01:05:24] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:05:24] Build completed unsuccessfully in 1:01:29
---
travis_time:end:0b1d0db8:start=1560027277780394948,finish=1560027277840754842,duration=60359894
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:20f16e6d
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1104b394
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Xanewok

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Pushed the CRLF -> LF translation now and tests seem to pass locally now, hopefully CI agrees 🤞

Show resolved Hide resolved src/libsyntax/parse/unescape.rs Outdated
@Xanewok

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

Applied feedback and actually implemented CRLF -> LF rewrite in raw byte strings (forgot about the byte variant 🤦‍♂ ) in 735ac05#diff-a8037ce27e05cd3a29b041f9ec00f94eR176

@matklad

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

LGTM now, let's wait for @petrochenkov review!

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

r=me with #60793 (comment) fixed

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

📌 Commit 630d5f3 has been approved by petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

⌛️ Testing commit 630d5f3 with merge 5e2c110...

bors added a commit that referenced this pull request Jun 10, 2019

Auto merge of #60793 - Xanewok:raw-string-cleanup, r=petrochenkov
lexer: Disallow bare CR in raw byte strings

Handles bare CR ~but doesn't translate `\r\n` to `\n` yet in raw strings yet~ and translates CRLF to LF in raw strings.

As a side-note I think it'd be good to change the `unescape_` to return plain iterators to reduce some boilerplate (e.g. `has_error` could benefit from collecting `Result<T>` and aborting early on errors) but will do that separately, unless I missed something here that prevents it.

@matklad @petrochenkov thoughts?
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: petrochenkov
Pushing 5e2c110 to master...

@bors bors added the merged-by-bors label Jun 11, 2019

@bors bors merged commit 630d5f3 into rust-lang:master Jun 11, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

📣 Toolstate changed by #60793!

Tested on commit 5e2c110.
Direct link to PR: #60793

💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 11, 2019

📣 Toolstate changed by rust-lang/rust#60793!
Tested on commit rust-lang/rust@5e2c110.
Direct link to PR: <rust-lang/rust#60793>

💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).

@Xanewok Xanewok deleted the Xanewok:raw-string-cleanup branch Jun 20, 2019

Centril added a commit to Centril/rust that referenced this pull request Jun 20, 2019

Rollup merge of rust-lang#61996 - Xanewok:unescape-raw-strings, r=mat…
…klad

Add unit tests for unescaping raw (byte) strings

Adds unit tests for functionality introduced in rust-lang#60793.

r? @matklad @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.