Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry-like methods to HashSet #60894

Merged
merged 3 commits into from May 17, 2019

Conversation

Projects
None yet
5 participants
@cuviper
Copy link
Member

commented May 16, 2019

  • HashSet::get_or_insert
  • HashSet::get_or_insert_with

These provide a simplification of the Entry API for HashSet, with
names chosen to match the similar methods on Option.

Add entry-like methods to HashSet
* `HashSet::get_or_insert`
* `HashSet::get_or_insert_with`

These provide a simplification of the `Entry` API for `HashSet`, with
names chosen to match the similar methods on `Option`.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit 5f93834 has been approved by cramertj

@cramertj

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Can you also open a tracking issue for these?

@cuviper

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Added tracking issue #60896.

@bors r=cramertj

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit 5e2c9d3 has been approved by cramertj

@Centril

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@bors r=cramertj,Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit 9161a4d has been approved by cramertj,Centril

Centril added a commit to Centril/rust that referenced this pull request May 17, 2019

Rollup merge of rust-lang#60894 - cuviper:hash_set_entry, r=cramertj,…
…Centril

Add entry-like methods to HashSet

* `HashSet::get_or_insert`
* `HashSet::get_or_insert_with`

These provide a simplification of the `Entry` API for `HashSet`, with
names chosen to match the similar methods on `Option`.

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #60898 - Centril:rollup-76o2g8a, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #60685 (Switch to SPDX 2.1 license expression)
 - #60687 (Fix .natvis visualizers.)
 - #60805 (remove compiletest's dependency on `filetime`)
 - #60862 (Get ty from local_decls instead of using Place)
 - #60873 (Parse alternative incorrect uses of await and recover)
 - #60894 (Add entry-like methods to HashSet)

Failed merges:

r? @ghost

@bors bors merged commit 9161a4d into rust-lang:master May 17, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@cuviper cuviper deleted the cuviper:hash_set_entry branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.