Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust deprecation date of mem::uninitialized #61006

Merged
merged 1 commit into from
May 22, 2019

Conversation

RalfJung
Copy link
Member

In #60445 we decided that we'd deprecate for 1.38 instead of 1.40, but I forgot to adjust for that.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2019
@Centril
Copy link
Contributor

Centril commented May 21, 2019

Thanks! :)

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 21, 2019

📌 Commit 61735ab has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned sfackler May 21, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2019
Centril added a commit to Centril/rust that referenced this pull request May 21, 2019
adjust deprecation date of mem::uninitialized

In rust-lang#60445 we [decided](rust-lang#60445 (comment)) that we'd deprecate for 1.38 instead of 1.40, but I forgot to adjust for that.
Centril added a commit to Centril/rust that referenced this pull request May 21, 2019
adjust deprecation date of mem::uninitialized

In rust-lang#60445 we [decided](rust-lang#60445 (comment)) that we'd deprecate for 1.38 instead of 1.40, but I forgot to adjust for that.
Centril added a commit to Centril/rust that referenced this pull request May 21, 2019
adjust deprecation date of mem::uninitialized

In rust-lang#60445 we [decided](rust-lang#60445 (comment)) that we'd deprecate for 1.38 instead of 1.40, but I forgot to adjust for that.
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
adjust deprecation date of mem::uninitialized

In rust-lang#60445 we [decided](rust-lang#60445 (comment)) that we'd deprecate for 1.38 instead of 1.40, but I forgot to adjust for that.
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
adjust deprecation date of mem::uninitialized

In rust-lang#60445 we [decided](rust-lang#60445 (comment)) that we'd deprecate for 1.38 instead of 1.40, but I forgot to adjust for that.
bors added a commit that referenced this pull request May 22, 2019
Rollup of 10 pull requests

Successful merges:

 - #59742 (Move `edition` outside the hygiene lock and avoid accessing it)
 - #60581 (convert custom try macro to `?`)
 - #60963 (Update boxed::Box docs on memory layout)
 - #60973 (Avoid symbol interning in `file_metadata`.)
 - #60982 (Do not fail on child without DefId)
 - #60991 (LocalDecl push returns Local len)
 - #60995 (Add stream_to_parser_with_base_dir)
 - #60998 (static_assert: make use of anonymous constants)
 - #61003 (Remove impls for `InternedString`/string equality.)
 - #61006 (adjust deprecation date of mem::uninitialized)

Failed merges:

r? @ghost
@bors bors merged commit 61735ab into rust-lang:master May 22, 2019
@tspiteri
Copy link
Contributor

#60445 has made it into beta, but this PR has not made it into #60999. I think this should go into beta to avoid 1.36 documention saying "Deprecating in 1.40.0" only for 1.37 changing that to "Deprecating in 1.38.0".

@Centril Centril added beta-nominated Nominated for backporting to the compiler in the beta channel. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels May 22, 2019
@Centril Centril added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 23, 2019
@Centril
Copy link
Contributor

Centril commented May 23, 2019

We discussed this on the language meeting today and no one objected to back-porting.

@RalfJung
Copy link
Member Author

Backport submitted as #61160.

@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants