ci: Disable LLVM/debug assertions for distcheck #61587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of distcheck is to test `./x.py test` from a tarball, not to test that all assertions pass all the time. These assertions are largely just redundant with other builders, so skip the assertions for now and save a good chunk of time on CI. cc rust-lang#61185
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| # significant hit to CI compile time (over a half hour as observed in #61185), | ||
| # so disable assertions for this builder. | ||
| ENV NO_LLVM_ASSERTIONS=1 | ||
| ENV NO_DEBUG_ASSERTIONS=1 |
There was a problem hiding this comment.
Wrong syntax here? Looking at the above we just want a space not =?
There was a problem hiding this comment.
It'll work either way, this is the syntax for multiple variables in one line wheras the previous is for one variable with a value that possibly contains spaces
|
@bors r+ rollup=never Don't rollup since it rebuilds a Docker image. |
|
📌 Commit 27ea407 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 12, 2019
…albini ci: Disable LLVM/debug assertions for distcheck The purpose of distcheck is to test `./x.py test` from a tarball, not to test that all assertions pass all the time. These assertions are largely just redundant with other builders, so skip the assertions for now and save a good chunk of time on CI. cc #61185
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of distcheck is to test
./x.py testfrom a tarball, not totest that all assertions pass all the time. These assertions are largely
just redundant with other builders, so skip the assertions for now and
save a good chunk of time on CI.
cc #61185