Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize use of `#![feature(custom_attribute)]` #61660

Merged
merged 6 commits into from Jun 9, 2019

Conversation

Projects
None yet
5 participants
@petrochenkov
Copy link
Contributor

commented Jun 8, 2019

Some preparations before resurrecting #57921.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril
Copy link
Member

left a comment

r? @Centril

r=me with or without changes for the notes below.

Show resolved Hide resolved src/test/ui/lint/lint-obsolete-attr.rs Outdated
Show resolved Hide resolved src/test/ui/lint/lint-unknown-attr.rs Outdated

@Centril Centril assigned Centril and unassigned eddyb Jun 8, 2019

@petrochenkov petrochenkov force-pushed the petrochenkov:nocusta branch from 0c93c60 to ee189ae Jun 8, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

📌 Commit ee189ae has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Jun 8, 2019

Rollup merge of rust-lang#61660 - petrochenkov:nocusta, r=Centril
Minimize use of `#![feature(custom_attribute)]`

Some preparations before resurrecting rust-lang#57921.

@Centril Centril referenced this pull request Jun 8, 2019

Merged

Rollup of 6 pull requests #61672

bors added a commit that referenced this pull request Jun 8, 2019

Auto merge of #61672 - Centril:rollup-jxo89ir, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #61646 (Remove useless allocations in macro_rules follow logic.)
 - #61658 (remove useless ident() functions in const tests)
 - #61660 (Minimize use of `#![feature(custom_attribute)]`)
 - #61666 (Add test for trait ICE)
 - #61669 ( syntax: Remove `Deref` impl from `Token`)
 - #61670 (Update RLS)

Failed merges:

r? @ghost

@bors bors merged commit ee189ae into rust-lang:master Jun 9, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@petrochenkov petrochenkov deleted the petrochenkov:nocusta branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.