Skip to content

Remove the default type of Rem::Output #61874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2019
Merged

Remove the default type of Rem::Output #61874

merged 1 commit into from
Jun 22, 2019

Conversation

jonas-schievink
Copy link
Contributor

Associated type defaults are not yet stable, and Rem is the only trait that specifies a default. Let's see what breaks when it's removed.

cc #61812 (comment)
cc @Centril

@bors try

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2019
@Centril
Copy link
Contributor

Centril commented Jun 15, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned kennytm Jun 15, 2019
@jonas-schievink
Copy link
Contributor Author

@bors try

@bors
Copy link
Collaborator

bors commented Jun 15, 2019

⌛ Trying commit ba30dca with merge d3301713b54af69ca9de941a8c6b0d8287dbd6df...

@bors
Copy link
Collaborator

bors commented Jun 15, 2019

☀️ Try build successful - checks-travis
Build commit: d3301713b54af69ca9de941a8c6b0d8287dbd6df

@Centril
Copy link
Contributor

Centril commented Jun 15, 2019

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-61874 created and queued.
🤖 Automatically detected try build d3301713b54af69ca9de941a8c6b0d8287dbd6df
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2019
@craterbot
Copy link
Collaborator

🚧 Experiment pr-61874 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 15, 2019
@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 17, 2019
@sfackler
Copy link
Member

Weird, looks like it's always been that way since the initial addition: #20490.

@craterbot
Copy link
Collaborator

🎉 Experiment pr-61874 is completed!
📊 2 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 22, 2019
@Centril
Copy link
Contributor

Centril commented Jun 22, 2019

The 2 "regressions" are spurious.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2019

📌 Commit ba30dca has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2019
@bors
Copy link
Collaborator

bors commented Jun 22, 2019

⌛ Testing commit ba30dca with merge d6884ae...

bors added a commit that referenced this pull request Jun 22, 2019
@bors
Auto merge of #61874 - jonas-schievink:remove-rem-output-default, r=C…
d6884ae 
…entril

Remove the default type of `Rem::Output`

Associated type defaults are not yet stable, and `Rem` is the only trait that specifies a default. Let's see what breaks when it's removed.

cc #61812 (comment)
cc @Centril

@bors try
@bors
Copy link
Collaborator

bors commented Jun 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing d6884ae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 22, 2019
@bors bors merged commit ba30dca into rust-lang:master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jonas-schievink @rust-highfive @Centril @bors @craterbot @sfackler @kennytm