Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default type of `Rem::Output` #61874

Merged
merged 1 commit into from Jun 22, 2019

Conversation

Projects
None yet
7 participants
@jonas-schievink
Copy link
Member

commented Jun 15, 2019

Associated type defaults are not yet stable, and Rem is the only trait that specifies a default. Let's see what breaks when it's removed.

cc #61812 (comment)
cc @Centril

@bors try

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Jun 15, 2019

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

@rust-highfive rust-highfive assigned Centril and unassigned kennytm Jun 15, 2019

@jonas-schievink

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

⌛️ Trying commit ba30dca with merge d330171...

bors added a commit that referenced this pull request Jun 15, 2019

Auto merge of #61874 - jonas-schievink:remove-rem-output-default, r=<…
…try>

Remove the default type of `Rem::Output`

Associated type defaults are not yet stable, and `Rem` is the only trait that specifies a default. Let's see what breaks when it's removed.

cc #61812 (comment)
cc @Centril

@bors try
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

☀️ Try build successful - checks-travis
Build commit: d330171

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

@craterbot run mode=check-only

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

👌 Experiment pr-61874 created and queued.
🤖 Automatically detected try build d330171
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

🚧 Experiment pr-61874 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@sfackler

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Weird, looks like it's always been that way since the initial addition: #20490.

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 22, 2019

🎉 Experiment pr-61874 is completed!
📊 2 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

The 2 "regressions" are spurious.

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

📌 Commit ba30dca has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

⌛️ Testing commit ba30dca with merge d6884ae...

bors added a commit that referenced this pull request Jun 22, 2019

Auto merge of #61874 - jonas-schievink:remove-rem-output-default, r=C…
…entril

Remove the default type of `Rem::Output`

Associated type defaults are not yet stable, and `Rem` is the only trait that specifies a default. Let's see what breaks when it's removed.

cc #61812 (comment)
cc @Centril

@bors try
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing d6884ae to master...

@bors bors added the merged-by-bors label Jun 22, 2019

@bors bors merged commit ba30dca into rust-lang:master Jun 22, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
pr Build #20190615.33 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.