Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ecx for const-prop local storage #62012

Merged
merged 3 commits into from Jun 24, 2019

Conversation

Projects
None yet
6 participants
@wesleywiser
Copy link
Member

commented Jun 21, 2019

wesleywiser added some commits Jun 13, 2019

[const-prop] Move local storage into a `Frame` on `InterpCx`
This moves us closer to just using `InterpCx` for interpretation.
Show resolved Hide resolved src/librustc_mir/transform/const_prop.rs Outdated
Show resolved Hide resolved src/librustc_mir/transform/const_prop.rs Outdated
@oli-obk
Copy link
Contributor

left a comment

r=me with @Centril's and my nits addressed

Show resolved Hide resolved src/librustc_mir/transform/const_prop.rs Outdated
Show resolved Hide resolved src/librustc_mir/transform/const_prop.rs Outdated
Show resolved Hide resolved src/librustc_mir/transform/const_prop.rs Outdated
Show resolved Hide resolved src/librustc_mir/transform/const_prop.rs Outdated

@wesleywiser wesleywiser force-pushed the wesleywiser:const_prop_use_ecx branch from 501f510 to c686130 Jun 21, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@bors try

let's see how this impacts perf

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

⌛️ Trying commit c686130 with merge dcd84aa...

bors added a commit that referenced this pull request Jun 21, 2019

Auto merge of #62012 - wesleywiser:const_prop_use_ecx, r=<try>
Use ecx for const-prop local storage

r? @oli-obk
@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@rust-timer

This comment has been minimized.

Copy link

commented Jun 21, 2019

Success: Queued dcd84aa with parent 56a12b2, comparison URL.

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

☀️ Try build successful - checks-travis
Build commit: dcd84aa

@rust-timer

This comment has been minimized.

Copy link

commented Jun 21, 2019

Finished benchmarking try commit dcd84aa, comparison URL.

@wesleywiser

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

⌛️ Trying commit cef4561 with merge b9376e6...

bors added a commit that referenced this pull request Jun 22, 2019

Auto merge of #62012 - wesleywiser:const_prop_use_ecx, r=<try>
Use ecx for const-prop local storage

r? @oli-obk
@wesleywiser

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2019

@rust-timer

This comment has been minimized.

Copy link

commented Jun 22, 2019

Success: Queued b9376e6 with parent d4d5d67, comparison URL.

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

☀️ Try build successful - checks-travis
Build commit: b9376e6

@rust-timer

This comment has been minimized.

Copy link

commented Jun 22, 2019

Finished benchmarking try commit b9376e6, comparison URL.

@wesleywiser

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

That didn't really help. I'm reverting that.

@wesleywiser wesleywiser force-pushed the wesleywiser:const_prop_use_ecx branch from cef4561 to c686130 Jun 23, 2019

@wesleywiser

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

@oli-obk Are you ok with the performance?

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

Yes, I believe now that we can start reusing const eval logic, we can improve the readability of the const propagator enough to warrant the perf regression. I also think that some of these reuse-changes will improve perf or at least expose perf problems in const eval that we can then address.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

📌 Commit c686130 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

⌛️ Testing commit c686130 with merge 166c49d...

bors added a commit that referenced this pull request Jun 24, 2019

Auto merge of #62012 - wesleywiser:const_prop_use_ecx, r=oli-obk
Use ecx for const-prop local storage

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 166c49d to master...

@bors bors added the merged-by-bors label Jun 24, 2019

@bors bors merged commit c686130 into rust-lang:master Jun 24, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
pr Build #20190623.12 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.