Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 24, 2019

% git shortlog --no-merges 5a11ed7b92cc4cf40a4568a8fc1ff54b198c333b..
Daniele D'Orazio (4):
      make needless_return work with void functions
      update tests and fix lints in clippy
      more idiomatic code
      cargo fmt

Jeremy Stucki (1):
      Remove needless lifetimes

Lzu Tao (1):
      Fix fallout cause NodeId pruning

Matthias Krüger (1):
      readme: update

Mazdak Farrokhzad (5):
      Fix fallout from rust-lang/rust PR 60861.
      Account for let_chains in collapsible_if ui test cases.
      Fix dogfood test failures.
      Pacify rustfmt.
      Put 'if let' back into comment.

flip1995 (1):
      Remove another unnecessary lifetime

r? @Manishearth , cc @oli-obk

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Jun 24, 2019

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jun 24, 2019

📌 Commit ca354e9 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2019
@bors
Copy link
Collaborator

bors commented Jun 24, 2019

⌛ Testing commit ca354e9 with merge bbbb3e5...

bors added a commit that referenced this pull request Jun 24, 2019
submodules: Update clippy from 5a11ed7 to 8c80b65

```bash
% git shortlog --no-merges 5a11ed7..
Daniele D'Orazio (4):
      make needless_return work with void functions
      update tests and fix lints in clippy
      more idiomatic code
      cargo fmt

Jeremy Stucki (1):
      Remove needless lifetimes

Lzu Tao (1):
      Fix fallout cause NodeId pruning

Matthias Krüger (1):
      readme: update

Mazdak Farrokhzad (5):
      Fix fallout from rust-lang/rust PR 60861.
      Account for let_chains in collapsible_if ui test cases.
      Fix dogfood test failures.
      Pacify rustfmt.
      Put 'if let' back into comment.

flip1995 (1):
      Remove another unnecessary lifetime
```
r? @Manishearth , cc @oli-obk
@bors
Copy link
Collaborator

bors commented Jun 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing bbbb3e5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 24, 2019
@bors bors merged commit ca354e9 into rust-lang:master Jun 24, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #62092!

Tested on commit bbbb3e5.
Direct link to PR: #62092

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 24, 2019
Tested on commit rust-lang/rust@bbbb3e5.
Direct link to PR: <rust-lang/rust#62092>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
@tesuji tesuji deleted the clippy-update branch June 24, 2019 16:14
@tesuji tesuji restored the clippy-update branch June 24, 2019 16:20
@tesuji tesuji deleted the clippy-update branch June 24, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants