Only call the closure parameter of Iterator::is_sorted_by_key once per item #62473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @scottmcm |
scottmcm
reviewed
Jul 7, 2019
|
Well, this seems reasonable to me and the signature change is unstable so if libs is unhappy with it we can always revert it 🙃, so @bors r+ |
|
📌 Commit 98b54fb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 8, 2019
Only call the closure parameter of Iterator::is_sorted_by_key once per item See #53485 (comment). This changes `Iterator::is_sorted_by_key` to only call the given closure once for each item, which allows us to pass the items to the closure by value instead of by reference. **Important**: `is_sorted_by_key` for slices and slice iterators is now no longer implemented in terms of the custom `slice::Iter::is_sorted_by` implementation. It's a trade-off: we could forward `slice::Iter::is_sorted_by_key` to it directly for potential SIMD benefits, but that would mean that the closure is potentially called twice for (almost) every element of the slice.
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53485 (comment).
This changes
Iterator::is_sorted_by_keyto only call the given closure once for each item, which allows us to pass the items to the closure by value instead of by reference.Important:
is_sorted_by_keyfor slices and slice iterators is now no longer implemented in terms of the customslice::Iter::is_sorted_byimplementation. It's a trade-off: we could forwardslice::Iter::is_sorted_by_keyto it directly for potential SIMD benefits, but that would mean that the closure is potentially called twice for (almost) every element of the slice.