Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about undefined behavior to as_ref suggestions #62685

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@nathanwhit
Copy link
Contributor

commented Jul 15, 2019

Fixes #61786. A very small fix, but suggestions on wording/content are welcomed.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nathanwhit nathanwhit force-pushed the nathanwhit:as_ref_suggest_fix branch from 781175c to c221e93 Jul 15, 2019

@estebank

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

📌 Commit c221e93 has been approved by estebank

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 15, 2019

Rollup merge of rust-lang#62685 - nathanwhit:as_ref_suggest_fix, r=es…
…tebank

Add info about undefined behavior to as_ref suggestions

Fixes rust-lang#61786. A very small fix, but suggestions on wording/content are welcomed.

bors added a commit that referenced this pull request Jul 16, 2019

Auto merge of #62704 - Mark-Simulacrum:rollup-oi94s2j, r=Mark-Simulacrum
Rollup of 14 pull requests

Successful merges:

 - #62103 (Add debug assertions to write_bytes and copy*)
 - #62405 (Remove never_type feature requirement for exhaustive patterns)
 - #62491 (Fix Pin urls in Option documentation)
 - #62533 (Add missing links for CannotReallocInPlace type)
 - #62634 (Less unsafe in the array example of MaybeUninit docs)
 - #62639 (Make VaListImpl<'f> invariant over the 'f lifetime)
 - #62646 (Tweak wording in feature gate errors)
 - #62662 (add spaces in front of trait requirements in libcore/cell.rs)
 - #62668 (Fix #62660)
 - #62673 (miri validation: better error messages for dangling references)
 - #62680 (Actually call `visit_block_entry` in `DataflowResultsConsumer`)
 - #62685 (Add info about undefined behavior to as_ref suggestions)
 - #62689 (Fix typo in RawWaker::new documentation)
 - #62698 (SGX target: don't pretend to be GNU/Linux to LLVM)

Failed merges:

r? @ghost

@bors bors merged commit c221e93 into rust-lang:master Jul 16, 2019

4 checks passed

pr Build #20190715.9 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@bryanburgers-bot

This comment has been minimized.

Copy link

commented Jul 16, 2019

☔️ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

☔️ The latest upstream changes (presumably #62704) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.