Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific error for positional args after named args in `format!()` #62710

Merged
merged 1 commit into from Jul 20, 2019

Conversation

@estebank
Copy link
Contributor

commented Jul 16, 2019

When writing positional arguments after named arguments in the
format!() and println!() macros, provide a targeted diagnostic.

Follow up to https://github.com/rust-lang/rust/pull/57522/files#r247278885

Specific error for positional args after named args in `format!()`
When writing positional arguments after named arguments in the
`format!()` and `println!()` macros, provide a targeted diagnostic.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

📌 Commit 33ec182 has been approved by petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

⌛️ Testing commit 33ec182 with merge f69b071...

bors added a commit that referenced this pull request Jul 20, 2019

Auto merge of #62710 - estebank:bad-named-args, r=petrochenkov
Specific error for positional args after named args in `format!()`

When writing positional arguments after named arguments in the
`format!()` and `println!()` macros, provide a targeted diagnostic.

Follow up to https://github.com/rust-lang/rust/pull/57522/files#r247278885
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing f69b071 to master...

@bors bors added the merged-by-bors label Jul 20, 2019

@bors bors merged commit 33ec182 into rust-lang:master Jul 20, 2019

5 checks passed

homu Test successful
Details
pr Build #20190716.7 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.