Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize newlines when loading files #62948

Open
wants to merge 2 commits into
base: master
from

Conversation

@matklad
Copy link
Member

commented Jul 24, 2019

Fixes #62865

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-24T18:55:52.7894306Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-24T18:55:52.8067879Z ##[command]git config gc.auto 0
2019-07-24T18:55:52.8138412Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-24T18:55:52.8191994Z ##[command]git config --get-all http.proxy
2019-07-24T18:55:52.8320929Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62948/merge:refs/remotes/pull/62948/merge
---
2019-07-24T18:56:27.3466656Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-24T18:56:27.3466682Z 
2019-07-24T18:56:27.3466854Z   git checkout -b <new-branch-name>
2019-07-24T18:56:27.3466878Z 
2019-07-24T18:56:27.3466947Z HEAD is now at fb3dcda87 Merge b36a450d6a10d9aad7b0a86704cccfcf6b7e34d3 into 27a6a304e2baaabca88059753f020377f2476978
2019-07-24T18:56:27.3602898Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-24T18:56:27.3605120Z ==============================================================================
2019-07-24T18:56:27.3605533Z Task         : Bash
2019-07-24T18:56:27.3605595Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-24T19:54:13.1012601Z .................................................................................................... 200/5851
2019-07-24T19:54:17.3143678Z .................................................................................................... 300/5851
2019-07-24T19:54:20.9682739Z .................................................................................................... 400/5851
2019-07-24T19:54:24.6983764Z .................................................................................................... 500/5851
2019-07-24T19:54:28.4799921Z ........................................................................i........................... 600/5851
2019-07-24T19:54:37.4703721Z .................................................................................................... 800/5851
2019-07-24T19:54:43.1377297Z .................................................................................................... 900/5851
2019-07-24T19:54:48.1224711Z ...................................................................................................i 1000/5851
2019-07-24T19:54:48.1224711Z ...................................................................................................i 1000/5851
2019-07-24T19:54:53.7029234Z ...........i........................................................................................ 1100/5851
2019-07-24T19:54:57.5924545Z .............................iiiii.................................................................. 1200/5851
2019-07-24T19:55:03.5753542Z .................................................................................................... 1400/5851
2019-07-24T19:55:06.3428072Z .................................................................................................... 1500/5851
2019-07-24T19:55:10.0680737Z .................................................................................................... 1600/5851
2019-07-24T19:55:12.7166306Z .................................................................................................... 1700/5851
2019-07-24T19:55:12.7166306Z .................................................................................................... 1700/5851
2019-07-24T19:55:16.0808276Z .....................................................................i.............................. 1800/5851
2019-07-24T19:55:24.5670888Z .................................................................................................... 2000/5851
2019-07-24T19:55:28.8599841Z .................................................................................................... 2100/5851
2019-07-24T19:55:32.5152540Z .................................................................................................... 2200/5851
2019-07-24T19:55:32.5152540Z .................................................................................................... 2200/5851
2019-07-24T19:55:36.4509429Z .....................................................i.............................................. 2300/5851
2019-07-24T19:55:46.2077255Z .................................................................................................... 2500/5851
2019-07-24T19:55:50.3147156Z .................................................................................................... 2600/5851
2019-07-24T19:55:55.6743047Z .................................................................................................... 2700/5851
2019-07-24T19:55:59.3229511Z .................................................................................................... 2800/5851
2019-07-24T19:55:59.3229511Z .................................................................................................... 2800/5851
2019-07-24T19:56:03.7047779Z .................................................................................................... 2900/5851
2019-07-24T19:56:08.8878733Z .................................................................................................... 3000/5851
2019-07-24T19:56:13.3770806Z .................................................................................................... 3100/5851
2019-07-24T19:56:18.8888056Z .................................................................................................... 3200/5851
2019-07-24T19:56:22.3960387Z .................................................................................................... 3300/5851
2019-07-24T19:56:26.0661330Z .................................................................................................... 3400/5851
2019-07-24T19:56:31.2111820Z .................................................................................................... 3500/5851
2019-07-24T19:56:34.9941928Z ....................i............................................................................... 3600/5851
2019-07-24T19:56:39.0720377Z ..............................................................................................ii...i 3700/5851
2019-07-24T19:56:42.8559044Z ..ii................................................................................................ 3800/5851
2019-07-24T19:56:51.7859077Z .................................................................................................... 4000/5851
2019-07-24T19:56:51.7859077Z .................................................................................................... 4000/5851
2019-07-24T19:56:55.6111114Z ........ii.......................................................................................... 4100/5851
2019-07-24T19:56:57.5933443Z ..............................i..................................................................... 4200/5851
2019-07-24T19:56:59.5926286Z .................................................................................................i.. 4300/5851
2019-07-24T19:57:06.0707726Z .................................................................................................... 4500/5851
2019-07-24T19:57:23.8433370Z .................................................................................................... 4600/5851
2019-07-24T19:57:27.4157931Z .................................................................................................... 4700/5851
2019-07-24T19:57:31.0218519Z .................................................................................................... 4800/5851
---
2019-07-24T19:58:04.5542827Z .................................................................................................... 5400/5851
2019-07-24T19:58:08.3941909Z .................................................................................................... 5500/5851
2019-07-24T19:58:12.5963994Z .................................................................................................... 5600/5851
2019-07-24T19:58:15.7888770Z .................................................................................................... 5700/5851
2019-07-24T19:58:18.7840702Z ...........................................................................................i........ 5800/5851
2019-07-24T19:58:20.5810802Z test result: ok. 5830 passed; 0 failed; 21 ignored; 0 measured; 0 filtered out
2019-07-24T19:58:20.5810840Z 
2019-07-24T19:58:20.5879640Z  finished in 263.386
2019-07-24T19:58:20.6053114Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T19:58:20.6053114Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T19:58:20.8258926Z 
2019-07-24T19:58:20.8260474Z running 2904 tests
2019-07-24T19:58:35.6176331Z .................................................................................................... 100/2904
2019-07-24T19:58:50.7975205Z ............................................................................i....................... 200/2904
2019-07-24T19:59:15.4726349Z .................................................................................................... 400/2904
2019-07-24T19:59:27.4425274Z .................................................................................................... 500/2904
2019-07-24T19:59:41.8217252Z .................................................................................................... 600/2904
2019-07-24T20:00:03.5384951Z .................................................................................................... 700/2904
2019-07-24T20:00:03.5384951Z .................................................................................................... 700/2904
2019-07-24T20:00:17.7555915Z .................................................................................................... 800/2904
2019-07-24T20:00:29.9233396Z .................................................................................................... 900/2904
2019-07-24T20:00:47.7001704Z .................................................................................................... 1000/2904
2019-07-24T20:01:02.0647536Z .................................................................................................... 1100/2904
2019-07-24T20:01:13.3696986Z .................................................................................................... 1200/2904
2019-07-24T20:01:26.0291794Z .................................................................................................... 1300/2904
2019-07-24T20:01:42.4300371Z .......ii........................................................................................... 1400/2904
2019-07-24T20:01:55.0434096Z .................................................................................................... 1500/2904
2019-07-24T20:02:07.4628673Z ...........................................................i.......i................................ 1600/2904
2019-07-24T20:02:39.8710101Z .................................................................................................... 1800/2904
2019-07-24T20:02:39.8710101Z .................................................................................................... 1800/2904
2019-07-24T20:02:55.1869530Z ..........................................................................................i......... 1900/2904
2019-07-24T20:03:22.2790533Z ..............................................................i..................................... 2000/2904
2019-07-24T20:04:05.0377218Z .................................................................................................... 2200/2904
2019-07-24T20:04:05.0377218Z .................................................................................................... 2200/2904
2019-07-24T20:04:19.3203016Z .................................................................................................ii. 2300/2904
2019-07-24T20:04:52.1172867Z .................................................................................................... 2500/2904
2019-07-24T20:05:33.8841693Z .................................................................................................... 2600/2904
2019-07-24T20:05:46.7507191Z .................................................................................................... 2700/2904
2019-07-24T20:05:58.0490742Z .................................................................................................... 2800/2904
---
2019-07-24T20:07:07.5080696Z  finished in 30.797
2019-07-24T20:07:07.5253204Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:07:07.6868426Z 
2019-07-24T20:07:07.6869301Z running 146 tests
2019-07-24T20:07:10.7912544Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-24T20:07:12.5979048Z iii..............i.........iii.i......ii......
2019-07-24T20:07:12.5980005Z 
2019-07-24T20:07:12.5982227Z  finished in 5.072
2019-07-24T20:07:12.6164471Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:07:12.7651820Z 
2019-07-24T20:07:12.7651820Z 
2019-07-24T20:07:12.7652911Z running 39 tests
2019-07-24T20:07:14.7649672Z i.........i......................i.....
2019-07-24T20:07:14.7650930Z 
2019-07-24T20:07:14.7655491Z  finished in 2.149
2019-07-24T20:07:14.7830473Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:07:14.9401262Z 
2019-07-24T20:07:14.9401262Z 
2019-07-24T20:07:14.9402286Z running 9 tests
2019-07-24T20:07:14.9403047Z iiiiiiiii
2019-07-24T20:07:14.9403691Z 
2019-07-24T20:07:14.9408074Z  finished in 0.157
2019-07-24T20:07:14.9579560Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:07:15.1155761Z 
---
2019-07-24T20:07:33.3332740Z  finished in 17.719
2019-07-24T20:07:33.3333000Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:07:33.3333035Z 
2019-07-24T20:07:33.3333073Z running 122 tests
2019-07-24T20:07:55.7525264Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-24T20:08:00.3393952Z .i.i......iii.i.....ii
2019-07-24T20:08:00.3448563Z 
2019-07-24T20:08:00.3448609Z  finished in 27.459
2019-07-24T20:08:00.3448862Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:08:00.3449291Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-24T20:11:41.0098559Z     Finished release [optimized] target(s) in 2m 41s
2019-07-24T20:11:41.0342749Z Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-24T20:11:41.1954308Z 
2019-07-24T20:11:41.1955820Z running 315 tests
2019-07-24T20:12:55.5073525Z ....................................i............................................................... 100/315
2019-07-24T20:14:02.3619774Z ....................................................i............................................... 200/315
2019-07-24T20:15:18.2530372Z ...............
2019-07-24T20:15:18.2531342Z test result: ok. 313 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-24T20:15:18.2531553Z 
2019-07-24T20:15:18.2536154Z  finished in 217.219
---
2019-07-24T20:15:20.6047483Z ---- [pretty] pretty/block-comment-wchar.rs stdout ----
2019-07-24T20:15:20.6047651Z 
2019-07-24T20:15:20.6048034Z error: pretty-printing failed in round 0 revision None
2019-07-24T20:15:20.6048206Z status: exit code: 1
2019-07-24T20:15:20.6049781Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/pretty/block-comment-wchar.rs" "-Z" "unpretty=normal" "--target" "x86_64-unknown-linux-gnu" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty/block-comment-wchar/auxiliary.pretty" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
2019-07-24T20:15:20.6050487Z ------------------------------------------
2019-07-24T20:15:20.6050682Z 
2019-07-24T20:15:20.6051049Z ------------------------------------------
2019-07-24T20:15:20.6051232Z stderr:
2019-07-24T20:15:20.6051232Z stderr:
2019-07-24T20:15:20.6051610Z ------------------------------------------
2019-07-24T20:15:20.6052085Z error: couldn't read /checkout/src/test/pretty/block-comment-wchar.rs: bare carriage return (`\r`) in file
2019-07-24T20:15:20.6052438Z error: aborting due to previous error
2019-07-24T20:15:20.6052742Z 
2019-07-24T20:15:20.6053055Z 
2019-07-24T20:15:20.6053558Z ------------------------------------------
---
2019-07-24T20:15:20.6055632Z test result: FAILED. 54 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-07-24T20:15:20.6055791Z 
2019-07-24T20:15:20.6061079Z 
2019-07-24T20:15:20.6061200Z 
2019-07-24T20:15:20.6063834Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/pretty" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "pretty" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-24T20:15:20.6065100Z 
2019-07-24T20:15:20.6065156Z 
2019-07-24T20:15:20.6068020Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-24T20:15:20.6068345Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-24T20:15:20.6068345Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-24T20:15:20.6074701Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-24T20:15:20.6075048Z Build completed unsuccessfully in 1:12:31
2019-07-24T20:15:22.7331019Z ##[error]Bash exited with code '1'.
2019-07-24T20:15:22.7367879Z ##[section]Starting: Checkout
2019-07-24T20:15:22.7369985Z ==============================================================================
2019-07-24T20:15:22.7370042Z Task         : Get sources
2019-07-24T20:15:22.7370109Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov petrochenkov self-assigned this Jul 24, 2019

@Centril
Copy link
Member

left a comment

Please also file a PR to the reference with the relevant changes once this merged.

Show resolved Hide resolved src/libsyntax/source_map.rs Outdated
@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Meta: "draft" PRs don't seem to interact well with our tooling, so I'd rather avoid them.
"WIP" in the title is certainly enough to see that the PR is an in progress work.

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Two notes:

  • The bare \r error looks very recoverable, we can report it and continue. I think \r will be just treated as a whitespace and won't cause further problems if it's just left in source after the error is reporte.
  • Is it possible to report errors with a span at this stage? The lack of span seems like the primary regression from the change. Not sure how important is this in practice.

@nikomatsakis nikomatsakis removed their assignment Jul 25, 2019

@matklad matklad force-pushed the matklad:failable-file-loading branch from b36a450 to c4ccb42 Jul 25, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-25T20:38:43.0861835Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-25T20:38:43.1061229Z ##[command]git config gc.auto 0
2019-07-25T20:38:43.8786002Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-25T20:38:43.8793926Z ##[command]git config --get-all http.proxy
2019-07-25T20:38:43.8799049Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62948/merge:refs/remotes/pull/62948/merge
---
2019-07-25T20:39:17.2847546Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-25T20:39:17.2847750Z 
2019-07-25T20:39:17.2848117Z   git checkout -b <new-branch-name>
2019-07-25T20:39:17.2848319Z 
2019-07-25T20:39:17.2848499Z HEAD is now at fd0340313 Merge c4ccb429fd6b2c73b5022393fa7dfa912edb5291 into eedf6ce4ef54bb03818ab21d714f1b9f13a6b31c
2019-07-25T20:39:17.2971124Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-25T20:39:17.2974284Z ==============================================================================
2019-07-25T20:39:17.2974345Z Task         : Bash
2019-07-25T20:39:17.2974393Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-25T21:35:32.9033399Z .................................................................................................... 200/5856
2019-07-25T21:35:36.8686903Z .................................................................................................... 300/5856
2019-07-25T21:35:40.3955422Z .................................................................................................... 400/5856
2019-07-25T21:35:43.9197816Z .................................................................................................... 500/5856
2019-07-25T21:35:47.5007602Z ........................................................................i........................... 600/5856
2019-07-25T21:35:56.2697749Z .................................................................................................... 800/5856
2019-07-25T21:36:01.6416899Z .................................................................................................... 900/5856
2019-07-25T21:36:06.4763677Z ...................................................................................................i 1000/5856
2019-07-25T21:36:06.4763677Z ...................................................................................................i 1000/5856
2019-07-25T21:36:11.8252909Z ...........i........................................................................................ 1100/5856
2019-07-25T21:36:15.5625472Z .............................iiiii.................................................................. 1200/5856
2019-07-25T21:36:21.3158271Z .................................................................................................... 1400/5856
2019-07-25T21:36:23.9883443Z .................................................................................................... 1500/5856
2019-07-25T21:36:27.6728245Z .................................................................................................... 1600/5856
2019-07-25T21:36:30.2992037Z .................................................................................................... 1700/5856
2019-07-25T21:36:30.2992037Z .................................................................................................... 1700/5856
2019-07-25T21:36:33.5892028Z .....................................................................i.............................. 1800/5856
2019-07-25T21:36:41.8066087Z .................................................................................................... 2000/5856
2019-07-25T21:36:45.8160467Z .................................................................................................... 2100/5856
2019-07-25T21:36:49.3698661Z .................................................................................................... 2200/5856
2019-07-25T21:36:49.3698661Z .................................................................................................... 2200/5856
2019-07-25T21:36:53.0383274Z .....................................................i.............................................. 2300/5856
2019-07-25T21:37:02.3629243Z .................................................................................................... 2500/5856
2019-07-25T21:37:06.3293573Z .................................................................................................... 2600/5856
2019-07-25T21:37:11.2520317Z .................................................................................................... 2700/5856
2019-07-25T21:37:15.0511269Z .................................................................................................... 2800/5856
2019-07-25T21:37:15.0511269Z .................................................................................................... 2800/5856
2019-07-25T21:37:19.2707633Z .................................................................................................... 2900/5856
2019-07-25T21:37:24.2162293Z .................................................................................................... 3000/5856
2019-07-25T21:37:28.4562934Z .................................................................................................... 3100/5856
2019-07-25T21:37:33.4466239Z .................................................................................................... 3200/5856
2019-07-25T21:37:36.8569295Z .................................................................................................... 3300/5856
2019-07-25T21:37:40.4774083Z .................................................................................................... 3400/5856
2019-07-25T21:37:45.3011398Z .................................................................................................... 3500/5856
2019-07-25T21:37:48.9258387Z ....................i............................................................................... 3600/5856
2019-07-25T21:37:52.8546219Z ..............................................................................................ii...i 3700/5856
2019-07-25T21:37:56.4912962Z ...ii............................................................................................... 3800/5856
2019-07-25T21:38:04.8879179Z .................................................................................................... 4000/5856
2019-07-25T21:38:04.8879179Z .................................................................................................... 4000/5856
2019-07-25T21:38:08.5100706Z .............ii..................................................................................... 4100/5856
2019-07-25T21:38:10.4333254Z ..............F...................i................................................................. 4200/5856
2019-07-25T21:38:12.5799755Z .............................................................................F...................... 4300/5856
2019-07-25T21:38:14.7739667Z .i.......................................F...................................F........F............. 4400/5856
2019-07-25T21:38:35.3993084Z .................................................................................................... 4600/5856
2019-07-25T21:38:38.9078377Z .................................................................................................... 4700/5856
2019-07-25T21:38:42.4477798Z .................................................................................................... 4800/5856
2019-07-25T21:38:46.9887906Z .................................................................................................... 4900/5856
---
2019-07-25T21:39:31.0610625Z failures:
2019-07-25T21:39:31.0657446Z 
2019-07-25T21:39:31.0658000Z ---- [ui] ui/parser/bad-char-literals.rs stdout ----
2019-07-25T21:39:31.0658070Z 
2019-07-25T21:39:31.0658915Z error: /checkout/src/test/ui/parser/bad-char-literals.rs:16: unexpected error: '16:6: 16:6: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0658987Z 
2019-07-25T21:39:31.0659034Z error: 1 unexpected errors found, 0 expected errors not found
2019-07-25T21:39:31.0659075Z status: exit code: 1
2019-07-25T21:39:31.0659975Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/bad-char-literals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/bad-char-literals" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "continue-parse-after-error" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/bad-char-literals/auxiliary" "-A" "unused"
2019-07-25T21:39:31.0660159Z unexpected errors (from JSON output): [
2019-07-25T21:39:31.0660222Z     Error {
2019-07-25T21:39:31.0660266Z         line_num: 16,
2019-07-25T21:39:31.0660305Z         kind: Some(
2019-07-25T21:39:31.0660401Z         ),
2019-07-25T21:39:31.0660401Z         ),
2019-07-25T21:39:31.0660443Z         msg: "16:6: 16:6: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0660546Z ]
2019-07-25T21:39:31.0660571Z 
2019-07-25T21:39:31.0660909Z thread '[ui] ui/parser/bad-char-literals.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1505:13
2019-07-25T21:39:31.0660993Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-25T21:39:31.0660993Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-25T21:39:31.0661026Z 
2019-07-25T21:39:31.0662953Z ---- [ui] ui/parser/lex-bare-cr-string-literal-doc-comment.rs stdout ----
2019-07-25T21:39:31.0663027Z 
2019-07-25T21:39:31.0664347Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:5: unexpected error: '5:32: 5:32: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0664412Z 
2019-07-25T21:39:31.0664727Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:9: unexpected error: '9:38: 9:38: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0665298Z 
2019-07-25T21:39:31.0665735Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:14: unexpected error: '14:36: 14:36: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0665787Z 
2019-07-25T21:39:31.0666197Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:17: unexpected error: '17:42: 17:42: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0666247Z 
2019-07-25T21:39:31.0666608Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:21: unexpected error: '21:18: 21:18: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0666679Z 
2019-07-25T21:39:31.0667031Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:24: unexpected error: '24:19: 24:19: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0667089Z 
2019-07-25T21:39:31.0667467Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:27: unexpected error: '27:19: 27:19: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0667514Z 
2019-07-25T21:39:31.0667875Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:21: unexpected error: '21:18: 21:19: character constant must be escaped: \r'
2019-07-25T21:39:31.0667923Z 
2019-07-25T21:39:31.0668289Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:5: expected error not found: bare CR not allowed in doc-comment
2019-07-25T21:39:31.0668514Z 
2019-07-25T21:39:31.0668808Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:9: expected error not found: bare CR not allowed in block doc-comment
2019-07-25T21:39:31.0668847Z 
2019-07-25T21:39:31.0669155Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:14: expected error not found: bare CR not allowed in doc-comment
2019-07-25T21:39:31.0669204Z 
2019-07-25T21:39:31.0669501Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:17: expected error not found: bare CR not allowed in block doc-comment
2019-07-25T21:39:31.0669560Z 
2019-07-25T21:39:31.0669964Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:21: expected error not found: bare CR not allowed in string
2019-07-25T21:39:31.0670018Z 
2019-07-25T21:39:31.0670341Z error: /checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs:24: expected error not found: bare CR not allowed in raw string
2019-07-25T21:39:31.0670404Z 
2019-07-25T21:39:31.0670448Z error: 8 unexpected errors found, 6 expected errors not found
2019-07-25T21:39:31.0670490Z status: exit code: 1
2019-07-25T21:39:31.0671236Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/lex-bare-cr-string-literal-doc-comment.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/lex-bare-cr-string-literal-doc-comment" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "continue-parse-after-error" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/lex-bare-cr-string-literal-doc-comment/auxiliary" "-A" "unused"
2019-07-25T21:39:31.0671426Z unexpected errors (from JSON output): [
2019-07-25T21:39:31.0671469Z     Error {
2019-07-25T21:39:31.0671513Z         line_num: 5,
2019-07-25T21:39:31.0671551Z         kind: Some(
2019-07-25T21:39:31.0671646Z         ),
2019-07-25T21:39:31.0671646Z         ),
2019-07-25T21:39:31.0671690Z         msg: "5:32: 5:32: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0671798Z     Error {
2019-07-25T21:39:31.0671836Z         line_num: 9,
2019-07-25T21:39:31.0671893Z         kind: Some(
2019-07-25T21:39:31.0671932Z             Error,
2019-07-25T21:39:31.0671932Z             Error,
2019-07-25T21:39:31.0671969Z         ),
2019-07-25T21:39:31.0672011Z         msg: "9:38: 9:38: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0672107Z     Error {
2019-07-25T21:39:31.0672145Z         line_num: 14,
2019-07-25T21:39:31.0672202Z         kind: Some(
2019-07-25T21:39:31.0672246Z             Error,
2019-07-25T21:39:31.0672246Z             Error,
2019-07-25T21:39:31.0672285Z         ),
2019-07-25T21:39:31.0672345Z         msg: "14:36: 14:36: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0672423Z     Error {
2019-07-25T21:39:31.0672461Z         line_num: 17,
2019-07-25T21:39:31.0672517Z         kind: Some(
2019-07-25T21:39:31.0672554Z             Error,
2019-07-25T21:39:31.0672554Z             Error,
2019-07-25T21:39:31.0672590Z         ),
2019-07-25T21:39:31.0672650Z         msg: "17:42: 17:42: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0672733Z     Error {
2019-07-25T21:39:31.0672788Z         line_num: 21,
2019-07-25T21:39:31.0672826Z         kind: Some(
2019-07-25T21:39:31.0672863Z             Error,
2019-07-25T21:39:31.0672863Z             Error,
2019-07-25T21:39:31.0672899Z         ),
2019-07-25T21:39:31.0672959Z         msg: "21:18: 21:18: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0673033Z     Error {
2019-07-25T21:39:31.0673087Z         line_num: 24,
2019-07-25T21:39:31.0673131Z         kind: Some(
2019-07-25T21:39:31.0673169Z             Error,
2019-07-25T21:39:31.0673169Z             Error,
2019-07-25T21:39:31.0675853Z         ),
2019-07-25T21:39:31.0675947Z         msg: "24:19: 24:19: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0676035Z     Error {
2019-07-25T21:39:31.0677111Z         line_num: 27,
2019-07-25T21:39:31.0677177Z         kind: Some(
2019-07-25T21:39:31.0677222Z             Error,
2019-07-25T21:39:31.0677222Z             Error,
2019-07-25T21:39:31.0677290Z         ),
2019-07-25T21:39:31.0677360Z         msg: "27:19: 27:19: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0677449Z     Error {
2019-07-25T21:39:31.0677514Z         line_num: 21,
2019-07-25T21:39:31.0677560Z         kind: Some(
2019-07-25T21:39:31.0677604Z             Error,
2019-07-25T21:39:31.0677604Z             Error,
2019-07-25T21:39:31.0677665Z         ),
2019-07-25T21:39:31.0677717Z         msg: "21:18: 21:19: character constant must be escaped: \\r",
2019-07-25T21:39:31.0677923Z ]
2019-07-25T21:39:31.0677990Z 
2019-07-25T21:39:31.0678039Z not found errors (from test file): [
2019-07-25T21:39:31.0678085Z     Error {
2019-07-25T21:39:31.0678085Z     Error {
2019-07-25T21:39:31.0678323Z         line_num: 5,
2019-07-25T21:39:31.0678540Z         kind: Some(
2019-07-25T21:39:31.0678579Z             Error,
2019-07-25T21:39:31.0678789Z         ),
2019-07-25T21:39:31.0679190Z         msg: "bare CR not allowed in doc-comment",
2019-07-25T21:39:31.0679278Z     Error {
2019-07-25T21:39:31.0679449Z         line_num: 9,
2019-07-25T21:39:31.0679489Z         kind: Some(
2019-07-25T21:39:31.0679526Z             Error,
2019-07-25T21:39:31.0679526Z             Error,
2019-07-25T21:39:31.0679563Z         ),
2019-07-25T21:39:31.0679850Z         msg: "bare CR not allowed in block doc-comment",
2019-07-25T21:39:31.0679932Z     Error {
2019-07-25T21:39:31.0679994Z         line_num: 14,
2019-07-25T21:39:31.0680033Z         kind: Some(
2019-07-25T21:39:31.0680070Z             Error,
2019-07-25T21:39:31.0680070Z             Error,
2019-07-25T21:39:31.0680125Z         ),
2019-07-25T21:39:31.0680354Z         msg: "bare CR not allowed in doc-comment",
2019-07-25T21:39:31.0680438Z     Error {
2019-07-25T21:39:31.0680498Z         line_num: 17,
2019-07-25T21:39:31.0680535Z         kind: Some(
2019-07-25T21:39:31.0680573Z             Error,
2019-07-25T21:39:31.0680573Z             Error,
2019-07-25T21:39:31.0680628Z         ),
2019-07-25T21:39:31.0680852Z         msg: "bare CR not allowed in block doc-comment",
2019-07-25T21:39:31.0680933Z     Error {
2019-07-25T21:39:31.0681003Z         line_num: 21,
2019-07-25T21:39:31.0681041Z         kind: Some(
2019-07-25T21:39:31.0681078Z             Error,
2019-07-25T21:39:31.0681078Z             Error,
2019-07-25T21:39:31.0681323Z         ),
2019-07-25T21:39:31.0681365Z         msg: "bare CR not allowed in string",
2019-07-25T21:39:31.0681457Z     Error {
2019-07-25T21:39:31.0681495Z         line_num: 24,
2019-07-25T21:39:31.0681531Z         kind: Some(
2019-07-25T21:39:31.0681569Z             Error,
2019-07-25T21:39:31.0681569Z             Error,
2019-07-25T21:39:31.0681630Z         ),
2019-07-25T21:39:31.0681671Z         msg: "bare CR not allowed in raw string",
2019-07-25T21:39:31.0681763Z ]
2019-07-25T21:39:31.0681788Z 
2019-07-25T21:39:31.0682366Z thread '[ui] ui/parser/lex-bare-cr-string-literal-doc-comment.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1505:13
2019-07-25T21:39:31.0682420Z 
2019-07-25T21:39:31.0682420Z 
2019-07-25T21:39:31.0682718Z ---- [ui] ui/parser/raw-byte-string-literals.rs stdout ----
2019-07-25T21:39:31.0682771Z 
2019-07-25T21:39:31.0686236Z error: /checkout/src/test/ui/parser/raw-byte-string-literals.rs:4: unexpected error: '4:9: 4:9: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0686302Z 
2019-07-25T21:39:31.0686689Z error: /checkout/src/test/ui/parser/raw-byte-string-literals.rs:4: expected error not found: bare CR not allowed in raw string
2019-07-25T21:39:31.0686734Z 
2019-07-25T21:39:31.0686787Z error: 1 unexpected errors found, 1 expected errors not found
2019-07-25T21:39:31.0686873Z status: exit code: 1
2019-07-25T21:39:31.0687696Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/raw-byte-string-literals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/raw-byte-string-literals" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "continue-parse-after-error" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/raw-byte-string-literals/auxiliary" "-A" "unused"
2019-07-25T21:39:31.0687841Z unexpected errors (from JSON output): [
2019-07-25T21:39:31.0687891Z     Error {
2019-07-25T21:39:31.0688110Z         line_num: 4,
2019-07-25T21:39:31.0688180Z         kind: Some(
2019-07-25T21:39:31.0688257Z         ),
2019-07-25T21:39:31.0688257Z         ),
2019-07-25T21:39:31.0688626Z         msg: "4:9: 4:9: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0688734Z ]
2019-07-25T21:39:31.0688759Z 
2019-07-25T21:39:31.0688823Z not found errors (from test file): [
2019-07-25T21:39:31.0688866Z     Error {
2019-07-25T21:39:31.0688866Z     Error {
2019-07-25T21:39:31.0688905Z         line_num: 4,
2019-07-25T21:39:31.0688963Z         kind: Some(
2019-07-25T21:39:31.0689004Z             Error,
2019-07-25T21:39:31.0689042Z         ),
2019-07-25T21:39:31.0689084Z         msg: "bare CR not allowed in raw string",
2019-07-25T21:39:31.0689243Z ]
2019-07-25T21:39:31.0689268Z 
2019-07-25T21:39:31.0689651Z thread '[ui] ui/parser/raw-byte-string-literals.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1505:13
2019-07-25T21:39:31.0689697Z 
2019-07-25T21:39:31.0689697Z 
2019-07-25T21:39:31.0689960Z ---- [ui] ui/parser/several-carriage-returns-in-doc-comment.rs stdout ----
2019-07-25T21:39:31.0689998Z 
2019-07-25T21:39:31.0690358Z error: /checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs:6: unexpected error: '6:12: 6:12: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0690404Z 
2019-07-25T21:39:31.0690731Z error: /checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs:6: unexpected error: '6:32: 6:32: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0690795Z 
2019-07-25T21:39:31.0691283Z error: /checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs:6: unexpected error: '6:52: 6:52: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0691335Z 
2019-07-25T21:39:31.0691640Z error: /checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs:6: expected error not found: bare CR not allowed in doc-comment
2019-07-25T21:39:31.0691703Z 
2019-07-25T21:39:31.0692005Z error: /checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs:6: expected error not found: bare CR not allowed in doc-comment
2019-07-25T21:39:31.0692046Z 
2019-07-25T21:39:31.0692735Z error: /checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs:6: expected error not found: bare CR not allowed in doc-comment
2019-07-25T21:39:31.0692788Z 
2019-07-25T21:39:31.0692835Z error: 3 unexpected errors found, 3 expected errors not found
2019-07-25T21:39:31.0692879Z status: exit code: 1
2019-07-25T21:39:31.0693693Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/several-carriage-returns-in-doc-comment.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/several-carriage-returns-in-doc-comment" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/several-carriage-returns-in-doc-comment/auxiliary" "-A" "unused"
2019-07-25T21:39:31.0693829Z unexpected errors (from JSON output): [
2019-07-25T21:39:31.0693885Z     Error {
2019-07-25T21:39:31.0693933Z         line_num: 6,
2019-07-25T21:39:31.0693976Z         kind: Some(
2019-07-25T21:39:31.0694083Z         ),
2019-07-25T21:39:31.0694083Z         ),
2019-07-25T21:39:31.0694132Z         msg: "6:12: 6:12: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0694243Z     Error {
2019-07-25T21:39:31.0694285Z         line_num: 6,
2019-07-25T21:39:31.0694346Z         kind: Some(
2019-07-25T21:39:31.0694389Z             Error,
2019-07-25T21:39:31.0694389Z             Error,
2019-07-25T21:39:31.0694440Z         ),
2019-07-25T21:39:31.0694487Z         msg: "6:32: 6:32: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0694592Z     Error {
2019-07-25T21:39:31.0694635Z         line_num: 6,
2019-07-25T21:39:31.0694700Z         kind: Some(
2019-07-25T21:39:31.0694743Z             Error,
2019-07-25T21:39:31.0694743Z             Error,
2019-07-25T21:39:31.0694784Z         ),
2019-07-25T21:39:31.0694850Z         msg: "6:52: 6:52: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0695719Z ]
2019-07-25T21:39:31.0695746Z 
2019-07-25T21:39:31.0695816Z not found errors (from test file): [
2019-07-25T21:39:31.0695861Z     Error {
2019-07-25T21:39:31.0695861Z     Error {
2019-07-25T21:39:31.0695904Z         line_num: 6,
2019-07-25T21:39:31.0695965Z         kind: Some(
2019-07-25T21:39:31.0696010Z             Error,
2019-07-25T21:39:31.0696052Z         ),
2019-07-25T21:39:31.0696391Z         msg: "bare CR not allowed in doc-comment",
2019-07-25T21:39:31.0696595Z     Error {
2019-07-25T21:39:31.0696640Z         line_num: 6,
2019-07-25T21:39:31.0696704Z         kind: Some(
2019-07-25T21:39:31.0696750Z             Error,
2019-07-25T21:39:31.0696750Z             Error,
2019-07-25T21:39:31.0696794Z         ),
2019-07-25T21:39:31.0697079Z         msg: "bare CR not allowed in doc-comment",
2019-07-25T21:39:31.0697197Z     Error {
2019-07-25T21:39:31.0697242Z         line_num: 6,
2019-07-25T21:39:31.0697304Z         kind: Some(
2019-07-25T21:39:31.0697360Z             Error,
2019-07-25T21:39:31.0697360Z             Error,
2019-07-25T21:39:31.0697406Z         ),
2019-07-25T21:39:31.0697667Z         msg: "bare CR not allowed in doc-comment",
2019-07-25T21:39:31.0697782Z ]
2019-07-25T21:39:31.0697863Z 
2019-07-25T21:39:31.0698238Z thread '[ui] ui/parser/several-carriage-returns-in-doc-comment.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1505:13
2019-07-25T21:39:31.0698289Z 
2019-07-25T21:39:31.0698289Z 
2019-07-25T21:39:31.0699217Z ---- [ui] ui/parser/trailing-carriage-return-in-string.rs stdout ----
2019-07-25T21:39:31.0699273Z 
2019-07-25T21:39:31.0699630Z error: /checkout/src/test/ui/parser/trailing-carriage-return-in-string.rs:10: unexpected error: '10:25: 10:25: bare carriage return (\r) is not allowed'
2019-07-25T21:39:31.0699672Z 
2019-07-25T21:39:31.0699717Z error: 1 unexpected errors found, 0 expected errors not found
2019-07-25T21:39:31.0699782Z status: exit code: 1
2019-07-25T21:39:31.0700923Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/parser/trailing-carriage-return-in-string.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/trailing-carriage-return-in-string" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/trailing-carriage-return-in-string/auxiliary" "-A" "unused"
2019-07-25T21:39:31.0701057Z unexpected errors (from JSON output): [
2019-07-25T21:39:31.0701103Z     Error {
2019-07-25T21:39:31.0701150Z         line_num: 10,
2019-07-25T21:39:31.0701212Z         kind: Some(
2019-07-25T21:39:31.0701297Z         ),
2019-07-25T21:39:31.0701297Z         ),
2019-07-25T21:39:31.0701364Z         msg: "10:25: 10:25: bare carriage return (\\r) is not allowed",
2019-07-25T21:39:31.0701453Z ]
2019-07-25T21:39:31.0701488Z 
2019-07-25T21:39:31.0701847Z thread '[ui] ui/parser/trailing-carriage-return-in-string.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1505:13
2019-07-25T21:39:31.0701892Z 
---
2019-07-25T21:39:31.0704062Z 
2019-07-25T21:39:31.0704372Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-25T21:39:31.0704408Z 
2019-07-25T21:39:31.0704551Z 
2019-07-25T21:39:31.0706516Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-25T21:39:31.0706923Z 
2019-07-25T21:39:31.0706957Z 
2019-07-25T21:39:31.0707007Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-25T21:39:31.0707070Z Build completed unsuccessfully in 0:53:55
2019-07-25T21:39:31.0707070Z Build completed unsuccessfully in 0:53:55
2019-07-25T21:39:32.2229294Z ##[error]Bash exited with code '1'.
2019-07-25T21:39:32.2263558Z ##[section]Starting: Checkout
2019-07-25T21:39:32.2265046Z ==============================================================================
2019-07-25T21:39:32.2265492Z Task         : Get sources
2019-07-25T21:39:32.2265554Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matklad matklad force-pushed the matklad:failable-file-loading branch 2 times, most recently from 436e45d to 8e3401a Jul 26, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T10:59:16.5893021Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T10:59:16.6096472Z ##[command]git config gc.auto 0
2019-07-26T10:59:16.6158121Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T10:59:16.6203480Z ##[command]git config --get-all http.proxy
2019-07-26T10:59:16.6340718Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62948/merge:refs/remotes/pull/62948/merge
---
2019-07-26T10:59:53.1023784Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T10:59:53.1023814Z 
2019-07-26T10:59:53.1024025Z   git checkout -b <new-branch-name>
2019-07-26T10:59:53.1024053Z 
2019-07-26T10:59:53.1024098Z HEAD is now at 8a3f79c40 Merge 8e3401a334926a63f11325c2cca2412e066e8bfc into 4268e7ee22935f086b856ef0063a9e22b49aeddb
2019-07-26T10:59:53.1155875Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T10:59:53.1159166Z ==============================================================================
2019-07-26T10:59:53.1159236Z Task         : Bash
2019-07-26T10:59:53.1159284Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T11:58:08.9229858Z .................................................................................................... 200/5863
2019-07-26T11:58:13.0887457Z .................................................................................................... 300/5863
2019-07-26T11:58:16.8253179Z .................................................................................................... 400/5863
2019-07-26T11:58:20.5998321Z .................................................................................................... 500/5863
2019-07-26T11:58:24.4092187Z ........................................................................i........................... 600/5863
2019-07-26T11:58:33.2442804Z .................................................................................................... 800/5863
2019-07-26T11:58:38.7993460Z .................................................................................................... 900/5863
2019-07-26T11:58:43.7580684Z .................................................................................................... 1000/5863
2019-07-26T11:58:43.7580684Z .................................................................................................... 1000/5863
2019-07-26T11:58:49.1621135Z i...........i....................................................................................... 1100/5863
2019-07-26T11:58:53.0350895Z ..............................iiiii................................................................. 1200/5863
2019-07-26T11:58:59.1007935Z .................................................................................................... 1400/5863
2019-07-26T11:59:01.8182796Z .................................................................................................... 1500/5863
2019-07-26T11:59:05.6530610Z .................................................................................................... 1600/5863
2019-07-26T11:59:08.3856224Z .................................................................................................... 1700/5863
2019-07-26T11:59:08.3856224Z .................................................................................................... 1700/5863
2019-07-26T11:59:11.8257839Z ......................................................................i............................. 1800/5863
2019-07-26T11:59:20.3844707Z .................................................................................................... 2000/5863
2019-07-26T11:59:24.6582960Z .................................................................................................... 2100/5863
2019-07-26T11:59:28.3633752Z .................................................................................................... 2200/5863
2019-07-26T11:59:28.3633752Z .................................................................................................... 2200/5863
2019-07-26T11:59:32.1786957Z ......................................................i............................................. 2300/5863
2019-07-26T11:59:41.9423152Z .................................................................................................... 2500/5863
2019-07-26T11:59:46.0393242Z .................................................................................................... 2600/5863
2019-07-26T11:59:51.1364144Z .................................................................................................... 2700/5863
2019-07-26T11:59:54.9555874Z .................................................................................................... 2800/5863
2019-07-26T11:59:54.9555874Z .................................................................................................... 2800/5863
2019-07-26T11:59:59.2851781Z .................................................................................................... 2900/5863
2019-07-26T12:00:04.5922308Z .................................................................................................... 3000/5863
2019-07-26T12:00:08.9684455Z .................................................................................................... 3100/5863
2019-07-26T12:00:14.1927857Z .................................................................................................... 3200/5863
2019-07-26T12:00:17.7254755Z .................................................................................................... 3300/5863
2019-07-26T12:00:21.4277433Z .................................................................................................... 3400/5863
2019-07-26T12:00:26.5225245Z .................................................................................................... 3500/5863
2019-07-26T12:00:30.2554153Z .....................i.............................................................................. 3600/5863
2019-07-26T12:00:34.4581788Z .................................................................................................ii. 3700/5863
2019-07-26T12:00:38.2081714Z ..i..ii............................................................................................. 3800/5863
2019-07-26T12:00:46.8609122Z .................................................................................................... 4000/5863
2019-07-26T12:00:46.8609122Z .................................................................................................... 4000/5863
2019-07-26T12:00:50.8185034Z ................ii.................................................................................. 4100/5863
2019-07-26T12:00:52.9045516Z .....................................i.............................................................. 4200/5863
2019-07-26T12:00:55.0196148Z .................................................................................................... 4300/5863
2019-07-26T12:00:57.2881347Z .......i............................................................................................ 4400/5863
2019-07-26T12:01:18.9521088Z .................................................................................................... 4600/5863
2019-07-26T12:01:22.6947229Z .................................................................................................... 4700/5863
2019-07-26T12:01:26.3241232Z .................................................................................................... 4800/5863
2019-07-26T12:01:31.0932326Z .................................................................................................... 4900/5863
---
2019-07-26T12:02:03.6266067Z .................................................................................................... 5500/5863
2019-07-26T12:02:08.0826853Z .................................................................................................... 5600/5863
2019-07-26T12:02:11.1346470Z .................................................................................................... 5700/5863
2019-07-26T12:02:14.1788737Z .................................................................................................... 5800/5863
2019-07-26T12:02:16.3712764Z ...i...........................................................
2019-07-26T12:02:16.3713322Z 
2019-07-26T12:02:16.3791582Z  finished in 263.277
2019-07-26T12:02:16.3981072Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:02:16.6312001Z 
2019-07-26T12:02:16.6312001Z 
2019-07-26T12:02:16.6312844Z running 2906 tests
2019-07-26T12:02:31.6854065Z .................................................................................................... 100/2906
2019-07-26T12:02:47.2250756Z ..............................................................................i..................... 200/2906
2019-07-26T12:03:11.4992565Z .................................................................................................... 400/2906
2019-07-26T12:03:23.3947030Z .................................................................................................... 500/2906
2019-07-26T12:03:37.8177431Z .................................................................................................... 600/2906
2019-07-26T12:03:59.1538117Z .................................................................................................... 700/2906
2019-07-26T12:03:59.1538117Z .................................................................................................... 700/2906
2019-07-26T12:04:13.1506413Z .................................................................................................... 800/2906
2019-07-26T12:04:24.3977821Z .................................................................................................... 900/2906
2019-07-26T12:04:42.7625513Z .................................................................................................... 1000/2906
2019-07-26T12:04:56.8938641Z .................................................................................................... 1100/2906
2019-07-26T12:05:08.0000500Z .................................................................................................... 1200/2906
2019-07-26T12:05:20.5271679Z .................................................................................................... 1300/2906
2019-07-26T12:05:36.7412884Z .........ii......................................................................................... 1400/2906
2019-07-26T12:05:48.9750959Z .................................................................................................... 1500/2906
2019-07-26T12:06:01.3481402Z .............................................................i.......i.............................. 1600/2906
2019-07-26T12:06:33.7893585Z .................................................................................................... 1800/2906
2019-07-26T12:06:33.7893585Z .................................................................................................... 1800/2906
2019-07-26T12:06:48.8213681Z ............................................................................................i....... 1900/2906
2019-07-26T12:07:16.8226808Z ................................................................i................................... 2000/2906
2019-07-26T12:08:00.3450723Z .................................................................................................... 2200/2906
2019-07-26T12:08:14.8932032Z ...................................................................................................i 2300/2906
2019-07-26T12:08:34.0951882Z i................................................................................................... 2400/2906
2019-07-26T12:08:47.8520319Z .................................................................................................... 2500/2906
---
2019-07-26T12:11:07.2352597Z  finished in 33.886
2019-07-26T12:11:07.2527400Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:11:07.4107432Z 
2019-07-26T12:11:07.4108465Z running 146 tests
2019-07-26T12:11:10.6223355Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-26T12:11:12.5067641Z iii..............i.........iii.i......ii......
2019-07-26T12:11:12.5068170Z 
2019-07-26T12:11:12.5070779Z  finished in 5.253
2019-07-26T12:11:12.5273608Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:11:12.6843721Z 
2019-07-26T12:11:12.6843721Z 
2019-07-26T12:11:12.6843945Z running 39 tests
2019-07-26T12:11:14.6911988Z i.........i......................i.....
2019-07-26T12:11:14.6912562Z 
2019-07-26T12:11:14.6916007Z  finished in 2.164
2019-07-26T12:11:14.7112381Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:11:14.8849373Z 
2019-07-26T12:11:14.8849373Z 
2019-07-26T12:11:14.8850212Z running 9 tests
2019-07-26T12:11:14.8851045Z iiiiiiiii
2019-07-26T12:11:14.8851376Z 
2019-07-26T12:11:14.8851498Z  finished in 0.174
2019-07-26T12:11:14.9128544Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:11:15.0796527Z 
---
2019-07-26T12:11:33.0130404Z  finished in 18.100
2019-07-26T12:11:33.0323060Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:11:33.1894209Z 
2019-07-26T12:11:33.1894417Z running 122 tests
2019-07-26T12:11:56.8228714Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-26T12:12:01.4299643Z .i.i......iii.i.....ii
2019-07-26T12:12:01.4301266Z 
2019-07-26T12:12:01.4304296Z  finished in 28.398
2019-07-26T12:12:01.4310049Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:12:01.4313018Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-26T12:15:43.7403103Z     Finished release [optimized] target(s) in 2m 43s
2019-07-26T12:15:43.7669263Z Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:15:43.9295218Z 
2019-07-26T12:15:43.9297402Z running 315 tests
2019-07-26T12:17:00.0366089Z ....................................i............................................................... 100/315
2019-07-26T12:18:08.3977630Z ....................................................i............................................... 200/315
2019-07-26T12:19:24.1174564Z ...............
2019-07-26T12:19:24.1174945Z test result: ok. 313 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-26T12:19:24.1174995Z 
2019-07-26T12:19:24.1181272Z  finished in 220.351
---
2019-07-26T12:23:23.8028764Z 
2019-07-26T12:23:23.8128063Z 
2019-07-26T12:23:23.8128547Z running 445 tests
2019-07-26T12:23:42.9944754Z .................................................................................................... 100/445
2019-07-26T12:23:59.4293826Z ...................................................................................i................ 200/445
2019-07-26T12:24:28.0722989Z .................................................................................................... 400/445
2019-07-26T12:24:34.7969442Z .............................................
2019-07-26T12:24:34.7970199Z test result: ok. 444 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
2019-07-26T12:24:34.7970413Z 
---
2019-07-26T12:25:48.8200477Z running 961 tests
2019-07-26T12:25:48.8353367Z .................................................................................................... 100/961
2019-07-26T12:25:48.8465887Z .................................................................................................... 200/961
2019-07-26T12:25:48.8561137Z .................................................................................................... 300/961
2019-07-26T12:25:48.9493786Z ............................................................................................ii...... 400/961
2019-07-26T12:25:49.0660350Z .................................................................................................... 600/961
2019-07-26T12:25:49.0744004Z .................................................................................................... 700/961
2019-07-26T12:25:49.0937014Z .................................................................................................... 800/961
2019-07-26T12:25:49.5960358Z .................................................................................................... 900/961
2019-07-26T12:25:49.5960358Z .................................................................................................... 900/961
2019-07-26T12:25:50.6411806Z .............................................................
2019-07-26T12:25:50.6413176Z test result: ok. 959 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-26T12:25:50.6413367Z 
2019-07-26T12:25:50.6414616Z    Doc-tests core
2019-07-26T12:25:54.4704920Z 
2019-07-26T12:25:54.4705623Z running 2379 tests
2019-07-26T12:26:06.3177722Z ......iiiii......................................................................................... 100/2379
2019-07-26T12:26:18.3280787Z .........................................................................ii......................... 200/2379
2019-07-26T12:26:31.6635930Z ...............................................................................................i.... 300/2379
2019-07-26T12:26:46.7296306Z .................................................................................................... 400/2379
2019-07-26T12:26:57.4518694Z ..............................i..i.................iiii............................................. 500/2379
2019-07-26T12:27:19.8004678Z .................................................................................................... 700/2379
2019-07-26T12:27:30.8990462Z .................................................................................................... 800/2379
2019-07-26T12:27:42.2571597Z .................................................................................................... 900/2379
2019-07-26T12:27:53.4563093Z .................................................................................................... 1000/2379
---
2019-07-26T12:29:35.4910548Z .................................................................................................... 1900/2379
2019-07-26T12:29:48.6811171Z .................................................................................................... 2000/2379
2019-07-26T12:30:00.7820434Z .................................................................................................... 2100/2379
2019-07-26T12:30:15.2927147Z .................................................................................................... 2200/2379
2019-07-26T12:30:31.1066438Z ........................................................................................i........... 2300/2379
2019-07-26T12:30:40.7535187Z test result: ok. 2364 passed; 0 failed; 15 ignored; 0 measured; 0 filtered out
2019-07-26T12:30:40.7535232Z 
2019-07-26T12:30:40.7810584Z  finished in 365.970
2019-07-26T12:30:40.7824857Z Testing panic_abort stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-07-26T12:32:49.6685552Z 
2019-07-26T12:32:49.6685759Z running 1009 tests
2019-07-26T12:33:12.4222631Z i................................................................................................... 100/1009
2019-07-26T12:33:25.0614811Z .................................................................................................... 200/1009
2019-07-26T12:33:33.5209994Z .................iii......i......i...i......i....................................................... 300/1009
2019-07-26T12:33:38.1354534Z .................................................................................................... 400/1009
2019-07-26T12:33:45.4694433Z ................................i..i..........................................iiii.......ii......... 500/1009
2019-07-26T12:33:59.4270810Z .................................................................................................... 700/1009
2019-07-26T12:33:59.4270810Z .................................................................................................... 700/1009
2019-07-26T12:34:07.1828320Z ...................................iiii............................................................. 800/1009
2019-07-26T12:34:23.4831504Z .................................................................................................... 900/1009
2019-07-26T12:34:31.3486063Z .........................................................iiii....................................... 1000/1009
2019-07-26T12:34:31.7181874Z test result: ok. 985 passed; 0 failed; 24 ignored; 0 measured; 0 filtered out
2019-07-26T12:34:31.7182962Z 
2019-07-26T12:34:31.7393346Z  finished in 230.501
2019-07-26T12:34:31.7408990Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-07-26T12:37:27.9261058Z 
2019-07-26T12:37:27.9336903Z  finished in 17.312
2019-07-26T12:37:27.9355934Z Testing syntax stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T12:37:28.1316186Z    Compiling syntax v0.0.0 (/checkout/src/libsyntax)
2019-07-26T12:37:30.3650398Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:30.3650724Z    --> src/libsyntax/util/parser_testing.rs:17:25
2019-07-26T12:37:30.3650931Z     |
2019-07-26T12:37:30.3651393Z 17  |           ps.source_map().new_source_file(PathBuf::from("bogofile").into(),
2019-07-26T12:37:30.3652010Z     | 
2019-07-26T12:37:30.3653213Z    ::: src/libsyntax/source_map.rs:191:5
2019-07-26T12:37:30.3653501Z     |
2019-07-26T12:37:30.3653823Z 191 | /     pub fn new_source_file(
---
2019-07-26T12:37:30.3655281Z 219 | |         sf
2019-07-26T12:37:30.3655591Z 220 | |     }
2019-07-26T12:37:30.3656002Z     | |_____- defined here
2019-07-26T12:37:30.3656038Z 
2019-07-26T12:37:31.9100431Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9104595Z     --> src/libsyntax/source_map.rs:1058:12
2019-07-26T12:37:31.9105481Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9105929Z 192  | |         &self,
2019-07-26T12:37:31.9106197Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9106492Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9106492Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9106712Z ...    |
2019-07-26T12:37:31.9106962Z 219  | |         sf
2019-07-26T12:37:31.9107223Z 220  | |     }
2019-07-26T12:37:31.9107474Z      | |_____- defined here
2019-07-26T12:37:31.9107664Z ...
2019-07-26T12:37:31.9107952Z 1058 |           sm.new_source_file(PathBuf::from("blork.rs").into(),
2019-07-26T12:37:31.9108323Z 
2019-07-26T12:37:31.9108323Z 
2019-07-26T12:37:31.9110013Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9110649Z     --> src/libsyntax/source_map.rs:1060:12
2019-07-26T12:37:31.9111657Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9113180Z 192  | |         &self,
2019-07-26T12:37:31.9113993Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9114568Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9114568Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9115207Z ...    |
2019-07-26T12:37:31.9115938Z 219  | |         sf
2019-07-26T12:37:31.9116498Z 220  | |     }
2019-07-26T12:37:31.9116946Z      | |_____- defined here
2019-07-26T12:37:31.9117435Z ...
2019-07-26T12:37:31.9117900Z 1060 |           sm.new_source_file(PathBuf::from("empty.rs").into(),
2019-07-26T12:37:31.9118660Z 
2019-07-26T12:37:31.9118660Z 
2019-07-26T12:37:31.9119136Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9119640Z     --> src/libsyntax/source_map.rs:1062:12
2019-07-26T12:37:31.9120607Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9121042Z 192  | |         &self,
2019-07-26T12:37:31.9121473Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9122096Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9122096Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9123443Z ...    |
2019-07-26T12:37:31.9123938Z 219  | |         sf
2019-07-26T12:37:31.9124245Z 220  | |     }
2019-07-26T12:37:31.9124538Z      | |_____- defined here
2019-07-26T12:37:31.9124767Z ...
2019-07-26T12:37:31.9125078Z 1062 |           sm.new_source_file(PathBuf::from("blork2.rs").into(),
2019-07-26T12:37:31.9125471Z 
2019-07-26T12:37:31.9125471Z 
2019-07-26T12:37:31.9268591Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9272296Z     --> src/libsyntax/source_map.rs:1116:12
2019-07-26T12:37:31.9274796Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9275350Z 192  | |         &self,
2019-07-26T12:37:31.9275975Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9276553Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9276553Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9276953Z ...    |
2019-07-26T12:37:31.9277600Z 219  | |         sf
2019-07-26T12:37:31.9278099Z 220  | |     }
2019-07-26T12:37:31.9278665Z      | |_____- defined here
2019-07-26T12:37:31.9279097Z ...
2019-07-26T12:37:31.9279549Z 1116 |           sm.new_source_file(PathBuf::from("blork.rs").into(),
2019-07-26T12:37:31.9280305Z 
2019-07-26T12:37:31.9280305Z 
2019-07-26T12:37:31.9280801Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9281273Z     --> src/libsyntax/source_map.rs:1118:12
2019-07-26T12:37:31.9282137Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9283182Z 192  | |         &self,
2019-07-26T12:37:31.9283809Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9284669Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9284669Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9285162Z ...    |
2019-07-26T12:37:31.9285672Z 219  | |         sf
2019-07-26T12:37:31.9286557Z 220  | |     }
2019-07-26T12:37:31.9287009Z      | |_____- defined here
2019-07-26T12:37:31.9287375Z ...
2019-07-26T12:37:31.9287824Z 1118 |           sm.new_source_file(PathBuf::from("blork2.rs").into(),
2019-07-26T12:37:31.9288472Z 
2019-07-26T12:37:31.9288472Z 
2019-07-26T12:37:31.9374781Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9375462Z     --> src/libsyntax/source_map.rs:1171:12
2019-07-26T12:37:31.9376535Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9377009Z 192  | |         &self,
2019-07-26T12:37:31.9377497Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9377948Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9377948Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9378339Z ...    |
2019-07-26T12:37:31.9378764Z 219  | |         sf
2019-07-26T12:37:31.9379205Z 220  | |     }
2019-07-26T12:37:31.9379668Z      | |_____- defined here
2019-07-26T12:37:31.9380048Z ...
2019-07-26T12:37:31.9380664Z 1171 |           sm.new_source_file(Path::new("blork.rs").to_owned().into(), inputtext.to_string());
2019-07-26T12:37:31.9382828Z 
2019-07-26T12:37:31.9382828Z 
2019-07-26T12:37:31.9448322Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:31.9448607Z     --> src/libsyntax/source_map.rs:1214:12
2019-07-26T12:37:31.9449090Z 191  | /     pub fn new_source_file(
2019-07-26T12:37:31.9449364Z 192  | |         &self,
2019-07-26T12:37:31.9449631Z 193  | |         handler: &Handler,
2019-07-26T12:37:31.9449924Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9449924Z 194  | |         filename: FileName,
2019-07-26T12:37:31.9450141Z ...    |
2019-07-26T12:37:31.9450394Z 219  | |         sf
2019-07-26T12:37:31.9450666Z 220  | |     }
2019-07-26T12:37:31.9450917Z      | |_____- defined here
2019-07-26T12:37:31.9451303Z ...
2019-07-26T12:37:31.9451605Z 1214 |           sm.new_source_file(Path::new("blork.rs").to_owned().into(), inputtext.to_owned());
2019-07-26T12:37:31.9451927Z 
2019-07-26T12:37:31.9451927Z 
2019-07-26T12:37:33.1076658Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:33.1077660Z    --> src/libsyntax/parse/lexer/mod.rs:750:21
2019-07-26T12:37:33.1078334Z     |
2019-07-26T12:37:33.1078998Z 750 |           let sf = sm.new_source_file(PathBuf::from(teststr.clone()).into(), teststr);
2019-07-26T12:37:33.1080272Z     | 
2019-07-26T12:37:33.1080859Z    ::: src/libsyntax/source_map.rs:191:5
2019-07-26T12:37:33.1081398Z     |
2019-07-26T12:37:33.1082040Z 191 | /     pub fn new_source_file(
---
2019-07-26T12:37:33.1085685Z 219 | |         sf
2019-07-26T12:37:33.1086732Z 220 | |     }
2019-07-26T12:37:33.1087320Z     | |_____- defined here
2019-07-26T12:37:33.1087596Z 
2019-07-26T12:37:34.5595219Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T12:37:34.5595641Z    --> src/libsyntax/test_snippet.rs:46:20
2019-07-26T12:37:34.5595877Z     |
2019-07-26T12:37:34.5596254Z 46  |           source_map.new_source_file(Path::new("test.rs").to_owned().into(), file_text.to_owned());
2019-07-26T12:37:34.5597050Z     | 
2019-07-26T12:37:34.5597714Z    ::: src/libsyntax/source_map.rs:191:5
2019-07-26T12:37:34.5597909Z     |
2019-07-26T12:37:34.5598181Z 191 | /     pub fn new_source_file(
---
2019-07-26T12:37:34.6741941Z 
2019-07-26T12:37:34.6742303Z To learn more, run the command again with --verbose.
2019-07-26T12:37:34.6757624Z 
2019-07-26T12:37:34.6757710Z 
2019-07-26T12:37:34.6758358Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
2019-07-26T12:37:34.6758511Z 
2019-07-26T12:37:34.6758539Z 
2019-07-26T12:37:34.6768077Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-26T12:37:34.6769044Z Build completed unsuccessfully in 1:31:31
2019-07-26T12:37:34.6769044Z Build completed unsuccessfully in 1:31:31
2019-07-26T12:37:35.2903635Z ##[error]Bash exited with code '1'.
2019-07-26T12:37:35.2939195Z ##[section]Starting: Checkout
2019-07-26T12:37:35.2940749Z ==============================================================================
2019-07-26T12:37:35.2940812Z Task         : Get sources
2019-07-26T12:37:35.2940853Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matklad matklad marked this pull request as ready for review Jul 26, 2019

@matklad matklad changed the title WIP: normalize newlines when loading files Normalize newlines when loading files Jul 26, 2019

@matklad

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2019

Added recovery and precise span reporting. Still on the fence about isolated \r. Treating them as errors seems good, but that means that some programs stop to compile.

An alternative would be to just allow then anywhere? In string literals, they will be caught by "escape only char" error, like \t. In doc comments they probably don't matter?

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

I wanted to run crater on this PR once the implementation is ready to find out whether something breaks in practice.

@matklad

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2019

It is ready now

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T13:37:24.4792467Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T13:37:24.4969856Z ##[command]git config gc.auto 0
2019-07-26T13:37:24.5053893Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T13:37:24.5111662Z ##[command]git config --get-all http.proxy
2019-07-26T13:37:24.5256736Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62948/merge:refs/remotes/pull/62948/merge
---
2019-07-26T13:37:59.1682898Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T13:37:59.1683096Z 
2019-07-26T13:37:59.1683430Z   git checkout -b <new-branch-name>
2019-07-26T13:37:59.1683568Z 
2019-07-26T13:37:59.1683708Z HEAD is now at 62f026946 Merge 8e96fd332c69c01e9db98f621e216e0d1c792d43 into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T13:37:59.1819554Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T13:37:59.1822547Z ==============================================================================
2019-07-26T13:37:59.1822597Z Task         : Bash
2019-07-26T13:37:59.1822638Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T14:37:23.1937578Z .................................................................................................... 200/5863
2019-07-26T14:37:27.4461705Z .................................................................................................... 300/5863
2019-07-26T14:37:31.1118658Z .................................................................................................... 400/5863
2019-07-26T14:37:34.9455112Z .................................................................................................... 500/5863
2019-07-26T14:37:38.8713458Z ........................................................................i........................... 600/5863
2019-07-26T14:37:48.0590388Z .................................................................................................... 800/5863
2019-07-26T14:37:53.7879991Z .................................................................................................... 900/5863
2019-07-26T14:37:58.9136317Z .................................................................................................... 1000/5863
2019-07-26T14:37:58.9136317Z .................................................................................................... 1000/5863
2019-07-26T14:38:04.5102039Z i...........i....................................................................................... 1100/5863
2019-07-26T14:38:08.5870049Z ..............................iiiii................................................................. 1200/5863
2019-07-26T14:38:14.9496537Z .................................................................................................... 1400/5863
2019-07-26T14:38:17.7243808Z .................................................................................................... 1500/5863
2019-07-26T14:38:21.6004866Z .................................................................................................... 1600/5863
2019-07-26T14:38:24.3790512Z .................................................................................................... 1700/5863
2019-07-26T14:38:24.3790512Z .................................................................................................... 1700/5863
2019-07-26T14:38:27.9961423Z ......................................................................i............................. 1800/5863
2019-07-26T14:38:37.0011722Z .................................................................................................... 2000/5863
2019-07-26T14:38:41.3821782Z .................................................................................................... 2100/5863
2019-07-26T14:38:45.1506636Z .................................................................................................... 2200/5863
2019-07-26T14:38:45.1506636Z .................................................................................................... 2200/5863
2019-07-26T14:38:49.0925040Z ......................................................i............................................. 2300/5863
2019-07-26T14:38:58.9486818Z .................................................................................................... 2500/5863
2019-07-26T14:39:03.0510064Z .................................................................................................... 2600/5863
2019-07-26T14:39:08.8882184Z .................................................................................................... 2700/5863
2019-07-26T14:39:12.6369741Z .................................................................................................... 2800/5863
2019-07-26T14:39:12.6369741Z .................................................................................................... 2800/5863
2019-07-26T14:39:17.1053562Z .................................................................................................... 2900/5863
2019-07-26T14:39:22.5282394Z .................................................................................................... 3000/5863
2019-07-26T14:39:27.0073770Z .................................................................................................... 3100/5863
2019-07-26T14:39:32.3279091Z .................................................................................................... 3200/5863
2019-07-26T14:39:35.8381194Z .................................................................................................... 3300/5863
2019-07-26T14:39:39.5594212Z .................................................................................................... 3400/5863
2019-07-26T14:39:44.7300203Z .................................................................................................... 3500/5863
2019-07-26T14:39:48.5471228Z .....................i.............................................................................. 3600/5863
2019-07-26T14:39:52.7952498Z .................................................................................................ii. 3700/5863
2019-07-26T14:39:56.5315797Z ..i..ii............................................................................................. 3800/5863
2019-07-26T14:40:05.3039279Z .................................................................................................... 4000/5863
2019-07-26T14:40:05.3039279Z .................................................................................................... 4000/5863
2019-07-26T14:40:09.3108643Z ................ii.................................................................................. 4100/5863
2019-07-26T14:40:11.3852138Z .....................................i.............................................................. 4200/5863
2019-07-26T14:40:13.5819252Z .................................................................................................... 4300/5863
2019-07-26T14:40:15.8209616Z .......i............................................................................................ 4400/5863
2019-07-26T14:40:37.3759092Z .................................................................................................... 4600/5863
2019-07-26T14:40:41.0847186Z .................................................................................................... 4700/5863
2019-07-26T14:40:44.7553350Z .................................................................................................... 4800/5863
2019-07-26T14:40:49.5879025Z .................................................................................................... 4900/5863
---
2019-07-26T14:41:22.6713311Z .................................................................................................... 5500/5863
2019-07-26T14:41:27.1307297Z .................................................................................................... 5600/5863
2019-07-26T14:41:30.1785511Z .................................................................................................... 5700/5863
2019-07-26T14:41:33.2568364Z .................................................................................................... 5800/5863
2019-07-26T14:41:35.4247284Z ...i...........................................................
2019-07-26T14:41:35.4248615Z 
2019-07-26T14:41:35.4320883Z  finished in 268.068
2019-07-26T14:41:35.4502994Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:41:35.6763249Z 
2019-07-26T14:41:35.6763249Z 
2019-07-26T14:41:35.6763994Z running 2906 tests
2019-07-26T14:41:51.1784786Z .................................................................................................... 100/2906
2019-07-26T14:42:06.5048847Z ..............................................................................i..................... 200/2906
2019-07-26T14:42:31.2953239Z .................................................................................................... 400/2906
2019-07-26T14:42:43.3403987Z .................................................................................................... 500/2906
2019-07-26T14:42:57.8851757Z .................................................................................................... 600/2906
2019-07-26T14:43:19.6776893Z .................................................................................................... 700/2906
2019-07-26T14:43:19.6776893Z .................................................................................................... 700/2906
2019-07-26T14:43:34.1119666Z .................................................................................................... 800/2906
2019-07-26T14:43:45.6308562Z .................................................................................................... 900/2906
2019-07-26T14:44:04.4389133Z .................................................................................................... 1000/2906
2019-07-26T14:44:19.0239186Z .................................................................................................... 1100/2906
2019-07-26T14:44:30.4376813Z .................................................................................................... 1200/2906
2019-07-26T14:44:43.0640312Z .................................................................................................... 1300/2906
2019-07-26T14:44:59.5461088Z .........ii......................................................................................... 1400/2906
2019-07-26T14:45:12.3567155Z .................................................................................................... 1500/2906
2019-07-26T14:45:25.4916610Z .............................................................i.......i.............................. 1600/2906
2019-07-26T14:45:59.5368672Z .................................................................................................... 1800/2906
2019-07-26T14:45:59.5368672Z .................................................................................................... 1800/2906
2019-07-26T14:46:15.1759665Z ............................................................................................i....... 1900/2906
2019-07-26T14:46:41.6560150Z ................................................................i................................... 2000/2906
2019-07-26T14:47:26.1938357Z .................................................................................................... 2200/2906
2019-07-26T14:47:41.0000615Z ...................................................................................................i 2300/2906
2019-07-26T14:48:00.5200143Z i................................................................................................... 2400/2906
2019-07-26T14:48:14.6640908Z .................................................................................................... 2500/2906
---
2019-07-26T14:50:34.6381114Z  finished in 31.700
2019-07-26T14:50:34.6560531Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:50:34.8254918Z 
2019-07-26T14:50:34.8255355Z running 146 tests
2019-07-26T14:50:38.2678385Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-26T14:50:40.2190249Z iii..............i.........iii.i......ii......
2019-07-26T14:50:40.2190893Z 
2019-07-26T14:50:40.2191563Z  finished in 5.562
2019-07-26T14:50:40.2365109Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:50:40.4035714Z 
2019-07-26T14:50:40.4035714Z 
2019-07-26T14:50:40.4036005Z running 39 tests
2019-07-26T14:50:42.6207986Z i.........i......................i.....
2019-07-26T14:50:42.6211029Z 
2019-07-26T14:50:42.6211184Z  finished in 2.384
2019-07-26T14:50:42.6396593Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:50:42.8129394Z 
2019-07-26T14:50:42.8129394Z 
2019-07-26T14:50:42.8130187Z running 9 tests
2019-07-26T14:50:42.8133520Z iiiiiiiii
2019-07-26T14:50:42.8133929Z 
2019-07-26T14:50:42.8134049Z  finished in 0.173
2019-07-26T14:50:42.8324737Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:50:43.0048250Z 
---
2019-07-26T14:51:01.3303581Z  finished in 18.498
2019-07-26T14:51:01.3502890Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:51:01.5094943Z 
2019-07-26T14:51:01.5095263Z running 122 tests
2019-07-26T14:51:25.1778692Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-26T14:51:29.8345367Z .i.i......iii.i.....ii
2019-07-26T14:51:29.8345838Z 
2019-07-26T14:51:29.8349852Z  finished in 28.484
2019-07-26T14:51:29.8355096Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:51:29.8355428Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-26T14:55:17.1926578Z     Finished release [optimized] target(s) in 2m 47s
2019-07-26T14:55:17.2166264Z Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T14:55:17.3975174Z 
2019-07-26T14:55:17.3975707Z running 315 tests
2019-07-26T14:56:35.8327857Z ....................................i............................................................... 100/315
2019-07-26T14:57:46.4525872Z ....................................................i............................................... 200/315
2019-07-26T14:59:04.1565875Z ...............
2019-07-26T14:59:04.1567953Z test result: ok. 313 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-26T14:59:04.1568655Z 
2019-07-26T14:59:04.1568902Z  finished in 226.940
---
2019-07-26T15:03:25.0832642Z 
2019-07-26T15:03:25.0939883Z 
2019-07-26T15:03:25.0940055Z running 445 tests
2019-07-26T15:03:45.9878124Z .................................................................................................... 100/445
2019-07-26T15:04:03.7243929Z ...................................................................................i................ 200/445
2019-07-26T15:04:34.4549552Z .................................................................................................... 400/445
2019-07-26T15:04:41.4614379Z .............................................
2019-07-26T15:04:41.4614562Z test result: ok. 444 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
2019-07-26T15:04:41.4614602Z 
---
2019-07-26T15:06:04.4910879Z running 961 tests
2019-07-26T15:06:04.5034592Z .................................................................................................... 100/961
2019-07-26T15:06:04.5107021Z .................................................................................................... 200/961
2019-07-26T15:06:04.5207483Z .................................................................................................... 300/961
2019-07-26T15:06:04.6128642Z ............................................................................................ii...... 400/961
2019-07-26T15:06:04.7327031Z .................................................................................................... 600/961
2019-07-26T15:06:04.7442851Z .................................................................................................... 700/961
2019-07-26T15:06:04.7668642Z .................................................................................................... 800/961
2019-07-26T15:06:05.2720809Z .................................................................................................... 900/961
2019-07-26T15:06:05.2720809Z .................................................................................................... 900/961
2019-07-26T15:06:06.4748353Z .............................................................
2019-07-26T15:06:06.4749432Z test result: ok. 959 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-07-26T15:06:06.4749605Z 
2019-07-26T15:06:06.4750828Z    Doc-tests core
2019-07-26T15:06:10.6599668Z 
2019-07-26T15:06:10.6600691Z running 2379 tests
2019-07-26T15:06:23.6387357Z ......iiiii......................................................................................... 100/2379
2019-07-26T15:06:36.7543006Z .........................................................................ii......................... 200/2379
2019-07-26T15:06:51.2489781Z ...............................................................................................i.... 300/2379
2019-07-26T15:07:07.6481488Z .................................................................................................... 400/2379
2019-07-26T15:07:18.9970697Z ..............................i..i.................iiii............................................. 500/2379
2019-07-26T15:07:43.0455820Z .................................................................................................... 700/2379
2019-07-26T15:07:55.1041716Z .................................................................................................... 800/2379
2019-07-26T15:08:07.2640203Z .................................................................................................... 900/2379
2019-07-26T15:08:19.3769877Z .................................................................................................... 1000/2379
---
2019-07-26T15:10:11.0937797Z .................................................................................................... 1900/2379
2019-07-26T15:10:25.1837793Z .................................................................................................... 2000/2379
2019-07-26T15:10:38.1129232Z .................................................................................................... 2100/2379
2019-07-26T15:10:53.6860552Z .................................................................................................... 2200/2379
2019-07-26T15:11:10.5799942Z ........................................................................................i........... 2300/2379
2019-07-26T15:11:21.1825317Z test result: ok. 2364 passed; 0 failed; 15 ignored; 0 measured; 0 filtered out
2019-07-26T15:11:21.1825542Z 
2019-07-26T15:11:21.2121709Z  finished in 399.737
2019-07-26T15:11:21.2158455Z Testing panic_abort stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-07-26T15:13:29.1567696Z ............................................. 300/756
2019-07-26T15:13:29.1569026Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-07-26T15:13:29.2602220Z ................................................................................................... 400/756
2019-07-26T15:13:31.9170051Z .................................................................................................... 500/756
2019-07-26T15:13:31.9171745Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1051:5
2019-07-26T15:13:31.9172343Z ....thread '<unnamed>thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1051:5
2019-07-26T15:13:31.9172943Z .' panicked at '..called `Result::unwrap()` on an `Err` value: RecvError...', .src/libcore/result.rsthread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1051:5
2019-07-26T15:13:31.9173568Z ...:..1051...:.5.
2019-07-26T15:13:31.9174154Z ................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1051:5
2019-07-26T15:13:31.9174916Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1051:<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', 5
2019-07-26T15:13:31.9182668Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1051:5
2019-07-26T15:13:31.9183159Z ....................... 600/756
2019-07-26T15:13:33.6149153Z .................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-07-26T15:13:33.6150170Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
---
2019-07-26T15:13:43.0977945Z 
2019-07-26T15:13:43.0978690Z running 1009 tests
2019-07-26T15:14:07.3188176Z i................................................................................................... 100/1009
2019-07-26T15:14:20.7841552Z .................................................................................................... 200/1009
2019-07-26T15:14:30.0216972Z .................iii......i......i...i......i....................................................... 300/1009
2019-07-26T15:14:35.0687006Z .................................................................................................... 400/1009
2019-07-26T15:14:42.9338972Z ................................i..i..........................................iiii.......ii......... 500/1009
2019-07-26T15:14:57.8733871Z .................................................................................................... 700/1009
2019-07-26T15:14:57.8733871Z .................................................................................................... 700/1009
2019-07-26T15:15:06.1906539Z ...................................iiii............................................................. 800/1009
2019-07-26T15:15:23.1567507Z .................................................................................................... 900/1009
2019-07-26T15:15:31.5649159Z .........................................................iiii....................................... 1000/1009
2019-07-26T15:15:31.9655067Z test result: ok. 985 passed; 0 failed; 24 ignored; 0 measured; 0 filtered out
2019-07-26T15:15:31.9655105Z 
2019-07-26T15:15:31.9961992Z  finished in 250.263
2019-07-26T15:15:31.9963731Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-07-26T15:18:45.6942922Z 
2019-07-26T15:18:45.7024003Z  finished in 18.856
2019-07-26T15:18:45.7048327Z Testing syntax stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-26T15:18:45.9186168Z    Compiling syntax v0.0.0 (/checkout/src/libsyntax)
2019-07-26T15:18:48.4876906Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:48.4878430Z    --> src/libsyntax/util/parser_testing.rs:17:25
2019-07-26T15:18:48.4879020Z     |
2019-07-26T15:18:48.4879965Z 17  |           ps.source_map().new_source_file(PathBuf::from("bogofile").into(),
2019-07-26T15:18:48.4880785Z     | 
2019-07-26T15:18:48.4881072Z    ::: src/libsyntax/source_map.rs:191:5
2019-07-26T15:18:48.4881326Z     |
2019-07-26T15:18:48.4881657Z 191 | /     pub fn new_source_file(
---
2019-07-26T15:18:48.4883688Z 219 | |         sf
2019-07-26T15:18:48.4884225Z 220 | |     }
2019-07-26T15:18:48.4884558Z     | |_____- defined here
2019-07-26T15:18:48.4884597Z 
2019-07-26T15:18:50.3315976Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3317239Z     --> src/libsyntax/source_map.rs:1058:12
2019-07-26T15:18:50.3319071Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3319683Z 192  | |         &self,
2019-07-26T15:18:50.3320276Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3321021Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3321021Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3321514Z ...    |
2019-07-26T15:18:50.3322250Z 219  | |         sf
2019-07-26T15:18:50.3322814Z 220  | |     }
2019-07-26T15:18:50.3323362Z      | |_____- defined here
2019-07-26T15:18:50.3323855Z ...
2019-07-26T15:18:50.3326718Z 1058 |           sm.new_source_file(PathBuf::from("blork.rs").into(),
2019-07-26T15:18:50.3327982Z 
2019-07-26T15:18:50.3327982Z 
2019-07-26T15:18:50.3328576Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3329348Z     --> src/libsyntax/source_map.rs:1060:12
2019-07-26T15:18:50.3330435Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3330996Z 192  | |         &self,
2019-07-26T15:18:50.3331567Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3332916Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3332916Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3333499Z ...    |
2019-07-26T15:18:50.3333996Z 219  | |         sf
2019-07-26T15:18:50.3334457Z 220  | |     }
2019-07-26T15:18:50.3334910Z      | |_____- defined here
2019-07-26T15:18:50.3335534Z ...
2019-07-26T15:18:50.3336076Z 1060 |           sm.new_source_file(PathBuf::from("empty.rs").into(),
2019-07-26T15:18:50.3337000Z 
2019-07-26T15:18:50.3337000Z 
2019-07-26T15:18:50.3337533Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3337989Z     --> src/libsyntax/source_map.rs:1062:12
2019-07-26T15:18:50.3338987Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3339437Z 192  | |         &self,
2019-07-26T15:18:50.3339877Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3340335Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3340335Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3340727Z ...    |
2019-07-26T15:18:50.3341347Z 219  | |         sf
2019-07-26T15:18:50.3341802Z 220  | |     }
2019-07-26T15:18:50.3342236Z      | |_____- defined here
2019-07-26T15:18:50.3342606Z ...
2019-07-26T15:18:50.3343276Z 1062 |           sm.new_source_file(PathBuf::from("blork2.rs").into(),
2019-07-26T15:18:50.3343953Z 
2019-07-26T15:18:50.3343953Z 
2019-07-26T15:18:50.3515325Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3517265Z     --> src/libsyntax/source_map.rs:1116:12
2019-07-26T15:18:50.3518550Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3519039Z 192  | |         &self,
2019-07-26T15:18:50.3519519Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3519993Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3519993Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3520432Z ...    |
2019-07-26T15:18:50.3521054Z 219  | |         sf
2019-07-26T15:18:50.3521675Z 220  | |     }
2019-07-26T15:18:50.3522129Z      | |_____- defined here
2019-07-26T15:18:50.3522478Z ...
2019-07-26T15:18:50.3522978Z 1116 |           sm.new_source_file(PathBuf::from("blork.rs").into(),
2019-07-26T15:18:50.3523766Z 
2019-07-26T15:18:50.3523766Z 
2019-07-26T15:18:50.3524247Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3524648Z     --> src/libsyntax/source_map.rs:1118:12
2019-07-26T15:18:50.3526106Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3526987Z 192  | |         &self,
2019-07-26T15:18:50.3527516Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3528014Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3528014Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3528436Z ...    |
2019-07-26T15:18:50.3528918Z 219  | |         sf
2019-07-26T15:18:50.3529389Z 220  | |     }
2019-07-26T15:18:50.3529893Z      | |_____- defined here
2019-07-26T15:18:50.3530298Z ...
2019-07-26T15:18:50.3530784Z 1118 |           sm.new_source_file(PathBuf::from("blork2.rs").into(),
2019-07-26T15:18:50.3531506Z 
2019-07-26T15:18:50.3531506Z 
2019-07-26T15:18:50.3638048Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3638388Z     --> src/libsyntax/source_map.rs:1171:12
2019-07-26T15:18:50.3641160Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3641944Z 192  | |         &self,
2019-07-26T15:18:50.3642667Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3643585Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3643585Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3644100Z ...    |
2019-07-26T15:18:50.3644645Z 219  | |         sf
2019-07-26T15:18:50.3645172Z 220  | |     }
2019-07-26T15:18:50.3646275Z      | |_____- defined here
2019-07-26T15:18:50.3646831Z ...
2019-07-26T15:18:50.3647490Z 1171 |           sm.new_source_file(Path::new("blork.rs").to_owned().into(), inputtext.to_string());
2019-07-26T15:18:50.3648392Z 
2019-07-26T15:18:50.3648392Z 
2019-07-26T15:18:50.3724363Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:50.3724689Z     --> src/libsyntax/source_map.rs:1214:12
2019-07-26T15:18:50.3725226Z 191  | /     pub fn new_source_file(
2019-07-26T15:18:50.3725911Z 192  | |         &self,
2019-07-26T15:18:50.3726317Z 193  | |         handler: &Handler,
2019-07-26T15:18:50.3726837Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3726837Z 194  | |         filename: FileName,
2019-07-26T15:18:50.3727082Z ...    |
2019-07-26T15:18:50.3727393Z 219  | |         sf
2019-07-26T15:18:50.3727673Z 220  | |     }
2019-07-26T15:18:50.3727975Z      | |_____- defined here
2019-07-26T15:18:50.3728185Z ...
2019-07-26T15:18:50.3728527Z 1214 |           sm.new_source_file(Path::new("blork.rs").to_owned().into(), inputtext.to_owned());
2019-07-26T15:18:50.3728989Z 
2019-07-26T15:18:50.3728989Z 
2019-07-26T15:18:51.7540388Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:51.7540743Z    --> src/libsyntax/parse/lexer/mod.rs:750:21
2019-07-26T15:18:51.7541001Z     |
2019-07-26T15:18:51.7541473Z 750 |           let sf = sm.new_source_file(PathBuf::from(teststr.clone()).into(), teststr);
2019-07-26T15:18:51.7542025Z     | 
2019-07-26T15:18:51.7542436Z    ::: src/libsyntax/source_map.rs:191:5
2019-07-26T15:18:51.7542697Z     |
2019-07-26T15:18:51.7542999Z 191 | /     pub fn new_source_file(
---
2019-07-26T15:18:51.7544330Z 219 | |         sf
2019-07-26T15:18:51.7544599Z 220 | |     }
2019-07-26T15:18:51.7544868Z     | |_____- defined here
2019-07-26T15:18:51.7544920Z 
2019-07-26T15:18:53.3780808Z error[E0061]: this function takes 3 parameters but 2 parameters were supplied
2019-07-26T15:18:53.3781731Z    --> src/libsyntax/test_snippet.rs:46:20
2019-07-26T15:18:53.3782292Z     |
2019-07-26T15:18:53.3782753Z 46  |           source_map.new_source_file(Path::new("test.rs").to_owned().into(), file_text.to_owned());
2019-07-26T15:18:53.3783547Z     | 
2019-07-26T15:18:53.3783941Z    ::: src/libsyntax/source_map.rs:191:5
2019-07-26T15:18:53.3784525Z     |
2019-07-26T15:18:53.3784934Z 191 | /     pub fn new_source_file(
---
2019-07-26T15:18:53.5134529Z 
2019-07-26T15:18:53.5135210Z To learn more, run the command again with --verbose.
2019-07-26T15:18:53.5150090Z 
2019-07-26T15:18:53.5150488Z 
2019-07-26T15:18:53.5151648Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
2019-07-26T15:18:53.5151833Z 
2019-07-26T15:18:53.5151883Z 
2019-07-26T15:18:53.5162717Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-26T15:18:53.5163291Z Build completed unsuccessfully in 1:34:33
2019-07-26T15:18:53.5163291Z Build completed unsuccessfully in 1:34:33
2019-07-26T15:18:54.1518356Z ##[error]Bash exited with code '1'.
2019-07-26T15:18:54.1560339Z ##[section]Starting: Checkout
2019-07-26T15:18:54.1561976Z ==============================================================================
2019-07-26T15:18:54.1562051Z Task         : Get sources
2019-07-26T15:18:54.1562100Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T16:39:44.9776872Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T16:39:45.0040904Z ##[command]git config gc.auto 0
2019-07-26T16:39:45.0065109Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T16:39:45.0125551Z ##[command]git config --get-all http.proxy
2019-07-26T16:39:45.0259149Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62948/merge:refs/remotes/pull/62948/merge
---
2019-07-26T16:40:20.3331406Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T16:40:20.3332519Z 
2019-07-26T16:40:20.3333924Z   git checkout -b <new-branch-name>
2019-07-26T16:40:20.3334975Z 
2019-07-26T16:40:20.3336569Z HEAD is now at a62d482c5 Merge 36935a9ceea2570ec9025296c1b0257c8b692198 into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T16:40:20.3477059Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T16:40:20.3479785Z ==============================================================================
2019-07-26T16:40:20.3479838Z Task         : Bash
2019-07-26T16:40:20.3480403Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T16:46:19.0271961Z    Compiling serde_json v1.0.40
2019-07-26T16:46:23.4741104Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T16:46:31.1611984Z     Finished release [optimized] target(s) in 1m 24s
2019-07-26T16:46:31.1678858Z tidy check
2019-07-26T16:46:31.3339314Z tidy error: /checkout/src/libsyntax/test_snippet.rs:46: line longer than 100 chars
2019-07-26T16:46:32.8679625Z some tidy checks failed
2019-07-26T16:46:32.8681117Z 
2019-07-26T16:46:32.8681117Z 
2019-07-26T16:46:32.8699963Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-07-26T16:46:32.8700451Z 
2019-07-26T16:46:32.8700556Z 
2019-07-26T16:46:32.8710330Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T16:46:32.8710671Z Build completed unsuccessfully in 0:01:27
2019-07-26T16:46:32.8710671Z Build completed unsuccessfully in 0:01:27
2019-07-26T16:46:34.2387548Z ##[error]Bash exited with code '1'.
2019-07-26T16:46:34.2439807Z ##[section]Starting: Checkout
2019-07-26T16:46:34.2441199Z ==============================================================================
2019-07-26T16:46:34.2441242Z Task         : Get sources
2019-07-26T16:46:34.2441296Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matklad matklad force-pushed the matklad:failable-file-loading branch from 36935a9 to 70d8e84 Jul 26, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

☔️ The latest upstream changes (presumably #63057) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

@matklad
Could you rebase the PR so we could run crater?

@matklad matklad force-pushed the matklad:failable-file-loading branch from 70d8e84 to 9d2fce9 Jul 29, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-29T16:20:10.8863932Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-29T16:20:10.9040554Z ##[command]git config gc.auto 0
2019-07-29T16:20:10.9116213Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-29T16:20:10.9176498Z ##[command]git config --get-all http.proxy
2019-07-29T16:20:10.9313408Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62948/merge:refs/remotes/pull/62948/merge
---
2019-07-29T16:20:45.5391422Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-29T16:20:45.5391495Z 
2019-07-29T16:20:45.5391686Z   git checkout -b <new-branch-name>
2019-07-29T16:20:45.5391740Z 
2019-07-29T16:20:45.5391780Z HEAD is now at 0f2f39e9b Merge 9d2fce9fbec2700d164b1e0a8cab5a72719d26bd into 04b88a9eba8abbac87eddcb2998beea09589c2c9
2019-07-29T16:20:45.5522447Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-29T16:20:45.5525513Z ==============================================================================
2019-07-29T16:20:45.5525566Z Task         : Bash
2019-07-29T16:20:45.5525609Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-29T17:17:16.8658399Z .................................................................................................... 1400/8805
2019-07-29T17:17:22.8609166Z .................................................................................................... 1500/8805
2019-07-29T17:17:35.7750152Z ................................................................i...............i................... 1600/8805
2019-07-29T17:17:43.5127032Z .................................................................................................... 1700/8805
2019-07-29T17:17:58.7423083Z ..................................................iiiii............................................. 1800/8805
2019-07-29T17:18:10.1170788Z .................................................................................................... 2000/8805
2019-07-29T17:18:12.7104695Z .................................................................................................... 2100/8805
2019-07-29T17:18:16.7354639Z .................................................................................................... 2200/8805
2019-07-29T17:18:23.3724658Z .................................................................................................... 2300/8805
---
2019-07-29T17:22:12.7595777Z .................................................................................................... 5200/8805
2019-07-29T17:22:23.6173938Z .................................................................................................... 5300/8805
2019-07-29T17:22:31.1711375Z ..i................................................................................................. 5400/8805
2019-07-29T17:22:36.5683418Z .................................................................................................... 5500/8805
2019-07-29T17:22:48.8743546Z ................................................................................................ii.. 5600/8805
2019-07-29T17:23:03.7710885Z .i..ii...........i.................................................................................. 5700/8805
2019-07-29T17:23:19.3109456Z .................................................................................................... 5900/8805
2019-07-29T17:23:24.1001094Z ................................................................................................i..i 6000/8805
2019-07-29T17:23:38.5826311Z i................................................................................................... 6100/8805
2019-07-29T17:23:55.2274693Z .................................................................................................... 6200/8805
---
2019-07-29T17:28:48.7173740Z  finished in 20.564
2019-07-29T17:28:48.7371007Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:28:48.8999889Z 
2019-07-29T17:28:48.9000188Z running 146 tests
2019-07-29T17:28:52.2250282Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-29T17:28:54.0860178Z iii..............i.........iii.i......ii......
2019-07-29T17:28:54.0861454Z 
2019-07-29T17:28:54.0865355Z  finished in 5.349
2019-07-29T17:28:54.1059170Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:28:54.2689655Z 
---
2019-07-29T17:28:56.3428960Z  finished in 2.236
2019-07-29T17:28:56.3611418Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:28:56.5279320Z 
2019-07-29T17:28:56.5279585Z running 9 tests
2019-07-29T17:28:56.5280429Z iiiiiiiii
2019-07-29T17:28:56.5280860Z 
2019-07-29T17:28:56.5284088Z  finished in 0.167
2019-07-29T17:28:56.5477429Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:28:56.7116685Z 
---
2019-07-29T17:29:15.1632831Z  finished in 18.615
2019-07-29T17:29:15.1833533Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:29:15.3478580Z 
2019-07-29T17:29:15.3481748Z running 122 tests
2019-07-29T17:29:39.3216513Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-29T17:29:43.9618879Z .i.i......iii.i.....ii
2019-07-29T17:29:43.9620366Z 
2019-07-29T17:29:43.9624679Z  finished in 28.778
2019-07-29T17:29:43.9630709Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:29:43.9631126Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-29T17:43:35.4725499Z 
2019-07-29T17:43:35.4726307Z    Doc-tests core
2019-07-29T17:43:39.5532581Z 
2019-07-29T17:43:39.5533062Z running 2379 tests
2019-07-29T17:43:51.6229655Z ......iiiii......................................................................................... 100/2379
2019-07-29T17:44:03.6406737Z .........................................................................ii......................... 200/2379
2019-07-29T17:44:32.3762135Z .................................................................................................... 400/2379
2019-07-29T17:44:32.3762135Z .................................................................................................... 400/2379
2019-07-29T17:44:43.2488752Z ..............................i..i.................iiii............................................. 500/2379
2019-07-29T17:45:05.7003856Z .................................................................................................... 700/2379
2019-07-29T17:45:17.2000786Z .................................................................................................... 800/2379
2019-07-29T17:45:28.5234001Z .................................................................................................... 900/2379
2019-07-29T17:45:39.9139995Z .................................................................................................... 1000/2379
---
2019-07-29T17:50:47.4855073Z 
2019-07-29T17:50:47.4856155Z running 989 tests
2019-07-29T17:51:10.5857700Z i................................................................................................... 100/989
2019-07-29T17:51:23.5811158Z .................................................................................................... 200/989
2019-07-29T17:51:32.1929348Z .................iii......i......i...i......i....................................................... 300/989
2019-07-29T17:51:36.9506377Z .................................................................................................... 400/989
2019-07-29T17:51:44.8146778Z ................................i..i.................................ii............................. 500/989
2019-07-29T17:51:59.3880609Z .................................................................................................... 700/989
2019-07-29T17:51:59.3880609Z .................................................................................................... 700/989
2019-07-29T17:52:07.7189421Z ...............iiii................................................................................. 800/989
2019-07-29T17:52:22.0172542Z .................................................................................................... 900/989
2019-07-29T17:52:29.4097676Z .....................................iiii................................................
2019-07-29T17:52:29.4098608Z 
2019-07-29T17:52:29.4292587Z  finished in 239.517
2019-07-29T17:52:29.4308467Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T17:52:29.6203949Z     Finished release [optimized] target(s) in 0.18s
---
2019-07-29T17:54:28.5355127Z running 8 tests
2019-07-29T17:54:28.5355177Z F..F....
2019-07-29T17:54:28.5355219Z failures:
2019-07-29T17:54:28.5355247Z 
2019-07-29T17:54:28.5355722Z ---- unescape::tests::test_unescape_byte_bad stdout ----
2019-07-29T17:54:28.5356056Z thread 'unescape::tests::test_unescape_byte_bad' panicked at 'assertion failed: `(left == right)`
2019-07-29T17:54:28.5356114Z   left: `Err(MoreThanOneChar)`,
2019-07-29T17:54:28.5356647Z  right: `Err(EscapeOnlyChar)`', src/librustc_lexer/src/unescape.rs:430:13
2019-07-29T17:54:28.5356741Z 
2019-07-29T17:54:28.5357004Z ---- unescape::tests::test_unescape_char_bad stdout ----
2019-07-29T17:54:28.5357004Z ---- unescape::tests::test_unescape_char_bad stdout ----
2019-07-29T17:54:28.5357290Z thread 'unescape::tests::test_unescape_char_bad' panicked at 'assertion failed: `(left == right)`
2019-07-29T17:54:28.5357345Z   left: `Err(MoreThanOneChar)`,
2019-07-29T17:54:28.5357625Z  right: `Err(EscapeOnlyChar)`', src/librustc_lexer/src/unescape.rs:308:13
2019-07-29T17:54:28.5357689Z 
2019-07-29T17:54:28.5357732Z failures:
2019-07-29T17:54:28.5357799Z     unescape::tests::test_unescape_byte_bad
2019-07-29T17:54:28.5357848Z     unescape::tests::test_unescape_char_bad
2019-07-29T17:54:28.5357848Z     unescape::tests::test_unescape_char_bad
2019-07-29T17:54:28.5358126Z 
2019-07-29T17:54:28.5358189Z test result: FAILED. 6 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
2019-07-29T17:54:28.5358248Z 
2019-07-29T17:54:28.5368242Z error: test failed, to rerun pass '-p rustc_lexer --lib'
2019-07-29T17:54:28.5389716Z 
2019-07-29T17:54:28.5389716Z 
2019-07-29T17:54:28.5390996Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_lexer" "--" "--quiet"
2019-07-29T17:54:28.5391354Z 
2019-07-29T17:54:28.5391392Z 
2019-07-29T17:54:28.5396821Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-29T17:54:28.5396928Z Build completed unsuccessfully in 1:27:56
2019-07-29T17:54:28.5396928Z Build completed unsuccessfully in 1:27:56
2019-07-29T17:54:29.1331496Z ##[error]Bash exited with code '1'.
2019-07-29T17:54:29.1367093Z ##[section]Starting: Checkout
2019-07-29T17:54:29.1369472Z ==============================================================================
2019-07-29T17:54:29.1369562Z Task         : Get sources
2019-07-29T17:54:29.1369612Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matklad matklad force-pushed the matklad:failable-file-loading branch from 9d2fce9 to 2b38e09 Jul 29, 2019

@matklad

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

⌛️ Trying commit 2b38e09 with merge ab1af76...

bors added a commit that referenced this pull request Jul 29, 2019

Auto merge of #62948 - matklad:failable-file-loading, r=<try>
Normalize newlines when loading files

Fixes #62865

@bors bors referenced this pull request Jul 29, 2019

Closed

Rollup of 13 pull requests #63119

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

☀️ Try build successful - checks-azure
Build commit: ab1af76

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@craterbot run mode=check-only

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2019

👌 Experiment pr-62948 created and queued.
🤖 Automatically detected try build ab1af76
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 4, 2019

🚧 Experiment pr-62948 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

🎉 Experiment pr-62948 is completed!
📊 16 regressed and 0 fixed (70078 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@@ -153,7 +153,7 @@ pub fn expand_include_bytes(cx: &mut ExtCtxt<'_>, sp: Span, tts: &[tokenstream::
},
Err(e) => (String::new(), e.into_bytes()),
};
cx.source_map().new_source_file(file.into(), contents);
cx.source_map().new_source_file(&cx.parse_sess.span_diagnostic, file.into(), contents);

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 8, 2019

Contributor

Ha.
include_bytes! certainly shouldn't do the normalization.
I didn't check all the regressions, but the ones I checked are caused by this.

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 8, 2019

Contributor

(It also shouldn't remove BOM, so if it did, it was a bug.)

This comment has been minimized.

Copy link
@matklad

matklad Aug 8, 2019

Author Member

I think this is actually not a bug, see #54517

The TL;DR is that we want to add something to source_map to track dependencies (so adding "" is OK), but if we simulateneously include file as include_bytes and as a proper module, stuff will blow up because the module will see empty string.

It centrally feels like "add file to source map to track deps" is a smell, at least because we essentially store the file twice (as Vec<u8> and as a String). Can we directly register file as a dependency?

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 8, 2019

Contributor

Ah, I see, so the byte literal contains the original data and the copy processed by new_source_file (which reports the "bare \r" errors in process) is thrown away.

Can we directly register file as a dependency?

Probably?
I'm not familiar with that code but don't see why parse_sess couldn't e.g. contain a list of files to add to deps in addition to the source map files.

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 9, 2019

Contributor

Marking as "waiting-on-author" for investigation.
The include_binary! files either need to skip all the error reporting from new_source_file, or better extract the parts of new_source_file that are relevant to binary files (registering as dependency? maybe something else?) into some new new_binary_file.

This comment has been minimized.

Copy link
@matklad

matklad Aug 13, 2019

Author Member

Another issue here is that we literally do std::fs::read here, dodging the FileLoader infra which doesn't have allowance for binary files at all...

@matklad matklad force-pushed the matklad:failable-file-loading branch from 2b38e09 to 911398b Aug 14, 2019

@matklad

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

I've changed the strategy from bailing on lone \r to just not doing anything special with them.

That is, we still forbid isolated \r in string literals and doc comments, but only during the lexing phase.

I personally find that odd: \r is not much different from any other unprintable ascii character, like \0. I think it makes sense (in a separate issue) to downgrade error on \r to a warning on any non-printable character.

Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019

Rollup merge of rust-lang#63525 - matklad:centraliza-file-loading, r=…
…petrochenkov

Make sure that all file loading happens via SourceMap

That way, callers don't need to repeat "let's add this to sm manually
for tracking dependencies" trick.

It should make it easier to switch to using `FileLoader` for binary
files in the future as well

cc rust-lang#62948

r? @petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Aug 16, 2019

Rollup merge of rust-lang#63525 - matklad:centraliza-file-loading, r=…
…petrochenkov

Make sure that all file loading happens via SourceMap

That way, callers don't need to repeat "let's add this to sm manually
for tracking dependencies" trick.

It should make it easier to switch to using `FileLoader` for binary
files in the future as well

cc rust-lang#62948

r? @petrochenkov
@matklad

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review

@petrochenkov what do you think about this new strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.