Implement Div and DivAssign for PathBuf #62989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dtolnay
reviewed
Jul 25, 2019
sfackler
added
the
T-libs-api
This comment has been minimized.
This comment has been minimized.
|
@rfcbot fcp close I am not a fan of these. :( Does someone else from @rust-lang/libs want to make a case that we should have division operator on paths? let home = PathBuf::from("/home");
let user = Path::new("user");
assert_eq!(Path::new("/home/user/documents"), home / user / "documents"); |
|
Team member @dtolnay has proposed to close this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
FWIW, in trybuild I use a macro for this. let p = path!(project.dir / ".cargo" / "config");I think that's more acceptable to me because the macro call puts it in the realm of domain-specific language rather than division. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Note that |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I'll go ahead and close this. Thanks anyway, @1011X! I would still be interested in seeing something like path!(...) on crates.io. |
rfcbot
removed
proposed-final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the
/and/=operators for concatenating paths to aPathBuf, similar to how+and+=currently concatenate strings forString.This would make it easier to build longer path values inline while improving readability. These operators have precedence in Python 3 and C++17, and in this implementation they can take either a
Path,str, orOsStr.Examples:
I chose to submit a PR since that was the easier thing to do here, but if an RFC is preferred beforehand, I can do that too.