Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ICE when suggestion span is at Eof #62995

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@estebank
Copy link
Contributor

commented Jul 25, 2019

Fix #62973.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank estebank force-pushed the estebank:issue-62973 branch from 59e4353 to eeb1bd1 Jul 25, 2019

@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Fun:

tidy error: /checkout/src/test/ui/parser/issue-62973.rs: too many trailing newlines (3)
tidy error: /checkout/src/test/ui/parser/issue-62973.rs: ignoring trailing whitespace unnecessarily

@estebank estebank force-pushed the estebank:issue-62973 branch from 46b03e6 to 2bd2fde Jul 25, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 25, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-25T23:31:35.4576537Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-25T23:31:35.4756074Z ##[command]git config gc.auto 0
2019-07-25T23:31:35.4836588Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-25T23:31:35.4895874Z ##[command]git config --get-all http.proxy
2019-07-25T23:31:35.5047156Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-25T23:32:09.5056160Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-25T23:32:09.5056421Z 
2019-07-25T23:32:09.5056744Z   git checkout -b <new-branch-name>
2019-07-25T23:32:09.5056777Z 
2019-07-25T23:32:09.5056831Z HEAD is now at f842089b1 Merge 2bd2fde71989b5dd01df7a639ab232b78cd68c9d into 890881f8f4c77e8670d4b32104c0325fcfefc90f
2019-07-25T23:32:09.5200783Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-25T23:32:09.5203967Z ==============================================================================
2019-07-25T23:32:09.5204034Z Task         : Bash
2019-07-25T23:32:09.5204089Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-25T23:37:02.7452569Z    Compiling aho-corasick v0.7.3
2019-07-25T23:37:28.4679881Z    Compiling serde_derive v1.0.81
2019-07-25T23:38:02.7723448Z    Compiling serde_json v1.0.40
2019-07-25T23:38:07.0049281Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-25T23:38:07.1009791Z error: cannot find macro `supressible_tidy_error!` in this scope
2019-07-25T23:38:07.1017575Z    --> src/tools/tidy/src/style.rs:221:18
2019-07-25T23:38:07.1022261Z     |
2019-07-25T23:38:07.1027663Z 221 |             0 => supressible_tidy_error!(
2019-07-25T23:38:07.1034506Z     |                  ^^^^^^^^^^^^^^^^^^^^^^ help: you could try the macro: `suppressible_tidy_err`
2019-07-25T23:38:07.1043792Z 
2019-07-25T23:38:07.1050325Z error: cannot find macro `supressible_tidy_error!` in this scope
2019-07-25T23:38:07.1056793Z    --> src/tools/tidy/src/style.rs:228:18
2019-07-25T23:38:07.1061672Z     |
2019-07-25T23:38:07.1061961Z 228 |             n => supressible_tidy_error!(
2019-07-25T23:38:07.1062290Z     |                  ^^^^^^^^^^^^^^^^^^^^^^ help: you could try the macro: `suppressible_tidy_err`
2019-07-25T23:38:07.2472124Z error[E0308]: mismatched types
2019-07-25T23:38:07.2472554Z    --> src/tools/tidy/src/style.rs:220:18
2019-07-25T23:38:07.2472823Z     |
2019-07-25T23:38:07.2472823Z     |
2019-07-25T23:38:07.2473606Z 220 |             n if skip_trailing_newlines => {}
2019-07-25T23:38:07.2474008Z     |                  ^^^^^^^^^^^^^^^^^^^^^^ expected bool, found enum `style::Directive`
2019-07-25T23:38:07.2474578Z     = note: expected type `bool`
2019-07-25T23:38:07.2474838Z                found type `style::Directive`
2019-07-25T23:38:07.2474896Z 
2019-07-25T23:38:07.4487647Z error: aborting due to 3 previous errors
2019-07-25T23:38:07.4487647Z error: aborting due to 3 previous errors
2019-07-25T23:38:07.4487755Z 
2019-07-25T23:38:07.4488086Z For more information about this error, try `rustc --explain E0308`.
2019-07-25T23:38:07.4627993Z error: Could not compile `tidy`.
2019-07-25T23:38:07.4628331Z To learn more, run the command again with --verbose.
2019-07-25T23:38:07.4658867Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
2019-07-25T23:38:07.4659015Z expected success, got: exit code: 101
2019-07-25T23:38:07.4668109Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-25T23:38:07.4668109Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-25T23:38:07.4668758Z Build completed unsuccessfully in 0:01:21
2019-07-25T23:38:08.8017075Z ##[error]Bash exited with code '1'.
2019-07-25T23:38:08.8050009Z ##[section]Starting: Checkout
2019-07-25T23:38:08.8051732Z ==============================================================================
2019-07-25T23:38:08.8051782Z Task         : Get sources
2019-07-25T23:38:08.8051864Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:issue-62973 branch from 2bd2fde to 7ed4b41 Jul 26, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T00:32:07.3526432Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T00:32:07.3725339Z ##[command]git config gc.auto 0
2019-07-26T00:32:07.3804508Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T00:32:07.3862187Z ##[command]git config --get-all http.proxy
2019-07-26T00:32:07.4017027Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-26T00:32:42.7003979Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T00:32:42.7004031Z 
2019-07-26T00:32:42.7004302Z   git checkout -b <new-branch-name>
2019-07-26T00:32:42.7004336Z 
2019-07-26T00:32:42.7004405Z HEAD is now at 4e3c8977d Merge 7ed4b41d3b8597d54ad7cd1b4cdafebf935dda7b into 890881f8f4c77e8670d4b32104c0325fcfefc90f
2019-07-26T00:32:42.7136555Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T00:32:42.7139493Z ==============================================================================
2019-07-26T00:32:42.7139553Z Task         : Bash
2019-07-26T00:32:42.7139617Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T00:38:09.8992301Z    Compiling aho-corasick v0.7.3
2019-07-26T00:38:36.2313724Z    Compiling serde_derive v1.0.81
2019-07-26T00:39:12.6049620Z    Compiling serde_json v1.0.40
2019-07-26T00:39:17.2090522Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T00:39:17.3137987Z error: cannot find macro `supressible_tidy_err!` in this scope
2019-07-26T00:39:17.3149330Z    --> src/tools/tidy/src/style.rs:230:18
2019-07-26T00:39:17.3154030Z     |
2019-07-26T00:39:17.3158593Z 230 |             0 => supressible_tidy_err!(
2019-07-26T00:39:17.3164466Z     |                  ^^^^^^^^^^^^^^^^^^^^ help: you could try the macro: `suppressible_tidy_err`
2019-07-26T00:39:17.3164844Z 
2019-07-26T00:39:17.3172498Z error: cannot find macro `supressible_tidy_err!` in this scope
2019-07-26T00:39:17.3178588Z    --> src/tools/tidy/src/style.rs:237:18
2019-07-26T00:39:17.3183963Z     |
2019-07-26T00:39:17.3189258Z 237 |             n => supressible_tidy_err!(
2019-07-26T00:39:17.3194121Z     |                  ^^^^^^^^^^^^^^^^^^^^ help: you could try the macro: `suppressible_tidy_err`
2019-07-26T00:39:17.7106896Z error: aborting due to 2 previous errors
2019-07-26T00:39:17.7108171Z 
2019-07-26T00:39:17.7108171Z 
2019-07-26T00:39:17.7267684Z error: Could not compile `tidy`.
2019-07-26T00:39:17.7269243Z To learn more, run the command again with --verbose.
2019-07-26T00:39:17.7294801Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
2019-07-26T00:39:17.7294929Z expected success, got: exit code: 101
2019-07-26T00:39:17.7306650Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T00:39:17.7306650Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T00:39:17.7307021Z Build completed unsuccessfully in 0:01:25
2019-07-26T00:39:19.0713446Z ##[error]Bash exited with code '1'.
2019-07-26T00:39:19.0749094Z ##[section]Starting: Checkout
2019-07-26T00:39:19.0750870Z ==============================================================================
2019-07-26T00:39:19.0750932Z Task         : Get sources
2019-07-26T00:39:19.0750986Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:issue-62973 branch 2 times, most recently from 49754fc to b2aa095 Jul 26, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T01:31:47.2764908Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T01:31:47.2967425Z ##[command]git config gc.auto 0
2019-07-26T01:31:47.3054114Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T01:31:47.3124729Z ##[command]git config --get-all http.proxy
2019-07-26T01:31:47.3270783Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-26T01:32:21.2275493Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T01:32:21.2275544Z 
2019-07-26T01:32:21.2275813Z   git checkout -b <new-branch-name>
2019-07-26T01:32:21.2275844Z 
2019-07-26T01:32:21.2275897Z HEAD is now at f050926f6 Merge b2aa0956c58ef58b5ffc82d396b544fb7af8b310 into 890881f8f4c77e8670d4b32104c0325fcfefc90f
2019-07-26T01:32:21.2431515Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T01:32:21.2434216Z ==============================================================================
2019-07-26T01:32:21.2434292Z Task         : Bash
2019-07-26T01:32:21.2434339Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T01:37:48.8636114Z    Compiling aho-corasick v0.7.3
2019-07-26T01:38:15.7257385Z    Compiling serde_derive v1.0.81
2019-07-26T01:38:52.2717947Z    Compiling serde_json v1.0.40
2019-07-26T01:38:56.8094744Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T01:38:56.8857020Z error: no rules expected the token `,`
2019-07-26T01:38:56.8866406Z    --> src/tools/tidy/src/style.rs:233:73
2019-07-26T01:38:56.8869865Z     |
2019-07-26T01:38:56.8874067Z 132 | macro_rules! suppressible_tidy_err {
2019-07-26T01:38:56.8878415Z     | ---------------------------------- when calling this macro
2019-07-26T01:38:56.8878758Z ...
2019-07-26T01:38:56.8884771Z 233 |                 &format!("{}: missing trailing newline", file.display()),
2019-07-26T01:38:56.8889973Z     |                                                                         ^ no rules expected this token in macro call
2019-07-26T01:38:56.8892016Z 
2019-07-26T01:38:56.8897956Z error: no rules expected the token `,`
2019-07-26T01:38:56.8904134Z    --> src/tools/tidy/src/style.rs:239:83
2019-07-26T01:38:56.8909214Z     |
2019-07-26T01:38:56.8911482Z 132 | macro_rules! suppressible_tidy_err {
2019-07-26T01:38:56.8913137Z     | ---------------------------------- when calling this macro
2019-07-26T01:38:56.8914701Z ...
2019-07-26T01:38:56.8917034Z 239 |                 &format!("{}: too many trailing newlines ({})", file.display(), n),
2019-07-26T01:38:56.8917429Z     |                                                                                   ^ no rules expected this token in macro call
2019-07-26T01:38:57.3109202Z error: aborting due to 2 previous errors
2019-07-26T01:38:57.3110136Z 
2019-07-26T01:38:57.3110136Z 
2019-07-26T01:38:57.3272596Z error: Could not compile `tidy`.
2019-07-26T01:38:57.3274588Z To learn more, run the command again with --verbose.
2019-07-26T01:38:57.3305699Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
2019-07-26T01:38:57.3306149Z expected success, got: exit code: 101
2019-07-26T01:38:57.3316161Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T01:38:57.3316161Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T01:38:57.3316442Z Build completed unsuccessfully in 0:01:26
2019-07-26T01:38:58.6212717Z ##[error]Bash exited with code '1'.
2019-07-26T01:38:58.6248678Z ##[section]Starting: Checkout
2019-07-26T01:38:58.6250447Z ==============================================================================
2019-07-26T01:38:58.6250543Z Task         : Get sources
2019-07-26T01:38:58.6250597Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@dwrensha

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

For what it's worth, here is a way to trigger the bug with fewer trailing newlines: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4cce30e8d42e50ab4eb2a3efe1b2c5b0

@estebank estebank force-pushed the estebank:issue-62973 branch from b2aa095 to 10738d8 Jul 26, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T14:41:23.7849095Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T14:41:23.8051411Z ##[command]git config gc.auto 0
2019-07-26T14:41:23.8111544Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T14:41:23.8167807Z ##[command]git config --get-all http.proxy
2019-07-26T14:41:23.8312684Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-26T14:41:59.1780576Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T14:41:59.1780607Z 
2019-07-26T14:41:59.1780817Z   git checkout -b <new-branch-name>
2019-07-26T14:41:59.1780864Z 
2019-07-26T14:41:59.1780915Z HEAD is now at 90eeb0be4 Merge 10738d81a2e779a936ac6e91cdbc31cbb507c6ba into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T14:41:59.1924900Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T14:41:59.1927738Z ==============================================================================
2019-07-26T14:41:59.1928067Z Task         : Bash
2019-07-26T14:41:59.1928120Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T14:47:03.6702290Z    Compiling aho-corasick v0.7.3
2019-07-26T14:47:30.6362639Z    Compiling serde_derive v1.0.81
2019-07-26T14:48:07.6759845Z    Compiling serde_json v1.0.40
2019-07-26T14:48:12.1419845Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T14:48:12.4210872Z error[E0618]: expected function, found `&mut bool`
2019-07-26T14:48:12.4211242Z    --> src/tools/tidy/src/style.rs:135:13
2019-07-26T14:48:12.4211498Z     |
2019-07-26T14:48:12.4211814Z 132 | / macro_rules! suppressible_tidy_err {
2019-07-26T14:48:12.4212169Z 133 | |     ($err:ident, $skip:ident, $msg:expr) => {
2019-07-26T14:48:12.4212688Z 134 | |         if let Directive::Deny = $skip {
2019-07-26T14:48:12.4212982Z 135 | |             $err($msg);
2019-07-26T14:48:12.4213783Z     | |             ^^^^     - call expression requires function
2019-07-26T14:48:12.4214563Z 139 | |     };
2019-07-26T14:48:12.4214845Z 140 | | }
2019-07-26T14:48:12.4214845Z 140 | | }
2019-07-26T14:48:12.4215168Z     | |_- in this expansion of `suppressible_tidy_err!`
2019-07-26T14:48:12.4215435Z 141 | 
2019-07-26T14:48:12.4215725Z 142 |   pub fn check(path: &Path, bad: &mut bool) {
2019-07-26T14:48:12.4216603Z     |                             --- `&mut bool` defined here
2019-07-26T14:48:12.4216898Z ...
2019-07-26T14:48:12.4217193Z 230 |               0 => suppressible_tidy_err!(
2019-07-26T14:48:12.4217783Z 231 | |                 bad,
2019-07-26T14:48:12.4218313Z 232 | |                 skip_trailing_newlines,
2019-07-26T14:48:12.4218313Z 232 | |                 skip_trailing_newlines,
2019-07-26T14:48:12.4218688Z 233 | |                 &format!("{}: missing trailing newline", file.display())
2019-07-26T14:48:12.4219309Z     | |_____________- in this macro invocation
2019-07-26T14:48:12.4219369Z 
2019-07-26T14:48:12.4219369Z 
2019-07-26T14:48:12.4219629Z error[E0618]: expected function, found `&mut bool`
2019-07-26T14:48:12.4219888Z    --> src/tools/tidy/src/style.rs:135:13
2019-07-26T14:48:12.4220126Z     |
2019-07-26T14:48:12.4220445Z 132 | / macro_rules! suppressible_tidy_err {
2019-07-26T14:48:12.4220769Z 133 | |     ($err:ident, $skip:ident, $msg:expr) => {
2019-07-26T14:48:12.4221112Z 134 | |         if let Directive::Deny = $skip {
2019-07-26T14:48:12.4221424Z 135 | |             $err($msg);
2019-07-26T14:48:12.4221987Z     | |             ^^^^     - call expression requires function
2019-07-26T14:48:12.4222713Z 139 | |     };
2019-07-26T14:48:12.4223034Z 140 | | }
2019-07-26T14:48:12.4223034Z 140 | | }
2019-07-26T14:48:12.4223356Z     | |_- in this expansion of `suppressible_tidy_err!`
2019-07-26T14:48:12.4223620Z 141 | 
2019-07-26T14:48:12.4224016Z 142 |   pub fn check(path: &Path, bad: &mut bool) {
2019-07-26T14:48:12.4224390Z     |                             --- `&mut bool` defined here
2019-07-26T14:48:12.4224626Z ...
2019-07-26T14:48:12.4224914Z 236 |               n => suppressible_tidy_err!(
2019-07-26T14:48:12.4225513Z 237 | |                 bad,
2019-07-26T14:48:12.4225832Z 238 | |                 skip_trailing_newlines,
2019-07-26T14:48:12.4225832Z 238 | |                 skip_trailing_newlines,
2019-07-26T14:48:12.4226406Z 239 | |                 &format!("{}: too many trailing newlines ({})", file.display(), n)
2019-07-26T14:48:12.4227081Z     | |_____________- in this macro invocation
2019-07-26T14:48:12.4227148Z 
2019-07-26T14:48:12.6392429Z error: aborting due to 2 previous errors
2019-07-26T14:48:12.6392746Z 
2019-07-26T14:48:12.6392746Z 
2019-07-26T14:48:12.6393330Z For more information about this error, try `rustc --explain E0618`.
2019-07-26T14:48:12.6532960Z error: Could not compile `tidy`.
2019-07-26T14:48:12.6533343Z To learn more, run the command again with --verbose.
2019-07-26T14:48:12.6601125Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
2019-07-26T14:48:12.6601259Z expected success, got: exit code: 101
2019-07-26T14:48:12.6607790Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T14:48:12.6607790Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T14:48:12.6607895Z Build completed unsuccessfully in 0:01:26
2019-07-26T14:48:13.9464299Z ##[error]Bash exited with code '1'.
2019-07-26T14:48:13.9548862Z ##[section]Starting: Checkout
2019-07-26T14:48:13.9550747Z ==============================================================================
2019-07-26T14:48:13.9550805Z Task         : Get sources
2019-07-26T14:48:13.9550852Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:issue-62973 branch from 10738d8 to b74a390 Jul 26, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T17:06:20.8768482Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T17:06:20.8961584Z ##[command]git config gc.auto 0
2019-07-26T17:06:20.9026563Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T17:06:20.9076581Z ##[command]git config --get-all http.proxy
2019-07-26T17:06:20.9230147Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-26T17:06:55.0899775Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T17:06:55.0899824Z 
2019-07-26T17:06:55.0900034Z   git checkout -b <new-branch-name>
2019-07-26T17:06:55.0900064Z 
2019-07-26T17:06:55.0900112Z HEAD is now at d6c93452a Merge b74a390e8225545a04548f0deb36041a37226379 into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T17:06:55.1029393Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T17:06:55.1032096Z ==============================================================================
2019-07-26T17:06:55.1032154Z Task         : Bash
2019-07-26T17:06:55.1032201Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T17:13:08.1392020Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T17:13:08.5416535Z error: unused variable: `n`
2019-07-26T17:13:08.5417795Z    --> src/tools/tidy/src/style.rs:232:13
2019-07-26T17:13:08.5418414Z     |
2019-07-26T17:13:08.5419101Z 232 |             n if skip_trailing_newlines.is_ignore() => {}
2019-07-26T17:13:08.5419860Z     |             ^ help: consider prefixing with an underscore: `_n`
2019-07-26T17:13:08.5421119Z     = note: `-D unused-variables` implied by `-D warnings`
2019-07-26T17:13:08.5421420Z 
2019-07-26T17:13:08.7872621Z error: aborting due to previous error
2019-07-26T17:13:08.7873370Z 
2019-07-26T17:13:08.7873370Z 
2019-07-26T17:13:08.8044740Z error: Could not compile `tidy`.
2019-07-26T17:13:08.8045219Z To learn more, run the command again with --verbose.
2019-07-26T17:13:08.8098455Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
2019-07-26T17:13:08.8101447Z expected success, got: exit code: 101
2019-07-26T17:13:08.8107177Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T17:13:08.8107177Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T17:13:08.8107593Z Build completed unsuccessfully in 0:01:25
2019-07-26T17:13:10.0846519Z ##[error]Bash exited with code '1'.
2019-07-26T17:13:10.0876902Z ##[section]Starting: Checkout
2019-07-26T17:13:10.0878605Z ==============================================================================
2019-07-26T17:13:10.0878676Z Task         : Get sources
2019-07-26T17:13:10.0878725Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:issue-62973 branch from b74a390 to ae9f3d5 Jul 26, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T18:00:55.8877045Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T18:00:55.9066143Z ##[command]git config gc.auto 0
2019-07-26T18:00:55.9131181Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T18:00:55.9183606Z ##[command]git config --get-all http.proxy
2019-07-26T18:00:55.9301734Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-26T18:01:31.0071628Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T18:01:31.0071651Z 
2019-07-26T18:01:31.0071798Z   git checkout -b <new-branch-name>
2019-07-26T18:01:31.0071821Z 
2019-07-26T18:01:31.0071883Z HEAD is now at be6518834 Merge ae9f3d5f36a308fdc65ab5272271641bda37a6f2 into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T18:01:31.0194754Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T18:01:31.0196930Z ==============================================================================
2019-07-26T18:01:31.0197087Z Task         : Bash
2019-07-26T18:01:31.0197122Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T18:07:26.3026243Z    Compiling serde_json v1.0.40
2019-07-26T18:07:30.1521992Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T18:07:37.8908994Z     Finished release [optimized] target(s) in 1m 20s
2019-07-26T18:07:37.8970618Z tidy check
2019-07-26T18:07:38.2817428Z tidy error: /checkout/src/test/ui/parser/issue-62973.rs: ignoring trailing newlines unnecessarily
2019-07-26T18:07:39.5229324Z some tidy checks failed
2019-07-26T18:07:39.5229801Z 
2019-07-26T18:07:39.5229801Z 
2019-07-26T18:07:39.5230655Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-07-26T18:07:39.5231037Z 
2019-07-26T18:07:39.5231071Z 
2019-07-26T18:07:39.5237324Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T18:07:39.5237690Z Build completed unsuccessfully in 0:01:23
2019-07-26T18:07:39.5237690Z Build completed unsuccessfully in 0:01:23
2019-07-26T18:07:40.9192275Z ##[error]Bash exited with code '1'.
2019-07-26T18:07:40.9222147Z ##[section]Starting: Checkout
2019-07-26T18:07:40.9224578Z ==============================================================================
2019-07-26T18:07:40.9224638Z Task         : Get sources
2019-07-26T18:07:40.9224689Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:issue-62973 branch from ae9f3d5 to 3785232 Jul 26, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T18:30:02.0736499Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T18:30:02.0936844Z ##[command]git config gc.auto 0
2019-07-26T18:30:02.1019905Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T18:30:02.1070970Z ##[command]git config --get-all http.proxy
2019-07-26T18:30:02.8357734Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62995/merge:refs/remotes/pull/62995/merge
---
2019-07-26T18:30:38.8058945Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T18:30:38.8059184Z 
2019-07-26T18:30:38.8059632Z   git checkout -b <new-branch-name>
2019-07-26T18:30:38.8059868Z 
2019-07-26T18:30:38.8060098Z HEAD is now at e79eb804e Merge 3785232b3640a84b58ee5a1f0e2f57479d18684f into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T18:30:38.8196375Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T18:30:38.8199033Z ==============================================================================
2019-07-26T18:30:38.8199100Z Task         : Bash
2019-07-26T18:30:38.8199140Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T18:35:34.5340395Z    Compiling aho-corasick v0.7.3
2019-07-26T18:36:00.5809080Z    Compiling serde_derive v1.0.81
2019-07-26T18:36:36.0138944Z    Compiling serde_json v1.0.40
2019-07-26T18:36:40.4407535Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T18:36:41.2393994Z error: method is never used: `is_ignore`
2019-07-26T18:36:41.2394583Z    --> src/tools/tidy/src/style.rs:111:5
2019-07-26T18:36:41.2395165Z     |
2019-07-26T18:36:41.2395464Z 111 |     fn is_ignore(&self) -> bool {
2019-07-26T18:36:41.2395989Z     |
2019-07-26T18:36:41.2396277Z     = note: `-D dead-code` implied by `-D warnings`
2019-07-26T18:36:41.2396317Z 
2019-07-26T18:36:41.2534667Z error: aborting due to previous error
2019-07-26T18:36:41.2534667Z error: aborting due to previous error
2019-07-26T18:36:41.2534801Z 
2019-07-26T18:36:41.2706227Z error: Could not compile `tidy`.
2019-07-26T18:36:41.2706704Z To learn more, run the command again with --verbose.
2019-07-26T18:36:41.2733956Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
2019-07-26T18:36:41.2734089Z expected success, got: exit code: 101
2019-07-26T18:36:41.2745187Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T18:36:41.2745187Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T18:36:41.2745430Z Build completed unsuccessfully in 0:01:24
2019-07-26T18:36:42.5864752Z ##[error]Bash exited with code '1'.
2019-07-26T18:36:42.5902551Z ##[section]Starting: Checkout
2019-07-26T18:36:42.5904229Z ==============================================================================
2019-07-26T18:36:42.5904282Z Task         : Get sources
2019-07-26T18:36:42.5904351Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:issue-62973 branch from 3785232 to 6263eb4 Jul 26, 2019

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

📌 Commit 6263eb4 has been approved by varkor

Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019

Rollup merge of rust-lang#62995 - estebank:issue-62973, r=varkor
Avoid ICE when suggestion span is at Eof

Fix rust-lang#62973.

bors added a commit that referenced this pull request Jul 28, 2019

Auto merge of #63090 - Centril:rollup-xnjwm2h, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #61856 (Lint attributes on function arguments)
 - #62360 (Document that ManuallyDrop::drop should not called more than once)
 - #62392 (Update minifier-rs version)
 - #62871 (Explicit error message for async recursion.)
 - #62995 (Avoid ICE when suggestion span is at Eof)
 - #63053 (SystemTime docs: recommend Instant for elapsed time)
 - #63081 (tidy: Cleanup the directory whitelist)
 - #63088 (Remove anonymous_parameters from unrelated test)

Failed merges:

r? @ghost

@bors bors merged commit 6263eb4 into rust-lang:master Jul 29, 2019

4 checks passed

pr Build #20190726.74 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.