Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition future compat lints to {ERROR, DENY} #63247

Open
wants to merge 12 commits into
base: master
from

Conversation

@Centril
Copy link
Member

commented Aug 3, 2019

Closes #40107 (ERROR).
Closes #39207 (ERROR).
Closes #37872 (ERROR).
Closes #36887 (ERROR).
Closes #36247 (ERROR).
Closes #42238 (ERROR).
Closes #60210 (ERROR).

Transitions #59014 (DENY).
Transitions #57571 (DENY).
Transitions #35203 (DENY).

r? @petrochenkov

@Centril

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

⌛️ Trying commit f213acf with merge 757daca...

bors added a commit that referenced this pull request Aug 3, 2019

Auto merge of #63247 - Centril:compat-to-error, r=<try>
Transition some C-future-compatibility lints to {ERROR, DENY}

Closes #40107 (ERROR).
Closes #39207 (ERROR).
Closes #37872 (ERROR).
Closes #36887 (ERROR).
Closes #36247 (ERROR.
Closes #42238 (ERROR).
Transitions #59014 (DENY).
Transitions #57571 (DENY).
Closes #60210 (ERROR).
Transitions #35203 (DENY).

r? @petrochenkov

@Centril Centril changed the title Transition some C-future-compatibility lints to {ERROR, DENY} Transition future compat lints to {ERROR, DENY} Aug 3, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-03T20:39:43.6393337Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-03T20:39:43.6627552Z ##[command]git config gc.auto 0
2019-08-03T20:39:43.6710831Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-03T20:39:43.6757431Z ##[command]git config --get-all http.proxy
2019-08-03T20:39:43.6925148Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63247/merge:refs/remotes/pull/63247/merge
---
2019-08-03T20:40:17.7049151Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-03T20:40:17.7049182Z 
2019-08-03T20:40:17.7049385Z   git checkout -b <new-branch-name>
2019-08-03T20:40:17.7049413Z 
2019-08-03T20:40:17.7049473Z HEAD is now at b679ef198 Merge f213acf659a8178260989e0f10b623470ba704c3 into 452087b4bf18cece2d52d7cd8c9147195e5404bf
2019-08-03T20:40:17.7207656Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-03T20:40:17.7210329Z ==============================================================================
2019-08-03T20:40:17.7210405Z Task         : Bash
2019-08-03T20:40:17.7210453Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-03T21:43:39.2925045Z .................................................................................................... 1400/8825
2019-08-03T21:43:45.4051310Z .................................................................................................... 1500/8825
2019-08-03T21:43:58.5322360Z ..................................................................i...............i................. 1600/8825
2019-08-03T21:44:06.3684204Z .................................................................................................... 1700/8825
2019-08-03T21:44:21.8542901Z ....................................................iiiii........................................... 1800/8825
2019-08-03T21:44:33.5006777Z .................................................................................................... 2000/8825
2019-08-03T21:44:36.0274176Z .................................................................................................... 2100/8825
2019-08-03T21:44:39.4141925Z .................................................................................................... 2200/8825
2019-08-03T21:44:49.1865141Z .................................................................................................... 2300/8825
---
2019-08-03T21:48:47.0930136Z .................................................................................................... 5200/8825
2019-08-03T21:48:55.5817133Z ..................................................................i................................. 5300/8825
2019-08-03T21:49:03.0037840Z .................................................................................................... 5400/8825
2019-08-03T21:49:10.2408306Z .................................................................................................... 5500/8825
2019-08-03T21:49:21.8912149Z ............................................................ii...i..ii...........i.................. 5600/8825
2019-08-03T21:49:46.3101858Z .................................................................................................... 5800/8825
2019-08-03T21:49:51.4730083Z .................................................................................................... 5900/8825
2019-08-03T21:49:51.4730083Z .................................................................................................... 5900/8825
2019-08-03T21:49:58.5635332Z ............................................................i..ii................................... 6000/8825
2019-08-03T21:50:27.6299247Z .................................................................................................... 6200/8825
2019-08-03T21:50:29.8647620Z ...i................................................................................................ 6300/8825
2019-08-03T21:50:32.1210260Z ...........................................................................i........................ 6400/8825
2019-08-03T21:50:34.8567162Z .................................................................................................... 6500/8825
---
2019-08-03T21:55:28.3507362Z  finished in 21.291
2019-08-03T21:55:28.3684851Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T21:55:28.5333870Z 
2019-08-03T21:55:28.5334012Z running 146 tests
2019-08-03T21:55:31.8580274Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-03T21:55:33.7826029Z iii..............i.........iii.i......ii......
2019-08-03T21:55:33.7826555Z 
2019-08-03T21:55:33.7829699Z  finished in 5.414
2019-08-03T21:55:33.8005778Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T21:55:33.9674604Z 
---
2019-08-03T21:55:36.0909087Z  finished in 2.290
2019-08-03T21:55:36.1105641Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T21:55:36.2858579Z 
2019-08-03T21:55:36.2861525Z running 9 tests
2019-08-03T21:55:36.2862545Z iiiiiiiii
2019-08-03T21:55:36.2863442Z 
2019-08-03T21:55:36.2863666Z  finished in 0.175
2019-08-03T21:55:36.3063629Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T21:55:36.4799950Z 
---
2019-08-03T21:55:55.3317489Z  finished in 19.025
2019-08-03T21:55:55.3513892Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T21:55:55.5230368Z 
2019-08-03T21:55:55.5230757Z running 122 tests
2019-08-03T21:56:20.1133927Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-03T21:56:24.9798837Z .i.i......iii.i.....ii
2019-08-03T21:56:24.9800300Z 
2019-08-03T21:56:24.9800669Z  finished in 29.628
2019-08-03T21:56:24.9809484Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T21:56:24.9810113Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-03T22:11:16.5054225Z 
2019-08-03T22:11:16.5072781Z    Doc-tests core
2019-08-03T22:11:20.8640561Z 
2019-08-03T22:11:20.8640906Z running 2379 tests
2019-08-03T22:11:33.4919335Z ......iiiii......................................................................................... 100/2379
2019-08-03T22:11:46.3212755Z .........................................................................ii......................... 200/2379
2019-08-03T22:12:16.7091707Z .................................................................................................... 400/2379
2019-08-03T22:12:16.7091707Z .................................................................................................... 400/2379
2019-08-03T22:12:28.2086742Z ..............................i..i.................iiii............................................. 500/2379
2019-08-03T22:12:51.8023264Z .................................................................................................... 700/2379
2019-08-03T22:13:03.9920465Z .................................................................................................... 800/2379
2019-08-03T22:13:16.2235200Z .................................................................................................... 900/2379
2019-08-03T22:13:28.3045326Z .................................................................................................... 1000/2379
---
2019-08-03T22:18:37.3152246Z ............................................... 300/756
2019-08-03T22:18:37.3159447Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-08-03T22:18:37.3952959Z .................................................................................................... 400/756
2019-08-03T22:18:39.4643839Z .................................................................................................... 500/756
2019-08-03T22:18:39.4882977Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', .src/libcore/result.rs:1084:5
2019-08-03T22:18:39.4895317Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-08-03T22:18:39.4921272Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-03T22:18:39.7132878Z ........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-03T22:18:39.7154155Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-03T22:18:39.7269782Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
---
2019-08-03T22:18:51.2334028Z 
2019-08-03T22:18:51.2334277Z running 989 tests
2019-08-03T22:19:16.0711976Z i................................................................................................... 100/989
2019-08-03T22:19:29.5965297Z .................................................................................................... 200/989
2019-08-03T22:19:38.6667201Z .................iii......i......i...i......i....................................................... 300/989
2019-08-03T22:19:43.7747974Z .................................................................................................... 400/989
2019-08-03T22:19:52.2419161Z ................................i..i.................................ii............................. 500/989
2019-08-03T22:20:07.7446440Z .................................................................................................... 700/989
2019-08-03T22:20:07.7446440Z .................................................................................................... 700/989
2019-08-03T22:20:16.5178899Z ...............iiii................................................................................. 800/989
2019-08-03T22:20:31.5556679Z .................................................................................................... 900/989
2019-08-03T22:20:39.5199205Z .....................................iiii................................................
2019-08-03T22:20:39.5203487Z 
2019-08-03T22:20:39.5412886Z  finished in 251.331
2019-08-03T22:20:39.5430292Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T22:20:39.7469268Z     Finished release [optimized] target(s) in 0.20s
---
2019-08-03T22:41:38.3550228Z  finished in 34.516
2019-08-03T22:41:38.3887656Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-03T22:41:38.5619660Z 
2019-08-03T22:41:38.5621512Z running 199 tests
2019-08-03T22:42:13.4809025Z ....................i...ii................................................................i......... 100/199
2019-08-03T22:42:59.3522257Z ..............................iiii.......i..........iiii.iii....................................i..
2019-08-03T22:42:59.3523755Z 
2019-08-03T22:42:59.3530669Z  finished in 80.964
2019-08-03T22:42:59.3543662Z doc tests for: /checkout/src/doc/rustdoc/src/command-line-arguments.md
2019-08-03T22:42:59.3629470Z doc tests for: /checkout/src/doc/rustdoc/src/documentation-tests.md
---
2019-08-03T22:43:11.1247855Z doc tests for: /checkout/src/doc/rustc/src/lints/listing/deny-by-default.md
2019-08-03T22:43:11.1770825Z doc tests for: /checkout/src/doc/rustc/src/lints/listing/warn-by-default.md
2019-08-03T22:43:13.9560018Z 
2019-08-03T22:43:13.9560228Z 
2019-08-03T22:43:13.9562090Z command did not execute successfully: "/checkout/obj/build/bootstrap/debug/rustdoc" "--test" "/checkout/src/doc/rustc/src/lints/listing/warn-by-default.md" "--test-args" ""
2019-08-03T22:43:13.9562674Z 
2019-08-03T22:43:13.9563260Z stdout ----
2019-08-03T22:43:13.9563418Z 
2019-08-03T22:43:13.9563600Z running 41 tests
---
2019-08-03T22:43:13.9584940Z test /checkout/src/doc/rustc/src/lints/listing/warn-by-default.md - Warn_by_default_lints::while_true (line 964) ... ok
2019-08-03T22:43:13.9584982Z 
2019-08-03T22:43:13.9585046Z failures:
2019-08-03T22:43:13.9585075Z 
2019-08-03T22:43:13.9585389Z ---- /checkout/src/doc/rustc/src/lints/listing/warn-by-default.md - Warn_by_default_lints::patterns_in_fns_without_body (line 315) stdout ----
2019-08-03T22:43:13.9585678Z error: patterns aren't allowed in methods without bodies
2019-08-03T22:43:13.9585938Z  --> /checkout/src/doc/rustc/src/lints/listing/warn-by-default.md:317:12
2019-08-03T22:43:13.9585987Z   |
2019-08-03T22:43:13.9586032Z 4 |     fn foo(mut arg: u8);
2019-08-03T22:43:13.9586140Z   |
2019-08-03T22:43:13.9586140Z   |
2019-08-03T22:43:13.9586291Z   = note: `#[deny(patterns_in_fns_without_body)]` on by default
2019-08-03T22:43:13.9586382Z   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
2019-08-03T22:43:13.9586833Z   = note: for more information, see issue #35203 <***/issues/35203>
2019-08-03T22:43:13.9586937Z error: aborting due to previous error
2019-08-03T22:43:13.9586967Z 
2019-08-03T22:43:13.9587186Z Couldn't compile the test.
2019-08-03T22:43:13.9587220Z 
---
2019-08-03T22:43:13.9588292Z 
2019-08-03T22:43:13.9588327Z 
2019-08-03T22:43:13.9588374Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-03T22:43:13.9588422Z Build completed unsuccessfully in 1:56:50
2019-08-03T22:43:14.8176453Z ##[error]Bash exited with code '1'.
2019-08-03T22:43:14.8257193Z ##[section]Starting: Checkout
2019-08-03T22:43:14.8258862Z ==============================================================================
2019-08-03T22:43:14.8258940Z Task         : Get sources
2019-08-03T22:43:14.8259005Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

☀️ Try build successful - checks-azure
Build commit: 757daca

@Centril

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

@craterbot run mode=check-only

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

👌 Experiment pr-63247 created and queued.
🤖 Automatically detected try build 757daca
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

🚧 Experiment pr-63247 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

1 similar comment
@craterbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

🚧 Experiment pr-63247 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Paused this run to yield priority to other, more important ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.