Better error message for certain classes of unresolved imports #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume you'll want me to squash these whitespace commits into the first? |
|
Would you mind changing |
|
Done |
|
Nice, thanks. |
|
(haven't actually run that test yet, not at home with a decent computer) |
|
tests pass, was that what you meant @catamorphism? |
|
Whoops, added license. |
|
@cmr - Thanks! |
bors
added a commit
that referenced
this pull request
May 10, 2013
…rphism
This improves error reporting for the following class of imports:
```rust
use foo::bar;
```
Where foo, the topmost module, is unresolved. It now results in:
```text
/tmp/foo.rs:1:4: 1:7 error: unresolved import. perhapsyou forgot an 'extern mod foo'?
/tmp/foo.rs:1 use foo::bar;
^~~
/tmp/foo.rs:1:4: 1:12 error: failed to resolve import: foo::bar
/tmp/foo.rs:1 use foo::bar;
^~~~~~~~
error: failed to resolve imports
error: aborting due to 3 previous errors
```
This is the first of a series of changes I plan on making to unresolved name error messages.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
Changelog Rust 1.48 [Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md) This changelog is **big**. Hacktoberfest was pretty good for us, even though we had too few reviewers. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves error reporting for the following class of imports:
Where foo, the topmost module, is unresolved. It now results in:
This is the first of a series of changes I plan on making to unresolved name error messages.