Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of `mem::uninitialized()` from cloudabi #63546

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@lzutao
Copy link
Contributor

commented Aug 14, 2019

This PR removes uses of mem::uninitialized from cloudabi module,
excluding the layout test in src/libstd/sys/cloudabi/abi/cloudabi.rs.

r? @RalfJung
cc @EdSchouten
cc #62397

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

This looks good other than the nits, but I know nothing about CloudABI. @alexcrichton can I just r+ this when it looks reasonable, or what do we do with exotic platforms?

@xen0n

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Before it's too late, let's fix the typo in the commit message and PR title, should one day people grep the revision log for archaeology...

@lzutao lzutao force-pushed the lzutao:clouldabi-maybeuninit branch from 1883b89 to d5bedf5 Aug 14, 2019

@lzutao lzutao changed the title Remove uses of `mem::uninitialized()` from clouldabi Remove uses of `mem::uninitialized()` from cloudabi Aug 14, 2019

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Yes this is fine to r+ when ready, the maintainer (@EdSchouten) has been cc'd so we can wait a bit for them to take a look but otherwise we don't strictly review these platforms.

@RalfJung
Copy link
Member

left a comment

r=me any time (but I think there will be conflicts when #63534 lands)

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

☔️ The latest upstream changes (presumably #63534) made this pull request unmergeable. Please resolve the merge conflicts.

@lzutao lzutao force-pushed the lzutao:clouldabi-maybeuninit branch from d5bedf5 to b49c0db Aug 15, 2019

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@lzutao force-pushes don't trigger notifications, so please let the reviewer know when you did them so that they can take another look.

@lzutao lzutao force-pushed the lzutao:clouldabi-maybeuninit branch from b49c0db to 6e8639a Aug 15, 2019

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

📌 Commit 6e8639a has been approved by RalfJung

Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019

Rollup merge of rust-lang#63546 - lzutao:clouldabi-maybeuninit, r=Ral…
…fJung

Remove uses of `mem::uninitialized()` from cloudabi

This PR removes uses of `mem::uninitialized` from `cloudabi` module,
excluding the layout test in `src/libstd/sys/cloudabi/abi/cloudabi.rs`.

r? @RalfJung
cc @EdSchouten
cc rust-lang#62397

bors added a commit that referenced this pull request Aug 15, 2019

Auto merge of #63588 - Centril:rollup-9ad6qs2, r=Centril
Rollup of 12 pull requests

Successful merges:

 - #63155 (Add UWP MSVC targets)
 - #63165 (Add builtin targets for mips64(el)-unknown-linux-muslabi64)
 - #63467 (Add Catalyst (iOS apps running on macOS) target)
 - #63470 (Utilize -Zbinary-dep-depinfo in rustbuild)
 - #63495 ( Remove redundant `ty` fields from `mir::Constant` and `hair::pattern::PatternRange`.)
 - #63525 (Make sure that all file loading happens via SourceMap)
 - #63546 (Remove uses of `mem::uninitialized()` from cloudabi)
 - #63559 (rustc_codegen_utils: account for 1-indexed anonymous lifetimes in v0 mangling.)
 - #63572 (remove unused Level::PhaseFatal)
 - #63577 (Test HRTB issue accepted by compiler)
 - #63582 (Fix ICE #63226)
 - #63586 (cleanup: Remove `Spanned` where possible)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019

Rollup merge of rust-lang#63546 - lzutao:clouldabi-maybeuninit, r=Ral…
…fJung

Remove uses of `mem::uninitialized()` from cloudabi

This PR removes uses of `mem::uninitialized` from `cloudabi` module,
excluding the layout test in `src/libstd/sys/cloudabi/abi/cloudabi.rs`.

r? @RalfJung
cc @EdSchouten
cc rust-lang#62397

bors added a commit that referenced this pull request Aug 15, 2019

Auto merge of #63592 - Centril:rollup-7c6dg3e, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #63155 (Add UWP MSVC targets)
 - #63165 (Add builtin targets for mips64(el)-unknown-linux-muslabi64)
 - #63306 (Adapt AddRetag for shallow retagging)
 - #63467 (Add Catalyst (iOS apps running on macOS) target)
 - #63546 (Remove uses of `mem::uninitialized()` from cloudabi)
 - #63572 (remove unused Level::PhaseFatal)
 - #63577 (Test HRTB issue accepted by compiler)
 - #63582 (Fix ICE #63226)
 - #63586 (cleanup: Remove `Spanned` where possible)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

☔️ The latest upstream changes (presumably #63592) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 6e8639a into rust-lang:master Aug 15, 2019

4 checks passed

pr Build #20190815.16 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@lzutao lzutao deleted the lzutao:clouldabi-maybeuninit branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.