Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When declaring a declarative macro in an item it's only accessible inside it #63624

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@estebank
Copy link
Contributor

commented Aug 16, 2019

Fix #63164.
r? @petrochenkov

@estebank estebank force-pushed the estebank:unreachable-macro branch from 6421b45 to 4971667 Aug 21, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

📌 Commit 4971667 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Aug 22, 2019
Rollup merge of rust-lang#63624 - estebank:unreachable-macro, r=petro…
…chenkov

When declaring a declarative macro in an item it's only accessible inside it

Fix rust-lang#63164.
r? @petrochenkov
bors added a commit that referenced this pull request Aug 22, 2019
Auto merge of #63807 - Centril:rollup-b8lo8ct, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #63624 (When declaring a declarative macro in an item it's only accessible inside it)
 - #63737 (Fix naming misspelling)
 - #63767 (Use more optimal Ord implementation for integers)
 - #63782 (Fix confusion in theme picker functions)
 - #63788 (Add amanjeev to rustc-guide toolstate)
 - #63796 (Tweak E0308 on opaque types)
 - #63805 (Apply few Clippy suggestions)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Aug 22, 2019
Auto merge of #63807 - Centril:rollup-b8lo8ct, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #63624 (When declaring a declarative macro in an item it's only accessible inside it)
 - #63737 (Fix naming misspelling)
 - #63767 (Use more optimal Ord implementation for integers)
 - #63782 (Fix confusion in theme picker functions)
 - #63788 (Add amanjeev to rustc-guide toolstate)
 - #63796 (Tweak E0308 on opaque types)
 - #63805 (Apply few Clippy suggestions)

Failed merges:

r? @ghost

@bors bors merged commit 4971667 into rust-lang:master Aug 22, 2019

4 checks passed

pr Build #20190821.61 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.