Rollup of 8 pull requests #63995

Centril · 2019-08-29T08:53:42Z

Successful merges:

Allow checking of run-pass execution output in compiletest #63825 (Allow checking of run-pass execution output in compiletest)
Validation: check raw wide pointer metadata #63880 (Validation: check raw wide pointer metadata)
ty: use Align for ReprOptions pack and align. #63914 (ty: use Align for ReprOptions pack and align.)
rustbuild: allow disabling deny(warnings) for bootstrap #63941 (rustbuild: allow disabling deny(warnings) for bootstrap)
Fix build src/libtest #63949 (Fix build src/libtest)
Update rust-installer to limit memory use #63984 (Update rust-installer to limit memory use)
improper_ctypes: guard against accidental change to Unique<T> #63991 (improper_ctypes: guard against accidental change to Unique<T>)
Small improvement for Ord implementation of integers #63992 (Small improvement for Ord implementation of integers)

Failed merges:

Moved into ```fn load_compare_outputs(&self, proc_res: &ProcRes, explicit_format: bool) -> usize```

also fat -> wide

When deny-warnings is not specified or set to true, the behaviour is the same as before. When deny-warnings is set to false, warnings are now allowed Fixes rust-lang#63911 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>

Updates the dbg-macro-expected behavior test to remove the workaround and use the `check-run-result` flag/feature in compiletest. This serves to test the feature on a real use-case (as mentioned in rust-lang#63751)

Co-Authored-By: Robin Kruppe <robin.kruppe@gmail.com>

…k-Simulacrum Allow checking of run-pass execution output in compiletest Closes rust-lang#63751 Adds a `check-run-results` flag to compiletest headers, which if enabled checks the output of the execution of a run-pass test's binary against expected output.

@oli-obk

Validation: check raw wide pointer metadata While I was at it, I also added a missing check for slices not to be too big. r? @oli-obk Fixes rust-lang/miri#918

ty: use Align for ReprOptions pack and align.

rustbuild: allow disabling deny(warnings) for bootstrap When deny-warnings is not specified or set to true, the behaviour is the same as before. When deny-warnings is set to false, warnings are now allowed Fixes rust-lang#63911

@Mark-Simulacrum

…imulacrum Fix build src/libtest Fixes rust-lang#63928 r? @Mark-Simulacrum

@alexcrichton

…Simulacrum Update rust-installer to limit memory use See rust-lang/rust-installer#98 -- on a many-core machine, the xz memory for so many threads is more than a 32-bit process can handle. The xz stream is now limited to 8 threads. r? @alexcrichton

@eddyb

…ruppe `improper_ctypes`: guard against accidental change to `Unique<T>` r? @eddyb

@nagisa

Small improvement for Ord implementation of integers Godbolt link: https://godbolt.org/z/tuTDOg ### Before **asm** ```asm example::cmp: mov eax, dword ptr [rdi] xor ecx, ecx cmp eax, dword ptr [rsi] seta cl mov eax, 255 cmovae eax, ecx ret ``` **llvm-mca** ``` Iterations: 100 Instructions: 700 Total Cycles: 217 Total uOps: 1100 Dispatch Width: 6 uOps Per Cycle: 5.07 IPC: 3.23 Block RThroughput: 1.8 ``` ### After **asm** ```asm example::cmp: mov eax, dword ptr [rdi] xor ecx, ecx cmp eax, dword ptr [rsi] setne cl mov eax, 255 cmovae eax, ecx ret ``` **llvm-mca** ``` Iterations: 100 Instructions: 700 Total Cycles: 209 Total uOps: 1000 Dispatch Width: 6 uOps Per Cycle: 4.78 IPC: 3.35 Block RThroughput: 1.7 ``` r? @nagisa

Centril · 2019-08-29T08:53:58Z

@bors r+ p=8 rollup=never

bors · 2019-08-29T08:53:59Z

📌 Commit c985765 has been approved by Centril

bors · 2019-08-29T08:54:31Z

⌛ Testing commit c985765 with merge e81ce79527291ca009aa65dac6f0802302869138...

Centril · 2019-08-29T09:36:37Z

@bors r- retry

rust-highfive · 2019-08-29T11:29:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-29T08:54:16.8610635Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-29T08:54:16.8810332Z ##[command]git config gc.auto 0
2019-08-29T08:54:16.8882638Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-29T08:54:16.8976674Z ##[command]git config --get-all http.proxy
2019-08-29T08:54:16.9065360Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63995/merge:refs/remotes/pull/63995/merge
---
2019-08-29T09:52:33.8895069Z .................................................................................................... 1500/8973
2019-08-29T09:52:39.2820295Z .................................................................................................... 1600/8973
2019-08-29T09:52:51.2585168Z ................................................i...............i................................... 1700/8973
2019-08-29T09:52:58.9669635Z .................................................................................................... 1800/8973
2019-08-29T09:53:12.4071033Z .......................................iiiii........................................................ 1900/8973
2019-08-29T09:53:22.4350069Z .................................................................................................... 2100/8973
2019-08-29T09:53:24.8232518Z .................................................................................................... 2200/8973
2019-08-29T09:53:28.6436236Z .................................................................................................... 2300/8973
2019-08-29T09:53:35.6168048Z .................................................................................................... 2400/8973
---
2019-08-29T09:56:21.9915354Z ..........................i...............i......................................................... 4700/8973
2019-08-29T09:56:33.0070466Z .................................................................................................... 4800/8973
2019-08-29T09:56:38.7875138Z .................................................................................................... 4900/8973
2019-08-29T09:56:48.8862245Z .................................................................................................... 5000/8973
2019-08-29T09:56:54.3508816Z .......ii.ii........................................................................................ 5100/8973
2019-08-29T09:57:07.2251374Z .................................................................................................... 5300/8973
2019-08-29T09:57:15.1765482Z ......................................................................i............................. 5400/8973
2019-08-29T09:57:22.5133143Z .................................................................................................... 5500/8973
2019-08-29T09:57:29.4861419Z .................................................................................................... 5600/8973
2019-08-29T09:57:29.4861419Z .................................................................................................... 5600/8973
2019-08-29T09:57:39.9392887Z ................................................................ii...i..ii...........i.............. 5700/8973
2019-08-29T09:58:05.5084518Z .................................................................................................... 5900/8973
2019-08-29T09:58:14.6649347Z .................................................................................................... 6000/8973
2019-08-29T09:58:14.6649347Z .................................................................................................... 6000/8973
2019-08-29T09:58:23.4406917Z .................................................................i..ii.............................. 6100/8973
2019-08-29T09:58:52.3306197Z .................................................................................................... 6300/8973
2019-08-29T09:58:54.2905299Z ....................i............................................................................... 6400/8973
2019-08-29T09:58:56.2875403Z ............................................................................................i....... 6500/8973
2019-08-29T09:58:58.8183683Z .................................................................................................... 6600/8973
---
2019-08-29T10:02:52.0725134Z diff of stderr:
2019-08-29T10:02:52.0725297Z 
2019-08-29T10:02:52.0725474Z 43    | ^^^^^^^^^^^^^^^^^^
2019-08-29T10:02:52.0725641Z 44 
2019-08-29T10:02:52.0726092Z 45 error: `extern` block uses type `std::option::Option<std::ptr::Unique<u8>>` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0727519Z +   --> $DIR/lint-ctypes-enum.rs:48:17
2019-08-29T10:02:52.0727849Z 47    |
2019-08-29T10:02:52.0727849Z 47    |
2019-08-29T10:02:52.0728126Z 48 LL |    fn unique(x: Option<std::ptr::Unique<u8>>);
2019-08-29T10:02:52.0728898Z +    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-29T10:02:52.0729135Z 50    |
2019-08-29T10:02:52.0729135Z 50    |
2019-08-29T10:02:52.0729349Z 51    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0729761Z 
2019-08-29T10:02:52.0729939Z 
2019-08-29T10:02:52.0730141Z The actual stderr differed from the expected stderr.
2019-08-29T10:02:52.0730826Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-ctypes-enum/lint-ctypes-enum.stderr
2019-08-29T10:02:52.0730826Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-ctypes-enum/lint-ctypes-enum.stderr
2019-08-29T10:02:52.0731273Z To update references, rerun the tests and pass the `--bless` flag
2019-08-29T10:02:52.0731795Z To only update this specific test, also pass `--test-args lint/lint-ctypes-enum.rs`
2019-08-29T10:02:52.0732537Z error: 1 errors occurred comparing output.
2019-08-29T10:02:52.0732888Z status: exit code: 1
2019-08-29T10:02:52.0732888Z status: exit code: 1
2019-08-29T10:02:52.0733644Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-ctypes-enum.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-ctypes-enum" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-ctypes-enum/auxiliary" "-A" "unused"
2019-08-29T10:02:52.0734452Z ------------------------------------------
2019-08-29T10:02:52.0734651Z 
2019-08-29T10:02:52.0735061Z ------------------------------------------
2019-08-29T10:02:52.0735280Z stderr:
2019-08-29T10:02:52.0735280Z stderr:
2019-08-29T10:02:52.0735621Z ------------------------------------------
2019-08-29T10:02:52.0736308Z error: `extern` block uses type `U` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0736979Z    |
2019-08-29T10:02:52.0736979Z    |
2019-08-29T10:02:52.0737812Z LL |    fn uf(x: U); //~ ERROR enum has no representation hint
2019-08-29T10:02:52.0738264Z    |
2019-08-29T10:02:52.0738478Z note: lint level defined here
2019-08-29T10:02:52.0738962Z   --> /checkout/src/test/ui/lint/lint-ctypes-enum.rs:3:9
2019-08-29T10:02:52.0739254Z    |
2019-08-29T10:02:52.0739254Z    |
2019-08-29T10:02:52.0739471Z LL | #![deny(improper_ctypes)]
2019-08-29T10:02:52.0739673Z    |         ^^^^^^^^^^^^^^^
2019-08-29T10:02:52.0739913Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0741038Z   --> /checkout/src/test/ui/lint/lint-ctypes-enum.rs:9:1
2019-08-29T10:02:52.0741462Z    |
2019-08-29T10:02:52.0741462Z    |
2019-08-29T10:02:52.0741817Z LL | enum U { A }
2019-08-29T10:02:52.0742693Z 
2019-08-29T10:02:52.0742693Z 
2019-08-29T10:02:52.0743313Z error: `extern` block uses type `B` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0744030Z    |
2019-08-29T10:02:52.0744030Z    |
2019-08-29T10:02:52.0744335Z LL |    fn bf(x: B); //~ ERROR enum has no representation hint
2019-08-29T10:02:52.0745798Z    |
2019-08-29T10:02:52.0745798Z    |
2019-08-29T10:02:52.0746806Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0749089Z   --> /checkout/src/test/ui/lint/lint-ctypes-enum.rs:10:1
2019-08-29T10:02:52.0749856Z    |
2019-08-29T10:02:52.0749856Z    |
2019-08-29T10:02:52.0750295Z LL | enum B { C, D }
2019-08-29T10:02:52.0751626Z 
2019-08-29T10:02:52.0751626Z 
2019-08-29T10:02:52.0752053Z error: `extern` block uses type `T` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0754445Z    |
2019-08-29T10:02:52.0754445Z    |
2019-08-29T10:02:52.0754685Z LL |    fn tf(x: T); //~ ERROR enum has no representation hint
2019-08-29T10:02:52.0757960Z    |
2019-08-29T10:02:52.0757960Z    |
2019-08-29T10:02:52.0758462Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0761309Z   --> /checkout/src/test/ui/lint/lint-ctypes-enum.rs:11:1
2019-08-29T10:02:52.0761682Z    |
2019-08-29T10:02:52.0761682Z    |
2019-08-29T10:02:52.0761809Z LL | enum T { E, F, G }
2019-08-29T10:02:52.0762218Z 
2019-08-29T10:02:52.0762218Z 
2019-08-29T10:02:52.0763015Z error: `extern` block uses type `std::option::Option<std::ptr::Unique<u8>>` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0763760Z    |
2019-08-29T10:02:52.0763760Z    |
2019-08-29T10:02:52.0764103Z LL |    fn unique(x: Option<std::ptr::Unique<u8>>); //~ ERROR enum has no representation hint
2019-08-29T10:02:52.0764537Z    |
2019-08-29T10:02:52.0764537Z    |
2019-08-29T10:02:52.0764657Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0764783Z 
2019-08-29T10:02:52.0765157Z error: `extern` block uses type `u128` which is not FFI-safe: 128-bit integers don't currently have a known stable ABI
2019-08-29T10:02:52.0765684Z    |
2019-08-29T10:02:52.0765684Z    |
2019-08-29T10:02:52.0765969Z LL |    fn nonzero_u128(x: Option<num::NonZeroU128>);
2019-08-29T10:02:52.0766212Z 
2019-08-29T10:02:52.0766212Z 
2019-08-29T10:02:52.0766664Z error: `extern` block uses type `i128` which is not FFI-safe: 128-bit integers don't currently have a known stable ABI
2019-08-29T10:02:52.0768456Z    |
2019-08-29T10:02:52.0768456Z    |
2019-08-29T10:02:52.0768654Z LL |    fn nonzero_i128(x: Option<num::NonZeroI128>);
2019-08-29T10:02:52.0769034Z 
2019-08-29T10:02:52.0769034Z 
2019-08-29T10:02:52.0769555Z error: `extern` block uses type `std::option::Option<TransparentUnion<std::num::NonZeroU8>>` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0770273Z    |
2019-08-29T10:02:52.0770273Z    |
2019-08-29T10:02:52.0770474Z LL |    fn transparent_union(x: Option<TransparentUnion<num::NonZeroU8>>);
2019-08-29T10:02:52.0771424Z    |
2019-08-29T10:02:52.0771424Z    |
2019-08-29T10:02:52.0771608Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0778743Z 
2019-08-29T10:02:52.0779596Z error: `extern` block uses type `std::option::Option<Rust<std::num::NonZeroU8>>` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0780030Z    |
2019-08-29T10:02:52.0780030Z    |
2019-08-29T10:02:52.0780084Z LL |    fn repr_rust(x: Option<Rust<num::NonZeroU8>>); //~ ERROR enum has no representation hint
2019-08-29T10:02:52.0780200Z    |
2019-08-29T10:02:52.0780200Z    |
2019-08-29T10:02:52.0780255Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0780292Z 
2019-08-29T10:02:52.0780783Z error: `extern` block uses type `std::result::Result<(), std::num::NonZeroI32>` which is not FFI-safe: enum has no representation hint
2019-08-29T10:02:52.0781242Z    |
2019-08-29T10:02:52.0781242Z    |
2019-08-29T10:02:52.0781285Z LL |    fn no_result(x: Result<(), num::NonZeroI32>); //~ ERROR enum has no representation hint
2019-08-29T10:02:52.0781386Z    |
2019-08-29T10:02:52.0781386Z    |
2019-08-29T10:02:52.0781434Z    = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
2019-08-29T10:02:52.0781690Z error: aborting due to 9 previous errors
2019-08-29T10:02:52.0781715Z 
2019-08-29T10:02:52.0781737Z 
2019-08-29T10:02:52.0782108Z ------------------------------------------
---
2019-08-29T10:02:52.0783297Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-29T10:02:52.0783349Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-29T10:02:52.0783378Z 
2019-08-29T10:02:52.0783400Z 
2019-08-29T10:02:52.0784694Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-29T10:02:52.0785071Z 
2019-08-29T10:02:52.0785114Z 
2019-08-29T10:02:52.0787485Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-29T10:02:52.0788320Z Build completed unsuccessfully in 1:01:55
2019-08-29T10:02:52.0788320Z Build completed unsuccessfully in 1:01:55
2019-08-29T10:02:52.0846694Z == clock drift check ==
2019-08-29T10:02:52.0866382Z   local time: Thu Aug 29 10:02:52 UTC 2019
2019-08-29T10:02:52.2350670Z   network time: Thu, 29 Aug 2019 10:02:52 GMT
2019-08-29T10:02:52.2354938Z == end clock drift check ==
2019-08-29T10:02:53.0256633Z ##[error]Bash exited with code '1'.
2019-08-29T10:02:53.0294878Z ##[section]Starting: Checkout
2019-08-29T10:02:53.0297621Z ==============================================================================
2019-08-29T10:02:53.0297678Z Task         : Get sources
2019-08-29T10:02:53.0297727Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nathanwhit and others added 26 commits August 22, 2019 18:53

Add header flag to check run-pass test output

54f80a5

Extract loading and comparison of compiletest outputs to new fn

0c379df

Moved into ```fn load_compare_outputs(&self, proc_res: &ProcRes, explicit_format: bool) -> usize```

Compare run-pass outputs if check-run-results flag enabled

b9ba8f9

Addresses rust-lang#63751

factor wide ptr metadata checking into separate method

92e75c0

also fat -> wide

validate raw wide pointers

96baf1c

test for too long slices

0c1cb32

Allow checking of both compile & run output for run-pass tests

0e3bc62

ty: use Align for ReprOptions pack and align.

c8a69e2

raw slices do not have to comply to the size limit

ae78862

adjust tests

04580b6

Fix build src/libtest

661141f

Update dbg macro test to use check-run-results flag for run-pass test

12e0420

Updates the dbg-macro-expected behavior test to remove the workaround and use the `check-run-result` flag/feature in compiletest. This serves to test the feature on a real use-case (as mentioned in rust-lang#63751)

Update rust-installer to limit memory use

3571789

improper_ctypes: guard against accidental change to Unique<T>.

cd2e7fc

Small improvement for Ord implementation of integers

ade191c

Fix typo (unqique -> unique)

4aff84f

Co-Authored-By: Robin Kruppe <robin.kruppe@gmail.com>

--bless lint-ctypes-enum.stderr

5552945

Rollup merge of rust-lang#63880 - RalfJung:miri-meta, r=oli-obk

c368379

Validation: check raw wide pointer metadata While I was at it, I also added a missing check for slices not to be too big. r? @oli-obk Fixes rust-lang/miri#918

Rollup merge of rust-lang#63914 - hvenev:repr-fields, r=eddyb

a438714

ty: use Align for ReprOptions pack and align.

Rollup merge of rust-lang#63949 - JohnTitor:fix-quick-build, r=Mark-S…

5954e51

…imulacrum Fix build src/libtest Fixes rust-lang#63928 r? @Mark-Simulacrum

Rollup merge of rust-lang#63991 - Centril:unique-improper-ctype, r=rk…

ea5bf7a

…ruppe `improper_ctypes`: guard against accidental change to `Unique<T>` r? @eddyb

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 29, 2019

Centril closed this Aug 29, 2019

Centril deleted the rollup-c4ekjw0 branch August 29, 2019 09:36

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #63995

Rollup of 8 pull requests #63995

Centril commented Aug 29, 2019

Centril commented Aug 29, 2019

bors commented Aug 29, 2019

bors commented Aug 29, 2019

Centril commented Aug 29, 2019

rust-highfive commented Aug 29, 2019

Rollup of 8 pull requests #63995

Rollup of 8 pull requests #63995

Conversation

Centril commented Aug 29, 2019

Centril commented Aug 29, 2019

bors commented Aug 29, 2019

bors commented Aug 29, 2019

Centril commented Aug 29, 2019

rust-highfive commented Aug 29, 2019