Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri: detect too large dynamically sized objects #64014

Merged
merged 5 commits into from Aug 31, 2019

Conversation

@RalfJung
Copy link
Member

commented Aug 30, 2019

Needed to make rust-lang/miri#929 pass.

r? @oli-obk

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Is it possible to write a rustc test for this?

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

I tried, but then I ran into #63952.

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Ah, I found a way to do it. Does this fit into one of the existing files?

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

ub-wide-ptr.rs looks like a good match to me.

r=me either as is or with the test merged into ub-wide-ptr.rs

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

ub-wide-ptr.rs looks like a good match to me.

That won't work; that's a allow(const_err) test but this test here is a const_err (the error happens before we even start validation).

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

📌 Commit bb34749 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Aug 30, 2019
Rollup merge of rust-lang#64014 - RalfJung:miri-slice, r=oli-obk
 miri: detect too large dynamically sized objects

Needed to make rust-lang/miri#929 pass.

r? @oli-obk
bors added a commit that referenced this pull request Aug 30, 2019
Auto merge of #64026 - Centril:rollup-le667lp, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #62957 (Match the loop examples)
 - #63600 (Merge oli-obk mail addresses)
 - #63684 (Constify LinkedList new function)
 - #63847 ([rustdoc] Fix system theme detection)
 - #63999 (Add missing links on AsRef trait)
 - #64014 ( miri: detect too large dynamically sized objects )
 - #64015 (some const-eval test tweaks)

Failed merges:

r? @ghost

@bors bors merged commit bb34749 into rust-lang:master Aug 31, 2019

4 checks passed

pr Build #20190830.30 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@RalfJung RalfJung deleted the RalfJung:miri-slice branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.