Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for converting `bool` to `Option<T>` #64255

Merged
merged 4 commits into from Sep 8, 2019

Conversation

@varkor
Copy link
Member

commented Sep 7, 2019

This provides a reference implementation for rust-lang/rfcs#2757.

@Centril

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

@rust-highfive rust-highfive assigned Centril and unassigned KodrAus Sep 7, 2019

@varkor varkor marked this pull request as ready for review Sep 7, 2019

@Centril
Copy link
Member

left a comment

I think it's fine to land this as unstable for now before the RFC has landed.

r=me rollup with review comments addressed.

src/libcore/bool/mod.rs Outdated Show resolved Hide resolved
src/libcore/lib.rs Outdated Show resolved Hide resolved
src/libcore/bool/mod.rs Outdated Show resolved Hide resolved
varkor added 2 commits Sep 7, 2019
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

📌 Commit 7b3f729 has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019
Rollup merge of rust-lang#64255 - varkor:bool-to-option, r=Centril
Add methods for converting `bool` to `Option<T>`

This provides a reference implementation for rust-lang/rfcs#2757.
@Centril Centril referenced this pull request Sep 7, 2019
bors added a commit that referenced this pull request Sep 7, 2019
Auto merge of #64269 - Centril:rollup-y4dm32c, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #64052 (Rename test locals to work around LLDB bug)
 - #64066 (Support "soft" feature-gating using a lint)
 - #64177 (resolve: Do not afraid to set current module to enums and traits)
 - #64229 (Reduce span to function name in unreachable calls)
 - #64255 (Add methods for converting `bool` to `Option<T>`)

Failed merges:

r? @ghost

@bors bors merged commit 7b3f729 into rust-lang:master Sep 8, 2019

4 checks passed

pr Build #20190907.20 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@varkor varkor deleted the varkor:bool-to-option branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.