Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false "never constructed" warnings for `Self::` variant paths #64424

Closed
wants to merge 1 commit into from

Conversation

@jakubadamw
Copy link
Contributor

commented Sep 13, 2019

Closes #64362.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2019

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

📌 Commit 10ed1f1 has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
Fix false "never constructed" warnings for `Self::` variant paths

Closes rust-lang#64362.
bors added a commit that referenced this pull request Sep 14, 2019
Rollup of 17 pull requests

Successful merges:

 - #64116 (Fix minor typo in docs.)
 - #64290 (Provide a span if main function is not present in crate)
 - #64302 (Shrink `ObligationCauseCode`)
 - #64372 (use randSecure and randABytes)
 - #64374 (Box `DiagnosticBuilder`.)
 - #64375 (Fast path for vec.clear/truncate )
 - #64378 (Fix inconsistent link formatting.)
 - #64384 (Trim rustc-workspace-hack)
 - #64393 ( declare EnvKey before use to fix build error)
 - #64420 (Inline `mark_neighbours_as_waiting_from`.)
 - #64422 (Remove raw string literal quotes from error index descriptions)
 - #64423 (Add self to .mailmap)
 - #64424 (Fix false "never constructed" warnings for `Self::` variant paths)
 - #64425 (typo fix)
 - #64431 (fn ptr is structural match)
 - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.)
 - #64439 (fix #64430, confusing `owned_box` error message in no_std build)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Assigning blame of failure in #64449 (comment) to this PR, @bors r-

(This is a guestimate)

@jakubadamw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

@Centril, no, the failure is unrelated.

@Centril

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

@jakubadamw Any alternate theory? This PR seemed to be the only one related to TypeckTables somehow...

@jakubadamw

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

@Centril, sorry, you're absolutely right. Looking into this.

@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 20, 2019

Ping from triage.
@jakubadamw Hello! Can you please post your status regarding this PR?
Thank you.

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

☔️ The latest upstream changes (presumably #64813) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon

This comment has been minimized.

Copy link

commented Oct 5, 2019

Ping from triage.
@jakubadamw This PR has sat idle for the last few weeks, I'm going to close this due to inactivity.
If you have time to move this forward please re-open this PR.
CC @estebank

Thank you!

@JohnCSimon JohnCSimon closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.