Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit impls referencing errors to overlap #64474

Merged
merged 1 commit into from Sep 15, 2019

Conversation

@Mark-Simulacrum
Copy link
Member

commented Sep 14, 2019

Fixes #43400; previously this would emit an overlapping impls error, but no longer does.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 14, 2019

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc/ty/mod.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:permit-err-overlap branch from e96c280 to 959c710 Sep 15, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

Both comments resolved.

@matthewjasper

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

📌 Commit 959c710 has been approved by matthewjasper

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

⌛️ Testing commit 959c710 with merge 96d07e0...

bors added a commit that referenced this pull request Sep 15, 2019
…asper

Permit impls referencing errors to overlap

Fixes #43400; previously this would emit an overlapping impls error, but no longer does.
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing 96d07e0 to master...

@bors bors added the merged-by-bors label Sep 15, 2019
@bors bors merged commit 959c710 into rust-lang:master Sep 15, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20190915.13 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.