Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use println!() instead of println!("") #64504

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@guanqun
Copy link
Contributor

commented Sep 16, 2019

The empty string is unnecessary.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 16, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@jonas-schievink

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Thanks!

r? @jonas-schievink @bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

📌 Commit 5355a16 has been approved by jonas-schievink

Centril added a commit to Centril/rust that referenced this pull request Sep 16, 2019
…tr, r=jonas-schievink

use println!() instead of println!("")

The empty string is unnecessary.
bors added a commit that referenced this pull request Sep 16, 2019
Rollup of 10 pull requests

Successful merges:

 - #63955 (Make sure interned constants are immutable)
 - #64028 (Stabilize `Vec::new` and `String::new` as `const fn`s)
 - #64119 (ci: ensure all tool maintainers are assignable on issues)
 - #64444 (fix building libstd without backtrace feature)
 - #64446 (Fix build script sanitizer check.)
 - #64451 (when Miri tests are not passing, do not add Miri component)
 - #64467 (Hide diagnostics emitted during --cfg parsing)
 - #64497 (Don't print the "total" `-Ztime-passes` output if `--prints=...` is also given)
 - #64499 (Use `Symbol` in two more functions.)
 - #64504 (use println!() instead of println!(""))

Failed merges:

r? @ghost
@bors bors merged commit 5355a16 into rust-lang:master Sep 16, 2019
4 checks passed
4 checks passed
pr Build #20190916.17 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@guanqun guanqun deleted the guanqun:use-println-without-empty-str branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.