Revert #64451 #64543
Merged
Revert #64451 #64543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ p=100 |
|
📌 Commit a7a6ded has been approved by |
bors
added
the
S-waiting-on-bors
This was referenced Sep 17, 2019
This was referenced Sep 17, 2019
|
Maybe use #64544 instead to not lose the comments I added? That includes your commit here. |
|
☀️ Test successful - checks-azure |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64451 is making the release process panic, causing today's missing nightly (see #64540). This reverts that PR, but I'm happy to review a fixed version of it.
cc @RalfJung
r? @ghost
Fixes #64540