Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0561 #65098

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Add long error explanation for E0561 #65098

merged 2 commits into from
Oct 8, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2019
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 4, 2019
Closed
100 tasks
@eddyb
Copy link
Member

eddyb commented Oct 4, 2019

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned eddyb Oct 4, 2019
Centril
Centril reviewed Oct 4, 2019
View reviewed changes
src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Oct 4, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned estebank Oct 4, 2019
@GuillaumeGomez
Copy link
Member Author

Thanks for the reviews! Updated.

Centril
Centril reviewed Oct 6, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with these suggestions applied

src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2019
@bors

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

Updated.

@Centril
Copy link
Contributor

Centril commented Oct 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit 8dd0008 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
@Centril
Rollup merge of rust-lang#65098 - GuillaumeGomez:long-err-explanation…
73685ec 
…-E0561, r=Centril

Add long error explanation for E0561

Part of rust-lang#61137
@Centril Centril mentioned this pull request Oct 8, 2019
Merged
bors added a commit that referenced this pull request Oct 8, 2019
@bors
Auto merge of #65196 - Centril:rollup-q06lcxm, r=Centril
1e1f25e 
Rollup of 8 pull requests

Successful merges:

 - #64726 (rewrite documentation for unimplemented! to clarify use)
 - #65040 (syntax: more cleanups in item and function signature parsing)
 - #65046 (Make `Cell::new` method come first in documentation)
 - #65098 (Add long error explanation for E0561)
 - #65150 (Suggest dereferencing boolean reference when used in 'if' or 'while')
 - #65154 (Fix const generic arguments not displaying in types mismatch diagnostic)
 - #65181 (fix bug in folding for constants)
 - #65187 (use 'invalid argument' for vxWorks)

Failed merges:

 - #65179 (Add long error explanation for E0567)

r? @ghost
@bors bors merged commit 8dd0008 into rust-lang:master Oct 8, 2019
@GuillaumeGomez GuillaumeGomez deleted the long-err-explanation-E0561 branch October 8, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@estebank estebank estebank left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GuillaumeGomez @rust-highfive @eddyb @Centril @bors @estebank