Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy #65206

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Update Clippy #65206

merged 1 commit into from
Oct 8, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Oct 8, 2019 •
edited
Loading

I cannot test it locally but Clippy CI is green so it should work.

Fixes #65096

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2019
@mati865
Copy link
Contributor Author

mati865 commented Oct 8, 2019

r? @Manishearth @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Oct 8, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Oct 8, 2019

📌 Commit 6d3e242 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2019
@mati865 mati865 mentioned this pull request Oct 8, 2019
Merged
@bors
Copy link
Contributor

bors commented Oct 8, 2019

⌛ Testing commit 6d3e242 with merge 3fa9554...

bors added a commit that referenced this pull request Oct 8, 2019
@bors
Auto merge of #65206 - mati865:clippyup, r=oli-obk
3fa9554 
Update Clippy

I cannot test it locally but Clippy CI is green so it should work.

Fixes #65096
@bors
Copy link
Contributor

bors commented Oct 8, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 3fa9554 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2019
@bors bors merged commit 6d3e242 into rust-lang:master Oct 8, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #65206!

Tested on commit 3fa9554.
Direct link to PR: #65206

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 8, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#65206!
84ceddd 
Tested on commit rust-lang/rust@3fa9554.
Direct link to PR: <rust-lang/rust#65206>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@mati865 mati865 deleted the clippyup branch October 8, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#65087
6 participants
@mati865 @rust-highfive @oli-obk @bors @alexcrichton @Manishearth