Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring attention to suggestions when the only difference is capitalization #65398

Merged
merged 3 commits into from Oct 15, 2019

Conversation

@estebank
Copy link
Contributor

estebank commented Oct 14, 2019

CC #65386.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 14, 2019

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-14T04:49:54.7159777Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-14T04:49:54.7388569Z ##[command]git config gc.auto 0
2019-10-14T04:49:54.7467762Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-14T04:49:54.7540517Z ##[command]git config --get-all http.proxy
2019-10-14T04:49:54.7687653Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65398/merge:refs/remotes/pull/65398/merge
---
2019-10-14T04:56:37.1500523Z    Compiling serde_json v1.0.40
2019-10-14T04:56:38.8858302Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-10-14T04:56:50.2033821Z     Finished release [optimized] target(s) in 1m 27s
2019-10-14T04:56:50.2109804Z tidy check
2019-10-14T04:56:50.6253485Z tidy error: /checkout/src/librustc_errors/lib.rs:253: trailing whitespace
2019-10-14T04:56:52.5305701Z Found 482 error codes
2019-10-14T04:56:52.5306632Z Found 0 error codes with no tests
2019-10-14T04:56:52.5307153Z Done!
2019-10-14T04:56:52.5310855Z some tidy checks failed
2019-10-14T04:56:52.5310855Z some tidy checks failed
2019-10-14T04:56:52.5313393Z 
2019-10-14T04:56:52.5313663Z 
2019-10-14T04:56:52.5314717Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-10-14T04:56:52.5315381Z 
2019-10-14T04:56:52.5315734Z 
2019-10-14T04:56:52.5319335Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-10-14T04:56:52.5319693Z Build completed unsuccessfully in 0:01:31
2019-10-14T04:56:52.5319693Z Build completed unsuccessfully in 0:01:31
2019-10-14T04:56:52.5369027Z == clock drift check ==
2019-10-14T04:56:52.5383576Z   local time: Mon Oct 14 04:56:52 UTC 2019
2019-10-14T04:56:52.6878273Z   network time: Mon, 14 Oct 2019 04:56:52 GMT
2019-10-14T04:56:52.6881657Z == end clock drift check ==
2019-10-14T04:56:53.6297967Z ##[error]Bash exited with code '1'.
2019-10-14T04:56:53.6351751Z ##[section]Starting: Checkout
2019-10-14T04:56:53.6353287Z ==============================================================================
2019-10-14T04:56:53.6353329Z Task         : Get sources
2019-10-14T04:56:53.6353366Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Copy link
Member

davidtwco left a comment

LGTM, r=me once CI is passing (and Centril's comments resolved).

@estebank estebank force-pushed the estebank:capitalization-only branch from 641b823 to 6dd718c Oct 14, 2019
@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Oct 14, 2019

@bors r=varkor

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 14, 2019

📌 Commit 8bf6d35 has been approved by varkor

tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
Bring attention to suggestions when the only difference is capitalization

CC rust-lang#65386.
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 10 pull requests

Successful merges:

 - #65170 (rustc_metadata: Privatize private code and remove dead code)
 - #65260 (Optimize `LexicalResolve::expansion`.)
 - #65261 (Remove `Option` from `TokenStream`)
 - #65332 (std::fmt: reorder docs)
 - #65340 (Several changes to the codegen backend organization)
 - #65365 (Include const generic arguments in metadata)
 - #65398 (Bring attention to suggestions when the only difference is capitalization)
 - #65410 (syntax: add parser recovery for intersection- / and-patterns `p1 @ p2`)
 - #65415 (Remove an outdated test output file)
 - #65416 (Minor sync changes)

Failed merges:

r? @ghost
@bors bors merged commit 8bf6d35 into rust-lang:master Oct 15, 2019
4 checks passed
4 checks passed
pr Build #20191014.58 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
let confusable = found.chars().zip(suggested.chars()).filter(|(f, s)| f != s).all(|(f, s)| {
(ascii_confusables.contains(&f) || ascii_confusables.contains(&s))
});
confusable && found.to_lowercase() == suggested.to_lowercase()

This comment has been minimized.

Copy link
@AnthonyMikh

AnthonyMikh Oct 25, 2019

Contributor

This can avoid an allocation by changing into found.chars().flat_map(char::to_lowercase).eq(suggested.chars().flat_map(char::to_lowercase)). Or it is not worth it?

@ultrasaurus ultrasaurus referenced this pull request Oct 29, 2019
3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.