Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASI sleep impl #65617

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@newpavlov
Copy link
Contributor

newpavlov commented Oct 20, 2019

Closes #65607

@sunfishcode
Is it fine to use 0 for the identifier field? What is this field used for?

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Oct 21, 2019

@sunfishcode

This comment has been minimized.

Copy link
Contributor

sunfishcode commented Oct 21, 2019

@newpavlov That identifier field is a historical artifact and isn't used by anything.

sunfishcode added a commit to sunfishcode/WASI that referenced this pull request Oct 21, 2019
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 22, 2019

@bors: r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 22, 2019

📌 Commit 1e2b711 has been approved by alexcrichton

@newpavlov

This comment has been minimized.

Copy link
Contributor Author

newpavlov commented Oct 22, 2019

@sunfishcode
Are there plans to remove this field eventually? I think at the very least it's worth to add a deprecation notice to the Core docs. Some kind of semantic versioning for the Core API would've been nice as well.

P.S.: Slightly relevant to introducing changes to the Core API: can you please take a look at #64434? Are there indeed plans to change fd_prestat_* functions?

@sunfishcode

This comment has been minimized.

Copy link
Contributor

sunfishcode commented Oct 22, 2019

@newpavlov I just submitted WebAssembly/WASI#125 to start the process to remove it :-). And yes, we have just established a versioning scheme.

Concerning #64434, yes, there are changes to the fd_prestat functions planned, including adding support for pre-opened files and other resources.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2019
Fix WASI sleep impl

Closes rust-lang#65607

@sunfishcode
Is it fine to use 0 for the `identifier` field? What is this field used for?
bors added a commit that referenced this pull request Oct 22, 2019
Rollup of 10 pull requests

Successful merges:

 - #63810 (Make <*const/mut T>::offset_from `const fn`)
 - #65583 (rustc_metadata: use a table for super_predicates, fn_sig, impl_trait_ref.)
 - #65617 (Fix WASI sleep impl)
 - #65641 (Derive `Rustc{En,De}codable` for `TokenStream`.)
 - #65656 (Add option to disable keyboard shortcuts in docs)
 - #65681 (Code cleanups following up on #65576.)
 - #65686 (refactor and move `maybe_append` )
 - #65688 (Add some tests for fixed ICEs)
 - #65689 (bring back some Debug instances for Miri)
 - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
Fix WASI sleep impl

Closes rust-lang#65607

@sunfishcode
Is it fine to use 0 for the `identifier` field? What is this field used for?
bors added a commit that referenced this pull request Oct 23, 2019
Rollup of 14 pull requests

Successful merges:

 - #64145 (Target-feature documented as unsafe)
 - #65007 (Mention keyword closing policy)
 - #65417 (Add more coherence tests)
 - #65507 (Fix test style in unused parentheses lint test)
 - #65591 (Add long error explanation for E0588)
 - #65617 (Fix WASI sleep impl)
 - #65656 (Add option to disable keyboard shortcuts in docs)
 - #65678 (Add long error explanation for E0728)
 - #65681 (Code cleanups following up on #65576.)
 - #65686 (refactor and move `maybe_append` )
 - #65688 (Add some tests for fixed ICEs)
 - #65689 (bring back some Debug instances for Miri)
 - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)
 - #65706 (Add missing space in librustdoc)

Failed merges:

r? @ghost
@bors bors merged commit 1e2b711 into rust-lang:master Oct 23, 2019
4 checks passed
4 checks passed
pr Build #20191020.5 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@newpavlov newpavlov deleted the newpavlov:patch-2 branch Oct 23, 2019
sunfishcode added a commit to WebAssembly/WASI that referenced this pull request Oct 31, 2019
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.