Fix WASI sleep impl #65617
Merged
Fix WASI sleep impl #65617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@newpavlov That |
sunfishcode
added a commit
to sunfishcode/WASI
that referenced
this pull request
Oct 21, 2019
As noticed in rust-lang/rust#65617 (comment), the `clock.identifier` field in `subscription_t` isn't used for anything. It came from CloudABI, where it appears to be a holdover from an earlier API feature which is no longer present.
|
@bors: r+ rollup |
|
📌 Commit 1e2b711 has been approved by |
bors
added
S-waiting-on-bors
|
@sunfishcode P.S.: Slightly relevant to introducing changes to the Core API: can you please take a look at #64434? Are there indeed plans to change |
|
@newpavlov I just submitted WebAssembly/WASI#125 to start the process to remove it :-). And yes, we have just established a versioning scheme. Concerning #64434, yes, there are changes to the |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 22, 2019
Fix WASI sleep impl Closes rust-lang#65607 @sunfishcode Is it fine to use 0 for the `identifier` field? What is this field used for?
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 23, 2019
Fix WASI sleep impl Closes rust-lang#65607 @sunfishcode Is it fine to use 0 for the `identifier` field? What is this field used for?
bors
added a commit
that referenced
this pull request
Oct 23, 2019
Rollup of 14 pull requests Successful merges: - #64145 (Target-feature documented as unsafe) - #65007 (Mention keyword closing policy) - #65417 (Add more coherence tests) - #65507 (Fix test style in unused parentheses lint test) - #65591 (Add long error explanation for E0588) - #65617 (Fix WASI sleep impl) - #65656 (Add option to disable keyboard shortcuts in docs) - #65678 (Add long error explanation for E0728) - #65681 (Code cleanups following up on #65576.) - #65686 (refactor and move `maybe_append` ) - #65688 (Add some tests for fixed ICEs) - #65689 (bring back some Debug instances for Miri) - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.) - #65706 (Add missing space in librustdoc) Failed merges: r? @ghost
sunfishcode
added a commit
to WebAssembly/WASI
that referenced
this pull request
Oct 31, 2019
As noticed in rust-lang/rust#65617 (comment), the `clock.identifier` field in `subscription_t` isn't used for anything. It came from CloudABI, where it appears to be a holdover from an earlier API feature which is no longer present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65607
@sunfishcode
Is it fine to use 0 for the
identifierfield? What is this field used for?