Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable keyboard shortcuts in docs #65656

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #65211.

r? @Manishearth

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2019
@Dylan-DPC-zz
Copy link

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2019

📌 Commit 8774484 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2019
…cut, r=Dylan-DPC

Add option to disable keyboard shortcuts in docs

Fixes rust-lang#65211.

r? @Manishearth
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
…cut, r=Dylan-DPC

Add option to disable keyboard shortcuts in docs

Fixes rust-lang#65211.

r? @Manishearth
bors added a commit that referenced this pull request Oct 23, 2019
Rollup of 14 pull requests

Successful merges:

 - #64145 (Target-feature documented as unsafe)
 - #65007 (Mention keyword closing policy)
 - #65417 (Add more coherence tests)
 - #65507 (Fix test style in unused parentheses lint test)
 - #65591 (Add long error explanation for E0588)
 - #65617 (Fix WASI sleep impl)
 - #65656 (Add option to disable keyboard shortcuts in docs)
 - #65678 (Add long error explanation for E0728)
 - #65681 (Code cleanups following up on #65576.)
 - #65686 (refactor and move `maybe_append` )
 - #65688 (Add some tests for fixed ICEs)
 - #65689 (bring back some Debug instances for Miri)
 - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)
 - #65706 (Add missing space in librustdoc)

Failed merges:

r? @ghost
@bors bors merged commit 8774484 into rust-lang:master Oct 23, 2019
@GuillaumeGomez GuillaumeGomez deleted the option-disable-shortcut branch October 23, 2019 20:02
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
…-feature, r=Dylan-DPC

Fix default "disable-shortcuts" feature value

Follow-up of rust-lang#65656

It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!).

r? @Dylan-DPC
cc @kinnison
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
…-feature, r=Dylan-DPC

Fix default "disable-shortcuts" feature value

Follow-up of rust-lang#65656

It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!).

r? @Dylan-DPC
cc @kinnison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to disable rustdoc keyboard shortcuts
5 participants