Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests for fixed ICEs #65688

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Add some tests for fixed ICEs #65688

merged 4 commits into from
Oct 23, 2019

Conversation

JohnTitor
Copy link
Member

Fixes #41366 from 1.35.0
Fixes #51431 from 1.31.0-nightly (77af314 2018-10-11) (on my local)
Fixes #52437 from nightly
Fixes #63496 from nightly

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2019
@Centril
Copy link
Contributor

Centril commented Oct 22, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 22, 2019

📌 Commit 51fd277d287f7e302c6ce144c69d66fc3c49389a has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-10-22T08:08:54.4302016Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-22T08:08:54.4537575Z ##[command]git config gc.auto 0
2019-10-22T08:08:54.4646554Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-22T08:08:54.4738412Z ##[command]git config --get-all http.proxy
2019-10-22T08:08:54.4923784Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65688/merge:refs/remotes/pull/65688/merge
---
2019-10-22T09:17:56.4406655Z .................................................................................................... 1600/9210
2019-10-22T09:18:02.4564434Z .................................................................................................... 1700/9210
2019-10-22T09:18:16.8617721Z .....................................i...............i.............................................. 1800/9210
2019-10-22T09:18:25.6460679Z .................................................................................................... 1900/9210
2019-10-22T09:18:41.6342993Z ...........................iiiii.................................................................... 2000/9210
2019-10-22T09:18:53.6082899Z .................................................................................................... 2200/9210
2019-10-22T09:18:56.5033150Z .................................................................................................... 2300/9210
2019-10-22T09:19:01.9655023Z .................................................................................................... 2400/9210
2019-10-22T09:19:27.4964251Z .................................................................................................... 2500/9210
---
2019-10-22T09:22:42.5387144Z ..............................i...............i..................................................... 4800/9210
2019-10-22T09:22:55.7419555Z .................................................................................................... 4900/9210
2019-10-22T09:23:03.1675304Z .................................................................................................... 5000/9210
2019-10-22T09:23:13.2665416Z .................................................................................................... 5100/9210
2019-10-22T09:23:22.1034228Z ..............................ii.ii................................................................. 5200/9210
2019-10-22T09:23:32.7601277Z .................................................................................................... 5400/9210
2019-10-22T09:23:44.5361006Z ................................................................................................i... 5500/9210
2019-10-22T09:23:54.0600346Z .................................................................................................... 5600/9210
2019-10-22T09:23:59.3521716Z .................................................................................................... 5700/9210
2019-10-22T09:23:59.3521716Z .................................................................................................... 5700/9210
2019-10-22T09:24:11.3419471Z .............................................................................................ii...i. 5800/9210
2019-10-22T09:24:26.8021715Z .ii...........i..................................................................................... 5900/9210
2019-10-22T09:24:52.0521908Z .................................................................................................... 6100/9210
2019-10-22T09:25:02.1820779Z .................................................................................................... 6200/9210
2019-10-22T09:25:02.1820779Z .................................................................................................... 6200/9210
2019-10-22T09:25:18.3860272Z ...............i..ii................................................................................ 6300/9210
2019-10-22T09:25:40.7453698Z ...........................................................................i........................ 6500/9210
2019-10-22T09:25:43.3834869Z .................................................................................................... 6600/9210
2019-10-22T09:25:46.0721503Z ..................................................i................................................. 6700/9210
2019-10-22T09:25:49.7811785Z .................................................................................................... 6800/9210
---
2019-10-22T09:30:25.3616086Z ---- [ui] ui/associated-const/issue-63496.rs stdout ----
2019-10-22T09:30:25.3616180Z diff of stderr:
2019-10-22T09:30:25.3616210Z 
2019-10-22T09:30:25.3616253Z 3    |
2019-10-22T09:30:25.3616327Z 4 LL |     const C: usize;
2019-10-22T09:30:25.3616612Z 5    |     --------------- required by `A::C`
2019-10-22T09:30:25.3616821Z - LL |     
2019-10-22T09:30:25.3616878Z + LL | 
2019-10-22T09:30:25.3617125Z 7 LL |     fn f() -> ([u8; A::C], [u8; A::C]);
2019-10-22T09:30:25.3617219Z 9 
2019-10-22T09:30:25.3617245Z 
2019-10-22T09:30:25.3617300Z 12    |
2019-10-22T09:30:25.3617343Z 13 LL |     const C: usize;
2019-10-22T09:30:25.3617343Z 13 LL |     const C: usize;
2019-10-22T09:30:25.3617578Z 14    |     --------------- required by `A::C`
2019-10-22T09:30:25.3617796Z - LL |     
2019-10-22T09:30:25.3617841Z + LL | 
2019-10-22T09:30:25.3618074Z 16 LL |     fn f() -> ([u8; A::C], [u8; A::C]);
2019-10-22T09:30:25.3618185Z 18 
2019-10-22T09:30:25.3618212Z 
2019-10-22T09:30:25.3618238Z 
2019-10-22T09:30:25.3618283Z The actual stderr differed from the expected stderr.
2019-10-22T09:30:25.3618283Z The actual stderr differed from the expected stderr.
2019-10-22T09:30:25.3618619Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/issue-63496/issue-63496.stderr
2019-10-22T09:30:25.3619303Z To update references, rerun the tests and pass the `--bless` flag
2019-10-22T09:30:25.3619633Z To only update this specific test, also pass `--test-args associated-const/issue-63496.rs`
2019-10-22T09:30:25.3619734Z error: 1 errors occurred comparing output.
2019-10-22T09:30:25.3620002Z status: exit code: 1
2019-10-22T09:30:25.3620002Z status: exit code: 1
2019-10-22T09:30:25.3620825Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-const/issue-63496.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/issue-63496" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/issue-63496/auxiliary" "-A" "unused"
2019-10-22T09:30:25.3621181Z ------------------------------------------
2019-10-22T09:30:25.3621224Z 
2019-10-22T09:30:25.3621457Z ------------------------------------------
2019-10-22T09:30:25.3621517Z stderr:
2019-10-22T09:30:25.3621517Z stderr:
2019-10-22T09:30:25.3621744Z ------------------------------------------
2019-10-22T09:30:25.3621795Z error[E0283]: type annotations needed: cannot resolve `_: A`
2019-10-22T09:30:25.3622049Z   --> /checkout/src/test/ui/associated-const/issue-63496.rs:4:21
2019-10-22T09:30:25.3622159Z LL |     const C: usize;
2019-10-22T09:30:25.3622159Z LL |     const C: usize;
2019-10-22T09:30:25.3622386Z    |     --------------- required by `A::C`
2019-10-22T09:30:25.3622448Z LL | 
2019-10-22T09:30:25.3622674Z LL |     fn f() -> ([u8; A::C], [u8; A::C]);
2019-10-22T09:30:25.3622765Z 
2019-10-22T09:30:25.3622765Z 
2019-10-22T09:30:25.3622812Z error[E0283]: type annotations needed: cannot resolve `_: A`
2019-10-22T09:30:25.3623072Z   --> /checkout/src/test/ui/associated-const/issue-63496.rs:4:33
2019-10-22T09:30:25.3623177Z LL |     const C: usize;
2019-10-22T09:30:25.3623177Z LL |     const C: usize;
2019-10-22T09:30:25.3623414Z    |     --------------- required by `A::C`
2019-10-22T09:30:25.3623461Z LL | 
2019-10-22T09:30:25.3623700Z LL |     fn f() -> ([u8; A::C], [u8; A::C]);
2019-10-22T09:30:25.3623780Z 
2019-10-22T09:30:25.3623823Z error: aborting due to 2 previous errors
2019-10-22T09:30:25.3623866Z 
2019-10-22T09:30:25.3624116Z For more information about this error, try `rustc --explain E0283`.
---
2019-10-22T09:30:25.3662918Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-22T09:30:25.3663008Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-22T09:30:25.3685241Z 
2019-10-22T09:30:25.3686856Z 
2019-10-22T09:30:25.3700916Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-22T09:30:25.3701440Z 
2019-10-22T09:30:25.3701478Z 
2019-10-22T09:30:25.3705298Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-22T09:30:25.3705378Z Build completed unsuccessfully in 1:14:39
2019-10-22T09:30:25.3705378Z Build completed unsuccessfully in 1:14:39
2019-10-22T09:30:25.3773035Z == clock drift check ==
2019-10-22T09:30:25.3795966Z   local time: Tue Oct 22 09:30:25 UTC 2019
2019-10-22T09:30:25.9158766Z   network time: Tue, 22 Oct 2019 09:30:25 GMT
2019-10-22T09:30:25.9163984Z == end clock drift check ==
2019-10-22T09:30:26.9613540Z 
2019-10-22T09:30:26.9783156Z ##[error]Bash exited with code '1'.
2019-10-22T09:30:26.9841989Z ##[section]Starting: Checkout
2019-10-22T09:30:26.9844065Z ==============================================================================
2019-10-22T09:30:26.9844124Z Task         : Get sources
2019-10-22T09:30:26.9844178Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented Oct 22, 2019

@bors r- Seems it failed.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2019
@JohnTitor
Copy link
Member Author

oops, I forgot re-running test after tidy, just updated stderr.

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2019
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@JohnTitor
Copy link
Member Author

It's green now (I'm not sure I can use r+ perm other than rollup)

@Dylan-DPC-zz
Copy link

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2019

📌 Commit 7a85c43 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2019
@JohnTitor
Rollup merge of rust-lang#65688 - JohnTitor:add-some-tests, r=Dylan-DPC
d703346 
Add some tests for fixed ICEs

Fixes rust-lang#41366 from 1.35.0
Fixes rust-lang#51431 from 1.31.0-nightly (77af314 2018-10-11) (on my local)
Fixes rust-lang#52437 from nightly
Fixes rust-lang#63496 from nightly

r? @Centril
@JohnTitor JohnTitor mentioned this pull request Oct 22, 2019
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
@JohnTitor
Rollup merge of rust-lang#65688 - JohnTitor:add-some-tests, r=Dylan-DPC
c3e5413 
Add some tests for fixed ICEs

Fixes rust-lang#41366 from 1.35.0
Fixes rust-lang#51431 from 1.31.0-nightly (77af314 2018-10-11) (on my local)
Fixes rust-lang#52437 from nightly
Fixes rust-lang#63496 from nightly

r? @Centril
@JohnTitor JohnTitor mentioned this pull request Oct 23, 2019
Merged
bors added a commit that referenced this pull request Oct 23, 2019
@bors
Auto merge of #65716 - JohnTitor:rollup-fkcr85k, r=JohnTitor
f466f52 
Rollup of 14 pull requests

Successful merges:

 - #64145 (Target-feature documented as unsafe)
 - #65007 (Mention keyword closing policy)
 - #65417 (Add more coherence tests)
 - #65507 (Fix test style in unused parentheses lint test)
 - #65591 (Add long error explanation for E0588)
 - #65617 (Fix WASI sleep impl)
 - #65656 (Add option to disable keyboard shortcuts in docs)
 - #65678 (Add long error explanation for E0728)
 - #65681 (Code cleanups following up on #65576.)
 - #65686 (refactor and move `maybe_append` )
 - #65688 (Add some tests for fixed ICEs)
 - #65689 (bring back some Debug instances for Miri)
 - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)
 - #65706 (Add missing space in librustdoc)

Failed merges:

r? @ghost
@bors bors merged commit 7a85c43 into rust-lang:master Oct 23, 2019
@JohnTitor JohnTitor deleted the add-some-tests branch October 23, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
5 participants
@JohnTitor @Centril @bors @rust-highfive @Dylan-DPC-zz