Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri: add write_bytes method to Memory doing bounds-checks and supporting iterators #65621

Merged
merged 4 commits into from Oct 22, 2019

Conversation

@RalfJung
Copy link
Member

RalfJung commented Oct 20, 2019

This lets us avoid some direct Allocation accesses in Miri.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Oct 20, 2019

@RalfJung RalfJung changed the title miri add write_bytes method to Memory doing bounds-checks and supporting iterators miri: add write_bytes method to Memory doing bounds-checks and supporting iterators Oct 20, 2019
@christianpoveda christianpoveda mentioned this pull request Oct 20, 2019
3 of 3 tasks complete
@RalfJung RalfJung force-pushed the RalfJung:write_bytes branch from f82d2d4 to d4b3654 Oct 21, 2019
@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Oct 21, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 21, 2019

📌 Commit f6d70b4 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Oct 21, 2019
miri: add write_bytes method to Memory doing bounds-checks and supporting iterators

This lets us avoid some direct `Allocation` accesses in Miri.
bors added a commit that referenced this pull request Oct 21, 2019
Rollup of 7 pull requests

Successful merges:

 - #62330 (Change untagged_unions to not allow union fields with drop)
 - #65092 (make is_power_of_two a const function)
 - #65501 (Remove `src/llvm-emscripten` submodule)
 - #65621 (miri: add write_bytes method to Memory doing bounds-checks and supporting iterators)
 - #65647 (Remove unnecessary trait bounds and derivations)
 - #65653 (keep the root dir clean from debugging)
 - #65663 (Fix typo from #65214)

Failed merges:

 - #65660 (Rename `ConstValue::Infer(InferConst::Canonical(..))` to `ConstValue::Bound(..)`)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 21, 2019
miri: add write_bytes method to Memory doing bounds-checks and supporting iterators

This lets us avoid some direct `Allocation` accesses in Miri.
bors added a commit that referenced this pull request Oct 21, 2019
Rollup of 7 pull requests

Successful merges:

 - #62330 (Change untagged_unions to not allow union fields with drop)
 - #65092 (make is_power_of_two a const function)
 - #65621 (miri: add write_bytes method to Memory doing bounds-checks and supporting iterators)
 - #65647 (Remove unnecessary trait bounds and derivations)
 - #65653 (keep the root dir clean from debugging)
 - #65660 (Rename `ConstValue::Infer(InferConst::Canonical(..))` to `ConstValue::Bound(..)`)
 - #65663 (Fix typo from #65214)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Oct 22, 2019
Rollup of 7 pull requests

Successful merges:

 - #62330 (Change untagged_unions to not allow union fields with drop)
 - #65092 (make is_power_of_two a const function)
 - #65621 (miri: add write_bytes method to Memory doing bounds-checks and supporting iterators)
 - #65647 (Remove unnecessary trait bounds and derivations)
 - #65653 (keep the root dir clean from debugging)
 - #65660 (Rename `ConstValue::Infer(InferConst::Canonical(..))` to `ConstValue::Bound(..)`)
 - #65663 (Fix typo from #65214)

Failed merges:

r? @ghost
@bors bors merged commit f6d70b4 into rust-lang:master Oct 22, 2019
4 checks passed
4 checks passed
pr Build #20191021.22 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@RalfJung RalfJung deleted the RalfJung:write_bytes branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.