Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured suggestion for unnecessary bounds in type aliases #65914

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@estebank
Copy link
Contributor

estebank commented Oct 28, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 28, 2019

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

davidtwco left a comment

LGTM, left a suggestion, r=me if you don't think it's something we could do.

= help: the clause will not be checked when the type alias is used, and should be removed
help: the clause will not be checked when the type alias is used, and should be removed
|
LL | type _TaWhere1<T> = T;

This comment has been minimized.

Copy link
@davidtwco

davidtwco Oct 29, 2019

Member

Do you think it would be viable to extend the span so that we don't leave two spaces behind?

This comment has been minimized.

Copy link
@estebank

estebank Oct 29, 2019

Author Contributor

I noticed that too. The span wrangling needed to fix that makes me uneasy. I'd say let's leave this as is for now.

@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Oct 29, 2019

@bors r=davidtwco

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 29, 2019

📌 Commit 58b67c8 has been approved by davidtwco

tmandry added a commit to tmandry/rust that referenced this pull request Oct 30, 2019
…davidtwco

Use structured suggestion for unnecessary bounds in type aliases
bors added a commit that referenced this pull request Oct 30, 2019
Rollup of 7 pull requests

Successful merges:

 - #65068 (Custom lifetime error for `impl` item doesn't conform to `trait`)
 - #65112 (Add lint and tests for unnecessary parens around types)
 - #65241 (build-std compatible sanitizer support)
 - #65274 (Upload toolstates.json to rust-lang-ci2)
 - #65850 (Update comments re type parameter hack in object safety)
 - #65914 (Use structured suggestion for unnecessary bounds in type aliases)
 - #65945 (Optimize long-linker-command-line test)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 30, 2019
…davidtwco

Use structured suggestion for unnecessary bounds in type aliases
bors added a commit that referenced this pull request Oct 30, 2019
Rollup of 5 pull requests

Successful merges:

 - #65112 (Add lint and tests for unnecessary parens around types)
 - #65850 (Update comments re type parameter hack in object safety)
 - #65884 (syntax: ABI-oblivious grammar)
 - #65914 (Use structured suggestion for unnecessary bounds in type aliases)
 - #65959 (Fix an incorrect docstring for Immediate in librustc_mir/interpret.)

Failed merges:

 - #65916 (syntax: move stuff around)

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 31, 2019
…davidtwco

Use structured suggestion for unnecessary bounds in type aliases
bors added a commit that referenced this pull request Oct 31, 2019
Rollup of 14 pull requests

Successful merges:

 - #65112 (Add lint and tests for unnecessary parens around types)
 - #65459 (Fix `-Zunpretty=mir-cfg` to render multiple items)
 - #65471 (Add long error explanation for E0578)
 - #65857 (rustdoc: Resolve module-level doc references more locally)
 - #65914 (Use structured suggestion for unnecessary bounds in type aliases)
 - #65945 (Optimize long-linker-command-line test)
 - #65946 (Make `promote_consts` emit the errors when required promotion fails)
 - #65960 (doc: reword iter module example and mention other methods)
 - #65963 (update submodules to rust-lang)
 - #65972 (Fix libunwind build: Define __LITTLE_ENDIAN__ for LE targets)
 - #65977 (Fix incorrect diagnostics for expected type in E0271 with an associated type)
 - #65995 (Add error code E0743 for "C-variadic has been used on a non-foreign function")
 - #65997 (Fix outdated rustdoc of Once::init_locking function)
 - #66005 (vxWorks: remove code related unix socket)

Failed merges:

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Nov 1, 2019
…davidtwco

Use structured suggestion for unnecessary bounds in type aliases
bors added a commit that referenced this pull request Nov 1, 2019
Rollup of 16 pull requests

Successful merges:

 - #65112 (Add lint and tests for unnecessary parens around types)
 - #65470 (Don't hide ICEs from previous incremental compiles)
 - #65471 (Add long error explanation for E0578)
 - #65857 (rustdoc: Resolve module-level doc references more locally)
 - #65902 (Make ItemContext available for better diagnositcs)
 - #65914 (Use structured suggestion for unnecessary bounds in type aliases)
 - #65946 (Make `promote_consts` emit the errors when required promotion fails)
 - #65960 (doc: reword iter module example and mention other methods)
 - #65963 (update submodules to rust-lang)
 - #65972 (Fix libunwind build: Define __LITTLE_ENDIAN__ for LE targets)
 - #65977 (Fix incorrect diagnostics for expected type in E0271 with an associated type)
 - #65995 (Add error code E0743 for "C-variadic has been used on a non-foreign function")
 - #65997 (Fix outdated rustdoc of Once::init_locking function)
 - #66002 (Stabilize float_to_from_bytes feature)
 - #66005 (vxWorks: remove code related unix socket)
 - #66018 (Revert PR 64324: dylibs export generics again (for now))

Failed merges:

r? @ghost
@bors bors merged commit 58b67c8 into rust-lang:master Nov 1, 2019
4 checks passed
4 checks passed
pr Build #20191028.93 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.