Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some build-pass ui tests to use check-pass where applicable #66087

Merged
merged 7 commits into from
Nov 8, 2019
Merged

Update some build-pass ui tests to use check-pass where applicable #66087

merged 7 commits into from
Nov 8, 2019

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Nov 4, 2019 •
edited
Loading

Helps with issue #62277.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2019
@alexcrichton
Copy link
Member

There's not really a great way I can review this since it seems to just be blindly changing hundreds of tests. Do you know who originally wrote all these FIXME annotations? Can they perhaps be around to review this?

@tmiasko
Copy link
Contributor Author

tmiasko commented Nov 4, 2019

The #62277 issue provides some additional context.

Test cases updated here are those that have github issue opened for them.
I made the decision between check-pass / build-pass by examining the nature of
the issue, and / or related commit fixing it. I don't think there is easy way
to verify this, without replicating the work.

@alexcrichton
Copy link
Member

@Centril or @cramertj would one of y'all be willing to take over review of this?

@Centril
Copy link
Contributor

Centril commented Nov 5, 2019

r? @Centril cc @petrochenkov

@rust-highfive rust-highfive assigned Centril and unassigned alexcrichton Nov 5, 2019
Centril
Centril reviewed Nov 6, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...phew; that took a long time to review... :)

src/test/ui/issues/issue-10763.rs Show resolved Hide resolved
src/test/ui/suggestions/issue-57672.rs Outdated Show resolved Hide resolved
src/test/ui/privacy/issue-57264-2.rs Outdated Show resolved Hide resolved
src/test/ui/privacy/issue-57264-1.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-14330.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-29540.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-3563-2.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-37323.rs Show resolved Hide resolved
src/test/ui/issues/issue-37725.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-3991.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2019
@Centril Centril mentioned this pull request Nov 6, 2019
Open
@Centril
Copy link
Contributor

Centril commented Nov 7, 2019

Thanks for persevering!

r=me when CI is green

@tmiasko
Copy link
Contributor Author

tmiasko commented Nov 7, 2019

I amended the PR description, to avoid closing the issue, since there are still 307 tests left.

@Centril
Copy link
Contributor

Centril commented Nov 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit e88db92 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 7, 2019
@Centril
Rollup merge of rust-lang#66087 - tmiasko:ui-mode, r=Centril
a96811e 
Update some build-pass ui tests to use check-pass where applicable

Helps with issue rust-lang#62277.
@Centril Centril mentioned this pull request Nov 7, 2019
Merged
bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #66189 - Centril:rollup-3bsf45s, r=Centril
3f0f2bf 
Rollup of 5 pull requests

Successful merges:

 - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore)
 - #64696 ([rustdoc] add sub settings)
 - #65916 (syntax: move stuff around)
 - #66087 (Update some build-pass ui tests to use check-pass where applicable)
 - #66182 (invalid_value lint: fix help text)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #66189 - Centril:rollup-3bsf45s, r=Centril
e8f43b7 
Rollup of 5 pull requests

Successful merges:

 - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore)
 - #64696 ([rustdoc] add sub settings)
 - #65916 (syntax: move stuff around)
 - #66087 (Update some build-pass ui tests to use check-pass where applicable)
 - #66182 (invalid_value lint: fix help text)

Failed merges:

r? @ghost
@bors bors merged commit e88db92 into rust-lang:master Nov 8, 2019
@tmiasko tmiasko deleted the ui-mode branch February 27, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

@Centril Centril Centril left review comments

@davidtwco davidtwco davidtwco left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tmiasko @rust-highfive @alexcrichton @Centril @bors @davidtwco @Mark-Simulacrum