Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record temporary static references in generator witnesses #66793

Merged
merged 2 commits into from
Nov 30, 2019

Conversation

matthewjasper
Copy link
Contributor

Closes #66695

  • Record the pointer to static's type in MIR.
  • Normalize the static's type (so that constants can be compared correctly).

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2019
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 26, 2019

📌 Commit 1f850f6 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-27T19:03:05.1877640Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-27T19:03:05.2098403Z ##[command]git config gc.auto 0
2019-11-27T19:03:05.2208410Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-27T19:03:05.2255635Z ##[command]git config --get-all http.proxy
2019-11-27T19:03:05.9314806Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66793/merge:refs/remotes/pull/66793/merge
---
2019-11-27T19:08:56.0809884Z    Compiling serde_json v1.0.40
2019-11-27T19:08:57.7409243Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-11-27T19:09:09.1928309Z     Finished release [optimized] target(s) in 1m 27s
2019-11-27T19:09:09.2020968Z tidy check
2019-11-27T19:09:09.6675806Z tidy error: /checkout/src/test/ui/async-await/issues/issue-66695-static-refs.rs: empty file
2019-11-27T19:09:09.6676163Z tidy error: /checkout/src/test/ui/async-await/issues/issue-66695-static-refs.rs: leading newline
2019-11-27T19:09:11.9530948Z some tidy checks failed
2019-11-27T19:09:11.9532438Z Found 486 error codes
2019-11-27T19:09:11.9532492Z Found 0 error codes with no tests
2019-11-27T19:09:11.9532560Z Done!
2019-11-27T19:09:11.9532560Z Done!
2019-11-27T19:09:11.9532591Z 
2019-11-27T19:09:11.9532617Z 
2019-11-27T19:09:11.9533493Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-27T19:09:11.9533620Z 
2019-11-27T19:09:11.9533646Z 
2019-11-27T19:09:11.9546861Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-27T19:09:11.9547208Z Build completed unsuccessfully in 0:01:31
2019-11-27T19:09:11.9547208Z Build completed unsuccessfully in 0:01:31
2019-11-27T19:09:11.9599788Z == clock drift check ==
2019-11-27T19:09:11.9611106Z   local time: Wed Nov 27 19:09:11 UTC 2019
2019-11-27T19:09:12.5009497Z   network time: Wed, 27 Nov 2019 19:09:12 GMT
2019-11-27T19:09:12.5013699Z == end clock drift check ==
2019-11-27T19:09:13.8969159Z 
2019-11-27T19:09:13.9082422Z ##[error]Bash exited with code '1'.
2019-11-27T19:09:13.9112661Z ##[section]Starting: Checkout
2019-11-27T19:09:13.9114497Z ==============================================================================
2019-11-27T19:09:13.9114569Z Task         : Get sources
2019-11-27T19:09:13.9114615Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matthewjasper
Copy link
Contributor Author

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Nov 27, 2019

📌 Commit df625bd has been approved by cramertj

RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 29, 2019
…=cramertj

Record temporary static references in generator witnesses

Closes rust-lang#66695

* Record the pointer to static's type in MIR.
* Normalize the static's type (so that constants can be compared correctly).
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 29, 2019
…=cramertj

Record temporary static references in generator witnesses

Closes rust-lang#66695

* Record the pointer to static's type in MIR.
* Normalize the static's type (so that constants can be compared correctly).
bors added a commit that referenced this pull request Nov 29, 2019
Rollup of 11 pull requests

Successful merges:

 - #66379 (Rephrase docs in for ptr)
 - #66589 (Draw vertical lines correctly in compiler error messages)
 - #66613 (Allow customising ty::TraitRef's printing behavior)
 - #66766 (Panic machinery comments and tweaks)
 - #66791 (Handle GlobalCtxt directly from librustc_interface query system)
 - #66793 (Record temporary static references in generator witnesses)
 - #66808 (Cleanup error code)
 - #66826 (Clarifies how to tag users for assigning PRs)
 - #66837 (Clarify `{f32,f64}::EPSILON` docs)
 - #66844 (Miri: do not consider memory allocated by caller_location leaked)
 - #66872 (Minor documentation fix)

Failed merges:

r? @ghost
@bors bors merged commit df625bd into rust-lang:master Nov 30, 2019
@matthewjasper matthewjasper deleted the record-static-refs branch November 30, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken MIR after compiler update when indexing statics with async values
4 participants