Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak errors for missing associated types and type parameters #67268

Merged
merged 10 commits into from Dec 26, 2019

Conversation

@estebank
Copy link
Contributor

estebank commented Dec 12, 2019

  • On dyn Trait missing associated types, provide a structured suggestion for them
  • On missing type parameters, provide structured suggestion for them
  • Point at trait definition when missing required type parameter
  • Tweak output of E0658
  • Tweak wording of E0719
  • Account for Trait1 + Trait2 case

Fix #66380, fix #60595. CC #63711.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 12, 2019

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

--> $DIR/issue-28344.rs:4:17
|
LL | let x: u8 = BitXor::bitor(0 as u8, 0 as u8);
| ^^^^^^^^^^^^^ associated type `Output` must be specified
| ^^^^^^ help: specify the associated type: `BitXor<Output = Type>`

This comment has been minimized.

Copy link
@estebank

estebank Dec 12, 2019

Author Contributor

This is the case I'm protecting against when figuring out that there's a path with only one segment in the trait ref.

LL | / pub trait Bar<X=usize, A=Self> {
LL | | fn foo(&self);
LL | | }
| |_- type parameter `A` must be specified for this
...
LL | let e = Bar::<usize>::lol();
| ^^^ missing reference to `A`
Comment on lines +28 to +34

This comment has been minimized.

Copy link
@estebank

estebank Dec 12, 2019

Author Contributor

This is the case I'm protecting against when making sure that the path segment has no args being set.

@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Dec 12, 2019

Colorized output of test case in #66380:

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 12, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-12T23:28:45.3608081Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-12T23:28:45.3623779Z ##[command]git config gc.auto 0
2019-12-12T23:28:45.3628333Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-12T23:28:45.3630168Z ##[command]git config --get-all http.proxy
2019-12-12T23:28:45.3634482Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67268/merge:refs/remotes/pull/67268/merge
---
2019-12-12T23:34:14.0196957Z    Compiling serde_json v1.0.40
2019-12-12T23:34:15.5611356Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-12T23:34:25.3952105Z     Finished release [optimized] target(s) in 1m 18s
2019-12-12T23:34:25.4036757Z tidy check
2019-12-12T23:34:25.9176817Z tidy error: /checkout/src/test/ui/associated-type/associated-type-projection-from-multiple-supertraits.rs:23: TODO is deprecated; use FIXME
2019-12-12T23:34:26.3503271Z tidy error: /checkout/src/librustc_typeck/astconv.rs:1298: line longer than 100 chars
2019-12-12T23:34:27.7884712Z some tidy checks failed
2019-12-12T23:34:27.7886249Z Found 485 error codes
2019-12-12T23:34:27.7886521Z Found 0 error codes with no tests
2019-12-12T23:34:27.7886756Z Done!
2019-12-12T23:34:27.7886756Z Done!
2019-12-12T23:34:27.7887023Z 
2019-12-12T23:34:27.7887207Z 
2019-12-12T23:34:27.7888505Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-12T23:34:27.7889060Z 
2019-12-12T23:34:27.7889392Z 
2019-12-12T23:34:27.7891533Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-12T23:34:27.7892011Z Build completed unsuccessfully in 0:01:21
2019-12-12T23:34:27.7892011Z Build completed unsuccessfully in 0:01:21
2019-12-12T23:34:27.7940987Z == clock drift check ==
2019-12-12T23:34:27.7955922Z   local time: Thu Dec 12 23:34:27 UTC 2019
2019-12-12T23:34:28.0731318Z   network time: Thu, 12 Dec 2019 23:34:28 GMT
2019-12-12T23:34:28.0736134Z == end clock drift check ==
2019-12-12T23:34:29.4119357Z 
2019-12-12T23:34:29.4207266Z ##[error]Bash exited with code '1'.
2019-12-12T23:34:29.4237084Z ##[section]Starting: Checkout
2019-12-12T23:34:29.4238492Z ==============================================================================
2019-12-12T23:34:29.4238544Z Task         : Get sources
2019-12-12T23:34:29.4238581Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:assoc-types branch from 0c037e0 to 2c923df Dec 12, 2019
src/librustc_typeck/astconv.rs Outdated Show resolved Hide resolved
src/librustc_typeck/astconv.rs Outdated Show resolved Hide resolved
src/librustc_typeck/astconv.rs Outdated Show resolved Hide resolved
src/librustc_typeck/astconv.rs Outdated Show resolved Hide resolved
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 13, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-13T05:16:11.3928506Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-13T05:16:11.4154377Z ##[command]git config gc.auto 0
2019-12-13T05:16:11.4240956Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-13T05:16:11.4279734Z ##[command]git config --get-all http.proxy
2019-12-13T05:16:11.4538070Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67268/merge:refs/remotes/pull/67268/merge
---
2019-12-13T05:22:25.2692594Z    Compiling serde_json v1.0.40
2019-12-13T05:22:27.1627362Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-13T05:22:39.6109563Z     Finished release [optimized] target(s) in 1m 37s
2019-12-13T05:22:39.6223915Z tidy check
2019-12-13T05:22:39.9411750Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0222.md:45: line longer than 80 chars
2019-12-13T05:22:42.7330970Z Found 486 error codes
2019-12-13T05:22:42.7334155Z Found 0 error codes with no tests
2019-12-13T05:22:42.7334278Z Done!
2019-12-13T05:22:42.7338981Z some tidy checks failed
2019-12-13T05:22:42.7338981Z some tidy checks failed
2019-12-13T05:22:42.7352845Z 
2019-12-13T05:22:42.7352958Z 
2019-12-13T05:22:42.7354359Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-13T05:22:42.7355026Z 
2019-12-13T05:22:42.7355078Z 
2019-12-13T05:22:42.7372370Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-13T05:22:42.7372445Z Build completed unsuccessfully in 0:01:41
2019-12-13T05:22:42.7372445Z Build completed unsuccessfully in 0:01:41
2019-12-13T05:22:42.7461428Z == clock drift check ==
2019-12-13T05:22:42.7506767Z   local time: Fri Dec 13 05:22:42 UTC 2019
2019-12-13T05:22:43.0299867Z   network time: Fri, 13 Dec 2019 05:22:43 GMT
2019-12-13T05:22:43.0302748Z == end clock drift check ==
2019-12-13T05:22:44.3836961Z 
2019-12-13T05:22:44.3918244Z ##[error]Bash exited with code '1'.
2019-12-13T05:22:44.3955469Z ##[section]Starting: Checkout
2019-12-13T05:22:44.3957446Z ==============================================================================
2019-12-13T05:22:44.3957499Z Task         : Get sources
2019-12-13T05:22:44.3957541Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:assoc-types branch from 0d4e2c9 to 6563089 Dec 13, 2019
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 13, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-13T16:25:02.1486287Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-13T16:25:02.1509316Z ##[command]git config gc.auto 0
2019-12-13T16:25:02.1515609Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-13T16:25:02.1519310Z ##[command]git config --get-all http.proxy
2019-12-13T16:25:02.1522442Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67268/merge:refs/remotes/pull/67268/merge
---
2019-12-13T17:26:00.2958099Z .................................................................................................... 1600/9366
2019-12-13T17:26:04.6270982Z .................................................................................................... 1700/9366
2019-12-13T17:26:16.9739644Z ................................................................i................................... 1800/9366
2019-12-13T17:26:24.7423884Z .................................................................................................... 1900/9366
2019-12-13T17:26:39.8339347Z .................................................iiiii.............................................. 2000/9366
2019-12-13T17:26:50.0582165Z .................................................................................................... 2200/9366
2019-12-13T17:26:52.4304746Z .................................................................................................... 2300/9366
2019-12-13T17:26:55.7168410Z .................................................................................................... 2400/9366
2019-12-13T17:27:18.0567091Z .................................................................................................... 2500/9366
---
2019-12-13T17:29:48.0316719Z .................................................................................................... 4700/9366
2019-12-13T17:29:53.1063525Z .........................................................i...............i.......................... 4800/9366
2019-12-13T17:30:00.7557277Z .................................................................................................... 4900/9366
2019-12-13T17:30:09.1258867Z .................................................................................................... 5000/9366
2019-12-13T17:30:14.2359381Z .i.................................................................................................. 5100/9366
2019-12-13T17:30:24.4883735Z ...................................................................ii.ii...........i................ 5200/9366
2019-12-13T17:30:33.1106896Z ...i................................................................................................ 5400/9366
2019-12-13T17:30:43.3828099Z .................................................................................................... 5500/9366
2019-12-13T17:30:49.5973202Z .................................................i.................................................. 5600/9366
2019-12-13T17:30:56.7038310Z .................................................................................................... 5700/9366
2019-12-13T17:30:56.7038310Z .................................................................................................... 5700/9366
2019-12-13T17:31:07.1826728Z .................................................................................................... 5800/9366
2019-12-13T17:31:17.0097351Z .....................................ii...i..ii...........i......................................... 5900/9366
2019-12-13T17:31:35.9038952Z .................................................................................................... 6100/9366
2019-12-13T17:31:44.1614470Z .................................................................................................... 6200/9366
2019-12-13T17:31:44.1614470Z .................................................................................................... 6200/9366
2019-12-13T17:31:50.4503609Z .............................................................i..ii.................................. 6300/9366
2019-12-13T17:32:18.3960319Z .................................................................................................... 6500/9366
2019-12-13T17:32:20.3999583Z .................................i.................................................................. 6600/9366
2019-12-13T17:32:22.6466377Z .................................................................................................... 6700/9366
2019-12-13T17:32:25.0004769Z .........................i.......................................................................... 6800/9366
---
2019-12-13T17:34:02.9608785Z .................................................................................................... 7400/9366
2019-12-13T17:34:07.8728581Z .................................................................................................... 7500/9366
2019-12-13T17:34:14.5421804Z .................................................................................................... 7600/9366
2019-12-13T17:34:22.8814904Z .................................................................................................... 7700/9366
2019-12-13T17:34:30.9359659Z ............................................iiii.................................................... 7800/9366
2019-12-13T17:34:45.4776647Z .................................................................................................... 8000/9366
2019-12-13T17:34:54.0005412Z .................................................................................................... 8100/9366
2019-12-13T17:35:07.7256982Z .................................................................................................... 8200/9366
2019-12-13T17:35:15.9685356Z .................................................................................................... 8300/9366
---
2019-12-13T17:37:11.8360620Z diff of stderr:
2019-12-13T17:37:11.8360821Z 
2019-12-13T17:37:11.8361351Z 2   --> $DIR/unboxed-closure-sugar-not-used-on-fn.rs:3:17
2019-12-13T17:37:11.8361678Z 3    |
2019-12-13T17:37:11.8362516Z 4 LL | fn bar1(x: &dyn Fn<(), Output=()>) {
2019-12-13T17:37:11.8363563Z +    |                 ^^ help: use parenthetical notation instead: `Fn() -> ()`
2019-12-13T17:37:11.8363821Z 6    |
2019-12-13T17:37:11.8363821Z 6    |
2019-12-13T17:37:11.8364491Z 7    = note: for more information, see ***/issues/29625
2019-12-13T17:37:11.8364778Z 8    = help: add `#![feature(unboxed_closures)]` to the crate attributes to enable
2019-12-13T17:37:11.8364989Z 
2019-12-13T17:37:11.8365623Z -    = help: use parenthetical notation instead: `Fn(Foo, Bar) -> Baz`
2019-12-13T17:37:11.8366126Z 10 
2019-12-13T17:37:11.8366662Z 11 error[E0658]: the precise format of `Fn`-family traits' type parameters is subject to change
2019-12-13T17:37:11.8367573Z 
2019-12-13T17:37:11.8367798Z 13    |
2019-12-13T17:37:11.8367798Z 13    |
2019-12-13T17:37:11.8367995Z 14 LL | fn bar2<T>(x: &T) where T: Fn<()> {
2019-12-13T17:37:11.8368997Z +    |                            ^^ help: use parenthetical notation instead: `Fn() -> ()`
2019-12-13T17:37:11.8369255Z 16    |
2019-12-13T17:37:11.8369255Z 16    |
2019-12-13T17:37:11.8369789Z 17    = note: for more information, see ***/issues/29625
2019-12-13T17:37:11.8370068Z 18    = help: add `#![feature(unboxed_closures)]` to the crate attributes to enable
2019-12-13T17:37:11.8370250Z 
2019-12-13T17:37:11.8370725Z -    = help: use parenthetical notation instead: `Fn(Foo, Bar) -> Baz`
2019-12-13T17:37:11.8371179Z 21 error: aborting due to 2 previous errors
2019-12-13T17:37:11.8371801Z 22 
2019-12-13T17:37:11.8372015Z 
2019-12-13T17:37:11.8372189Z 
2019-12-13T17:37:11.8372189Z 
2019-12-13T17:37:11.8372386Z The actual stderr differed from the expected stderr.
2019-12-13T17:37:11.8373035Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unboxed-closures/unboxed-closure-sugar-not-used-on-fn/unboxed-closure-sugar-not-used-on-fn.stderr
2019-12-13T17:37:11.8373583Z To update references, rerun the tests and pass the `--bless` flag
2019-12-13T17:37:11.8374188Z To only update this specific test, also pass `--test-args unboxed-closures/unboxed-closure-sugar-not-used-on-fn.rs`
2019-12-13T17:37:11.8374641Z error: 1 errors occurred comparing output.
2019-12-13T17:37:11.8374864Z status: exit code: 1
2019-12-13T17:37:11.8374864Z status: exit code: 1
2019-12-13T17:37:11.8376345Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/unboxed-closures/unboxed-closure-sugar-not-used-on-fn.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unboxed-closures/unboxed-closure-sugar-not-used-on-fn" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unboxed-closures/unboxed-closure-sugar-not-used-on-fn/auxiliary" "-A" "unused"
2019-12-13T17:37:11.8377141Z ------------------------------------------
2019-12-13T17:37:11.8377403Z 
2019-12-13T17:37:11.8377853Z ------------------------------------------
2019-12-13T17:37:11.8378108Z stderr:
2019-12-13T17:37:11.8378108Z stderr:
2019-12-13T17:37:11.8378566Z ------------------------------------------
2019-12-13T17:37:11.8379113Z error[E0658]: the precise format of `Fn`-family traits' type parameters is subject to change
2019-12-13T17:37:11.8379946Z    |
2019-12-13T17:37:11.8379946Z    |
2019-12-13T17:37:11.8380171Z LL | fn bar1(x: &dyn Fn<(), Output=()>) {
2019-12-13T17:37:11.8380681Z    |                 ^^ help: use parenthetical notation instead: `Fn() -> ()`
2019-12-13T17:37:11.8380948Z    |
2019-12-13T17:37:11.8381757Z    = note: for more information, see ***/issues/29625
2019-12-13T17:37:11.8382140Z    = help: add `#![feature(unboxed_closures)]` to the crate attributes to enable
2019-12-13T17:37:11.8382350Z 
2019-12-13T17:37:11.8382927Z error[E0658]: the precise format of `Fn`-family traits' type parameters is subject to change
2019-12-13T17:37:11.8383817Z    |
2019-12-13T17:37:11.8383817Z    |
2019-12-13T17:37:11.8384049Z LL | fn bar2<T>(x: &T) where T: Fn<()> {
2019-12-13T17:37:11.8386827Z    |                            ^^ help: use parenthetical notation instead: `Fn() -> ()`
2019-12-13T17:37:11.8386937Z    |
2019-12-13T17:37:11.8387355Z    = note: for more information, see ***/issues/29625
2019-12-13T17:37:11.8387589Z    = help: add `#![feature(unboxed_closures)]` to the crate attributes to enable
2019-12-13T17:37:11.8387764Z error: aborting due to 2 previous errors
2019-12-13T17:37:11.8387804Z 
2019-12-13T17:37:11.8388137Z For more information about this error, try `rustc --explain E0658`.
2019-12-13T17:37:11.8388175Z 
---
2019-12-13T17:37:11.8393752Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-13T17:37:11.8393833Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-13T17:37:11.8401566Z 
2019-12-13T17:37:11.8402049Z 
2019-12-13T17:37:11.8403808Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-13T17:37:11.8404073Z 
2019-12-13T17:37:11.8404105Z 
2019-12-13T17:37:11.8404153Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-13T17:37:11.8404204Z Build completed unsuccessfully in 1:06:02
2019-12-13T17:37:11.8404204Z Build completed unsuccessfully in 1:06:02
2019-12-13T17:37:11.8458140Z == clock drift check ==
2019-12-13T17:37:11.8473814Z   local time: Fri Dec 13 17:37:11 UTC 2019
2019-12-13T17:37:12.3940855Z   network time: Fri, 13 Dec 2019 17:37:12 GMT
2019-12-13T17:37:12.3945303Z == end clock drift check ==
2019-12-13T17:37:13.2226006Z 
2019-12-13T17:37:13.2286846Z ##[error]Bash exited with code '1'.
2019-12-13T17:37:13.2329124Z ##[section]Starting: Checkout
2019-12-13T17:37:13.2330848Z ==============================================================================
2019-12-13T17:37:13.2330922Z Task         : Get sources
2019-12-13T17:37:13.2330967Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:assoc-types branch from 6563089 to 30e0a0d Dec 13, 2019
@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Dec 13, 2019

Blasting @rust-lang/wg-diagnostics for feedback

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 13, 2019

From a purely .stderr POV, this seems like a good improvement. From a happy-code-path POV, the diagnostics are well isolated so readability should not suffer. 👍 overall.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 18, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-18T02:16:03.1945755Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-18T02:16:03.2160983Z ##[command]git config gc.auto 0
2019-12-18T02:16:03.2212793Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-18T02:16:03.2266305Z ##[command]git config --get-all http.proxy
2019-12-18T02:16:03.2394048Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67268/merge:refs/remotes/pull/67268/merge
---
2019-12-18T02:21:43.8955227Z    Compiling serde_json v1.0.40
2019-12-18T02:21:45.1784024Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-18T02:21:54.6523072Z     Finished release [optimized] target(s) in 1m 14s
2019-12-18T02:21:54.6603987Z tidy check
2019-12-18T02:21:55.5154215Z tidy error: /checkout/src/librustc_typeck/astconv.rs:1585: trailing whitespace
2019-12-18T02:21:55.5154581Z tidy error: /checkout/src/librustc_typeck/astconv.rs:1588: trailing whitespace
2019-12-18T02:21:55.5154686Z tidy error: /checkout/src/librustc_typeck/astconv.rs:1654: line longer than 100 chars
2019-12-18T02:21:56.8688315Z some tidy checks failed
2019-12-18T02:21:56.8688408Z Found 486 error codes
2019-12-18T02:21:56.8688443Z Found 0 error codes with no tests
2019-12-18T02:21:56.8688476Z Done!
2019-12-18T02:21:56.8688476Z Done!
2019-12-18T02:21:56.8688518Z 
2019-12-18T02:21:56.8688540Z 
2019-12-18T02:21:56.8689606Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-18T02:21:56.8689723Z 
2019-12-18T02:21:56.8689744Z 
2019-12-18T02:21:56.8692781Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-18T02:21:56.8693052Z Build completed unsuccessfully in 0:01:18
2019-12-18T02:21:56.8693052Z Build completed unsuccessfully in 0:01:18
2019-12-18T02:21:56.8739603Z == clock drift check ==
2019-12-18T02:21:56.8747832Z   local time: Wed Dec 18 02:21:56 UTC 2019
2019-12-18T02:21:57.0349702Z   network time: Wed, 18 Dec 2019 02:21:57 GMT
2019-12-18T02:21:57.0351700Z == end clock drift check ==
2019-12-18T02:21:59.0407853Z 
2019-12-18T02:21:59.0505244Z ##[error]Bash exited with code '1'.
2019-12-18T02:21:59.0527873Z ##[section]Starting: Checkout
2019-12-18T02:21:59.0529273Z ==============================================================================
2019-12-18T02:21:59.0529334Z Task         : Get sources
2019-12-18T02:21:59.0529371Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank estebank force-pushed the estebank:assoc-types branch 3 times, most recently from 8e712a0 to dab3906 Dec 18, 2019
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2019

📌 Commit 60cfff6 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2019

⌛️ Testing commit 60cfff6 with merge a0ba6f6...

bors added a commit that referenced this pull request Dec 25, 2019
Tweak errors for missing associated types and type parameters

* On `dyn Trait` missing associated types, provide a structured suggestion for them
* On missing type parameters, provide structured suggestion for them
* Point at trait definition when missing required type parameter
* Tweak output of E0658
* Tweak wording of E0719
* Account for `Trait1 + Trait2` case

Fix #66380, fix #60595. CC #63711.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 25, 2019

The job i686-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-25T08:30:23.6355310Z diff of stderr:
2019-12-25T08:30:23.6355420Z 
2019-12-25T08:30:23.6355520Z 10    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6355640Z 11 
2019-12-25T08:30:23.6355790Z 12 error[E0191]: the value of the associated types `A` (from trait `Y`), `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Mul`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6357320Z +   --> $DIR/missing-associated-types.rs:12:32
2019-12-25T08:30:23.6357650Z 14    |
2019-12-25T08:30:23.6358050Z 15 LL |     type A;
2019-12-25T08:30:23.6358880Z 16    |     ------- `A` defined here
2019-12-25T08:30:23.6358880Z 16    |     ------- `A` defined here
2019-12-25T08:30:23.6359170Z 
2019-12-25T08:30:23.6359340Z 39    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6359440Z 40 
2019-12-25T08:30:23.6359630Z 41 error[E0191]: the value of the associated types `A` (from trait `Z`), `B` (from trait `Z`), `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Div`), `Output` (from trait `std::ops::Div`), `Output` (from trait `std::ops::Mul`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6361190Z +   --> $DIR/missing-associated-types.rs:15:52
2019-12-25T08:30:23.6361560Z 43    |
2019-12-25T08:30:23.6361670Z 44 LL |     type A;
2019-12-25T08:30:23.6362250Z 45    |     ------- `A` defined here
2019-12-25T08:30:23.6362250Z 45    |     ------- `A` defined here
2019-12-25T08:30:23.6362540Z 
2019-12-25T08:30:23.6362710Z 75    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6362840Z 76 
2019-12-25T08:30:23.6362980Z 77 error[E0191]: the value of the associated types `A` (from trait `Y`), `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6364440Z +   --> $DIR/missing-associated-types.rs:18:43
2019-12-25T08:30:23.6364770Z 79    |
2019-12-25T08:30:23.6364900Z 80 LL |     type A;
2019-12-25T08:30:23.6365470Z 81    |     ------- `A` defined here
2019-12-25T08:30:23.6365470Z 81    |     ------- `A` defined here
2019-12-25T08:30:23.6365760Z 
2019-12-25T08:30:23.6365910Z 103    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6366030Z 104 
2019-12-25T08:30:23.6366600Z 105 error[E0191]: the value of the associated types `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6368070Z +   --> $DIR/missing-associated-types.rs:21:21
2019-12-25T08:30:23.6368410Z 107    |
2019-12-25T08:30:23.6368410Z 107    |
2019-12-25T08:30:23.6368550Z 108 LL | type Bat<Rhs> = dyn Add<Rhs> + Sub<Rhs> + Fine<Rhs>;
2019-12-25T08:30:23.6368680Z 109    |                     ^^^^^^^^   ^^^^^^^^ associated type `Output` must be specified
2019-12-25T08:30:23.6368830Z 
2019-12-25T08:30:23.6368940Z The actual stderr differed from the expected stderr.
2019-12-25T08:30:23.6369680Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/associated-types/missing-associated-types/missing-associated-types.stderr
2019-12-25T08:30:23.6369680Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/associated-types/missing-associated-types/missing-associated-types.stderr
2019-12-25T08:30:23.6370520Z To update references, rerun the tests and pass the `--bless` flag
2019-12-25T08:30:23.6371410Z To only update this specific test, also pass `--test-args associated-types/missing-associated-types.rs`
2019-12-25T08:30:23.6371860Z error: 1 errors occurred comparing output.
2019-12-25T08:30:23.6371960Z status: exit code: 1
2019-12-25T08:30:23.6371960Z status: exit code: 1
2019-12-25T08:30:23.6373430Z command: "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui/associated-types/missing-associated-types.rs" "-Zthreads=1" "--target=i686-apple-darwin" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/associated-types/missing-associated-types" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/associated-types/missing-associated-types/auxiliary" "-A" "unused"
2019-12-25T08:30:23.6374660Z ------------------------------------------
2019-12-25T08:30:23.6374950Z 
2019-12-25T08:30:23.6375580Z ------------------------------------------
2019-12-25T08:30:23.6376070Z stderr:
2019-12-25T08:30:23.6376070Z stderr:
2019-12-25T08:30:23.6376880Z ------------------------------------------
2019-12-25T08:30:23.6377240Z error[E0225]: only auto traits can be used as additional traits in a trait object
2019-12-25T08:30:23.6377940Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/associated-types/missing-associated-types.rs:12:32
2019-12-25T08:30:23.6378310Z    |
2019-12-25T08:30:23.6378450Z LL | type Foo<Rhs> = dyn Add<Rhs> + Sub<Rhs> + X<Rhs> + Y<Rhs>;
2019-12-25T08:30:23.6379030Z    |                     --------   ^^^^^^^^
2019-12-25T08:30:23.6380000Z    |                     |          additional non-auto trait
2019-12-25T08:30:23.6380380Z    |                     |          trait alias used in trait object type (additional use)
2019-12-25T08:30:23.6381010Z    |                     first non-auto trait
2019-12-25T08:30:23.6381350Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6381350Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6381480Z 
2019-12-25T08:30:23.6388050Z error[E0191]: the value of the associated types `A` (from trait `Y`), `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Mul`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6389240Z    |
2019-12-25T08:30:23.6389370Z LL |     type A;
2019-12-25T08:30:23.6389940Z    |     ------- `A` defined here
2019-12-25T08:30:23.6390290Z ...
2019-12-25T08:30:23.6390290Z ...
2019-12-25T08:30:23.6390870Z LL | type Foo<Rhs> = dyn Add<Rhs> + Sub<Rhs> + X<Rhs> + Y<Rhs>;
2019-12-25T08:30:23.6391000Z    |                     ^^^^^^^^   ^^^^^^^^   ^^^^^^   ^^^^^^ associated type `A` must be specified
2019-12-25T08:30:23.6391440Z    |                     |          |          |
2019-12-25T08:30:23.6391590Z    |                     |          |          associated type `Output` must be specified
2019-12-25T08:30:23.6392040Z    |                     |          associated type `Output` must be specified
2019-12-25T08:30:23.6392440Z    |                     associated type `Output` must be specified
2019-12-25T08:30:23.6392600Z help: specify the associated types
2019-12-25T08:30:23.6392670Z    |
2019-12-25T08:30:23.6392670Z    |
2019-12-25T08:30:23.6392760Z LL | type Foo<Rhs> = dyn Add<Rhs, Output = Type> + Sub<Rhs, Output = Type> + X<Rhs, Output = Type> + Y<Rhs, A = Type>;
2019-12-25T08:30:23.6392940Z 
2019-12-25T08:30:23.6393330Z error[E0225]: only auto traits can be used as additional traits in a trait object
2019-12-25T08:30:23.6394270Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/associated-types/missing-associated-types.rs:15:32
2019-12-25T08:30:23.6394380Z    |
2019-12-25T08:30:23.6394380Z    |
2019-12-25T08:30:23.6394460Z LL | type Bar<Rhs> = dyn Add<Rhs> + Sub<Rhs> + X<Rhs> + Z<Rhs>;
2019-12-25T08:30:23.6395020Z    |                     --------   ^^^^^^^^
2019-12-25T08:30:23.6395660Z    |                     |          additional non-auto trait
2019-12-25T08:30:23.6395770Z    |                     |          trait alias used in trait object type (additional use)
2019-12-25T08:30:23.6396310Z    |                     first non-auto trait
2019-12-25T08:30:23.6396410Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6396410Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6396470Z 
2019-12-25T08:30:23.6396620Z error[E0191]: the value of the associated types `A` (from trait `Z`), `B` (from trait `Z`), `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Div`), `Output` (from trait `std::ops::Div`), `Output` (from trait `std::ops::Mul`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6397620Z    |
2019-12-25T08:30:23.6397730Z LL |     type A;
2019-12-25T08:30:23.6398280Z    |     ------- `A` defined here
2019-12-25T08:30:23.6398370Z LL |     type B;
2019-12-25T08:30:23.6398370Z LL |     type B;
2019-12-25T08:30:23.6398880Z    |     ------- `B` defined here
2019-12-25T08:30:23.6398960Z ...
2019-12-25T08:30:23.6399030Z LL | type Bar<Rhs> = dyn Add<Rhs> + Sub<Rhs> + X<Rhs> + Z<Rhs>;
2019-12-25T08:30:23.6399130Z    |                     ^^^^^^^^   ^^^^^^^^   ^^^^^^   ^^^^^^ associated types `A`, `B`, `Output` must be specified
2019-12-25T08:30:23.6399240Z    |                     |          |          |
2019-12-25T08:30:23.6399360Z    |                     |          |          associated types `Output` (from trait `std::ops::Mul`), `Output` (from trait `std::ops::Div`) must be specified
2019-12-25T08:30:23.6399480Z    |                     |          associated type `Output` must be specified
2019-12-25T08:30:23.6399580Z    |                     associated type `Output` must be specified
2019-12-25T08:30:23.6399650Z    |
2019-12-25T08:30:23.6400290Z help: consider introducing a new type parameter, adding `where` constraints using the fully-qualified path to the associated types
2019-12-25T08:30:23.6401030Z    |
2019-12-25T08:30:23.6401030Z    |
2019-12-25T08:30:23.6401100Z LL | type Bar<Rhs> = dyn Add<Rhs> + Sub<Rhs> + X<Rhs> + Z<Rhs>;
2019-12-25T08:30:23.6401260Z help: specify the associated types
2019-12-25T08:30:23.6401320Z    |
2019-12-25T08:30:23.6401320Z    |
2019-12-25T08:30:23.6401420Z LL | type Bar<Rhs> = dyn Add<Rhs, Output = Type> + Sub<Rhs, Output = Type> + X<Rhs> + Z<Rhs, A = Type, B = Type, Output = Type>;
2019-12-25T08:30:23.6401840Z 
2019-12-25T08:30:23.6401920Z error[E0225]: only auto traits can be used as additional traits in a trait object
2019-12-25T08:30:23.6402570Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/associated-types/missing-associated-types.rs:18:32
2019-12-25T08:30:23.6402680Z    |
2019-12-25T08:30:23.6402680Z    |
2019-12-25T08:30:23.6402750Z LL | type Baz<Rhs> = dyn Add<Rhs> + Sub<Rhs> + Y<Rhs>;
2019-12-25T08:30:23.6403280Z    |                     --------   ^^^^^^^^
2019-12-25T08:30:23.6403910Z    |                     |          additional non-auto trait
2019-12-25T08:30:23.6404020Z    |                     |          trait alias used in trait object type (additional use)
2019-12-25T08:30:23.6404560Z    |                     first non-auto trait
2019-12-25T08:30:23.6404670Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6404670Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6404730Z 
2019-12-25T08:30:23.6405270Z error[E0191]: the value of the associated types `A` (from trait `Y`), `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6406370Z    |
2019-12-25T08:30:23.6406490Z LL |     type A;
2019-12-25T08:30:23.6407060Z    |     ------- `A` defined here
2019-12-25T08:30:23.6407140Z ...
2019-12-25T08:30:23.6407140Z ...
2019-12-25T08:30:23.6407480Z LL | type Baz<Rhs> = dyn Add<Rhs> + Sub<Rhs> + Y<Rhs>;
2019-12-25T08:30:23.6407640Z    |                     ^^^^^^^^   ^^^^^^^^   ^^^^^^ associated type `A` must be specified
2019-12-25T08:30:23.6407750Z    |                     |          |
2019-12-25T08:30:23.6407870Z    |                     |          associated type `Output` must be specified
2019-12-25T08:30:23.6408000Z    |                     associated type `Output` must be specified
2019-12-25T08:30:23.6408210Z help: specify the associated types
2019-12-25T08:30:23.6408300Z    |
2019-12-25T08:30:23.6408300Z    |
2019-12-25T08:30:23.6408580Z LL | type Baz<Rhs> = dyn Add<Rhs, Output = Type> + Sub<Rhs, Output = Type> + Y<Rhs, A = Type>;
2019-12-25T08:30:23.6409100Z 
2019-12-25T08:30:23.6409210Z error[E0225]: only auto traits can be used as additional traits in a trait object
2019-12-25T08:30:23.6409900Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/associated-types/missing-associated-types.rs:21:32
2019-12-25T08:30:23.6410260Z    |
2019-12-25T08:30:23.6410260Z    |
2019-12-25T08:30:23.6410380Z LL | type Bat<Rhs> = dyn Add<Rhs> + Sub<Rhs> + Fine<Rhs>;
2019-12-25T08:30:23.6410980Z    |                     --------   ^^^^^^^^
2019-12-25T08:30:23.6411960Z    |                     |          additional non-auto trait
2019-12-25T08:30:23.6412330Z    |                     |          trait alias used in trait object type (additional use)
2019-12-25T08:30:23.6412940Z    |                     first non-auto trait
2019-12-25T08:30:23.6413310Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6413310Z    |                     trait alias used in trait object type (first use)
2019-12-25T08:30:23.6413420Z 
2019-12-25T08:30:23.6413560Z error[E0191]: the value of the associated types `Output` (from trait `std::ops::Add`), `Output` (from trait `std::ops::Sub`) must be specified
2019-12-25T08:30:23.6414620Z    |
2019-12-25T08:30:23.6414620Z    |
2019-12-25T08:30:23.6414760Z LL | type Bat<Rhs> = dyn Add<Rhs> + Sub<Rhs> + Fine<Rhs>;
2019-12-25T08:30:23.6414880Z    |                     ^^^^^^^^   ^^^^^^^^ associated type `Output` must be specified
2019-12-25T08:30:23.6415000Z    |                     |
2019-12-25T08:30:23.6415510Z    |                     associated type `Output` must be specified
2019-12-25T08:30:23.6415750Z help: specify the associated types
2019-12-25T08:30:23.6415850Z    |
2019-12-25T08:30:23.6415850Z    |
2019-12-25T08:30:23.6415980Z LL | type Bat<Rhs> = dyn Add<Rhs, Output = Type> + Sub<Rhs, Output = Type> + Fine<Rhs>;
2019-12-25T08:30:23.6416130Z 
2019-12-25T08:30:23.6416130Z 
2019-12-25T08:30:23.6416450Z error[E0191]: the value of the associated types `Output` (from trait `std::ops::Div`), `Output` (from trait `std::ops::Mul`) must be specified
2019-12-25T08:30:23.6417500Z    |
2019-12-25T08:30:23.6417500Z    |
2019-12-25T08:30:23.6417620Z LL | type Bal<Rhs> = dyn X<Rhs>;
2019-12-25T08:30:23.6417760Z    |                     ^^^^^^ associated types `Output` (from trait `std::ops::Mul`), `Output` (from trait `std::ops::Div`) must be specified
2019-12-25T08:30:23.6417870Z    |
2019-12-25T08:30:23.6418700Z    = help: consider introducing a new type parameter, adding `where` constraints using the fully-qualified path to the associated types
2019-12-25T08:30:23.6419160Z error: aborting due to 9 previous errors
2019-12-25T08:30:23.6419240Z 
2019-12-25T08:30:23.6419360Z Some errors have detailed explanations: E0191, E0225.
2019-12-25T08:30:23.6419970Z For more information about an error, try `rustc --explain E0191`.
---
2019-12-25T08:30:23.6441220Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2019-12-25T08:30:23.6441660Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-25T08:30:23.6459940Z 
2019-12-25T08:30:23.6460450Z 
2019-12-25T08:30:23.6463350Z command did not execute successfully: "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui" "--build-base" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui" "--stage-id" "stage2-i686-apple-darwin" "--mode" "ui" "--target" "i686-apple-darwin" "--host" "i686-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.42.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-25T08:30:23.6464770Z 
2019-12-25T08:30:23.6464840Z 
2019-12-25T08:30:23.6475160Z failed to run: /Users/runner/runners/2.163.1/work/1/s/build/bootstrap/debug/bootstrap test
2019-12-25T08:30:23.6475370Z Build completed unsuccessfully in 0:50:24
2019-12-25T08:30:23.6475370Z Build completed unsuccessfully in 0:50:24
2019-12-25T08:30:23.6534340Z == clock drift check ==
2019-12-25T08:30:23.6582210Z   local time: Wed Dec 25 08:30:23 UTC 2019
2019-12-25T08:30:23.7519950Z   network time: Wed, 25 Dec 2019 08:30:23 GMT
2019-12-25T08:30:23.7521580Z == end clock drift check ==
2019-12-25T08:30:23.7560740Z 
2019-12-25T08:30:23.7666020Z ##[error]Bash exited with code '1'.
2019-12-25T08:30:23.7724030Z ##[section]Starting: Checkout
2019-12-25T08:30:23.7726710Z ==============================================================================
2019-12-25T08:30:23.7726820Z Task         : Get sources
2019-12-25T08:30:23.7726890Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2019

💔 Test failed - checks-azure

@estebank estebank force-pushed the estebank:assoc-types branch from 60cfff6 to 621d7e9 Dec 25, 2019
@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Dec 25, 2019

@bors r=oli-obk fixed the last bit of non-determinism I could see

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2019

📌 Commit 621d7e9 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2019

⌛️ Testing commit 621d7e9 with merge ba2a07a...

bors added a commit that referenced this pull request Dec 25, 2019
Tweak errors for missing associated types and type parameters

* On `dyn Trait` missing associated types, provide a structured suggestion for them
* On missing type parameters, provide structured suggestion for them
* Point at trait definition when missing required type parameter
* Tweak output of E0658
* Tweak wording of E0719
* Account for `Trait1 + Trait2` case

Fix #66380, fix #60595. CC #63711.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 25, 2019

The job x86_64-msvc-cargo of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2019

💔 Test failed - checks-azure

@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Dec 26, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2019

⌛️ Testing commit 621d7e9 with merge c0b16b4...

bors added a commit that referenced this pull request Dec 26, 2019
Tweak errors for missing associated types and type parameters

* On `dyn Trait` missing associated types, provide a structured suggestion for them
* On missing type parameters, provide structured suggestion for them
* Point at trait definition when missing required type parameter
* Tweak output of E0658
* Tweak wording of E0719
* Account for `Trait1 + Trait2` case

Fix #66380, fix #60595. CC #63711.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing c0b16b4 to master...

@bors bors added the merged-by-bors label Dec 26, 2019
@bors bors merged commit 621d7e9 into rust-lang:master Dec 26, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20191225.32 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.