Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the world #67540

Merged
merged 5 commits into from Dec 23, 2019
Merged

Format the world #67540

merged 5 commits into from Dec 23, 2019

Conversation

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Dec 22, 2019

This PR modifies the formatting infrastructure a bit in the first commit (to enable the forgotten 2018 edition), as well as removes most directories from the ignore list in rustfmt.toml. It then follows that up with the second commit which runs x.py fmt and formats the entire repository.

We continue to not format the test directory (src/test) because of interactions with pretty printing and, in part, because re-blessing all of those files is somewhat harder to review, so is best suited for a follow up PR in my opinion.


Update: Instructions for resolving merge conflicts can be found in the blog post on Inside Rust. —mbrubeck

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 22, 2019

Let's do this! 🚀

r? @Centril @bors p=1337 rollup=never

@rust-highfive rust-highfive assigned Centril and unassigned varkor Dec 22, 2019
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 22, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2019

📌 Commit 4fe589e has been approved by Centril

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 22, 2019

@bors r-

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 22, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-22T21:51:18.6614234Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-22T21:51:18.6631147Z ##[command]git config gc.auto 0
2019-12-22T21:51:18.6635824Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-22T21:51:18.6640561Z ##[command]git config --get-all http.proxy
2019-12-22T21:51:18.6645658Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67540/merge:refs/remotes/pull/67540/merge
---
2019-12-22T21:57:03.5353565Z    Compiling serde_json v1.0.40
2019-12-22T21:57:05.1628810Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-22T21:57:14.6837053Z     Finished release [optimized] target(s) in 1m 16s
2019-12-22T21:57:14.6941942Z tidy check
2019-12-22T21:57:14.7959637Z tidy error: /checkout/src/tools/build-manifest/src/main.rs:637: line longer than 100 chars
2019-12-22T21:57:14.8208245Z tidy error: /checkout/src/librustc_resolve/resolve_imports.rs:62: line longer than 100 chars
2019-12-22T21:57:14.8208742Z tidy error: /checkout/src/librustc_resolve/resolve_imports.rs:257: line longer than 100 chars
2019-12-22T21:57:14.8208938Z tidy error: /checkout/src/librustc_resolve/resolve_imports.rs:286: line longer than 100 chars
2019-12-22T21:57:14.8214489Z tidy error: /checkout/src/librustc_resolve/resolve_imports.rs:1023: line longer than 100 chars
2019-12-22T21:57:14.8214770Z tidy error: /checkout/src/librustc_resolve/resolve_imports.rs:1098: line longer than 100 chars
2019-12-22T21:57:14.8214941Z tidy error: /checkout/src/librustc_resolve/resolve_imports.rs:1099: line longer than 100 chars
2019-12-22T21:57:14.8256285Z tidy error: /checkout/src/librustc_resolve/lib.rs: too many lines (3089) (add `// ignore-tidy-filelength` to the file to suppress this error)
2019-12-22T21:57:14.9033227Z tidy error: /checkout/src/libcore/iter/adapters/mod.rs:1138: line longer than 100 chars
2019-12-22T21:57:14.9060104Z tidy error: /checkout/src/libcore/iter/traits/iterator.rs:46: line longer than 100 chars
2019-12-22T21:57:14.9060180Z tidy error: /checkout/src/libcore/iter/traits/iterator.rs:59: line longer than 100 chars
2019-12-22T21:57:14.9060257Z tidy error: /checkout/src/libcore/iter/traits/iterator.rs:65: line longer than 100 chars
2019-12-22T21:57:14.9064755Z tidy error: /checkout/src/libcore/iter/traits/iterator.rs:83: line longer than 100 chars
2019-12-22T21:57:14.9076998Z tidy error: /checkout/src/libcore/iter/traits/iterator.rs: too many lines (3106) (add `// ignore-tidy-filelength` to the file to suppress this error)
2019-12-22T21:57:14.9307283Z tidy error: /checkout/src/librustc_passes/ast_validation.rs:375: line longer than 100 chars
2019-12-22T21:57:15.3196823Z tidy error: /checkout/src/libsyntax_ext/test.rs:165: line longer than 100 chars
2019-12-22T21:57:15.3513144Z tidy error: /checkout/src/librustc_codegen_llvm/debuginfo/metadata.rs:1458: line longer than 100 chars
2019-12-22T21:57:15.3545293Z tidy error: /checkout/src/librustc_codegen_llvm/back/write.rs:620: line longer than 100 chars
2019-12-22T21:57:15.3581484Z tidy error: /checkout/src/librustc_codegen_llvm/consts.rs:281: line longer than 100 chars
2019-12-22T21:57:15.3683287Z tidy error: /checkout/src/librustc_codegen_ssa/base.rs:184: line longer than 100 chars
2019-12-22T21:57:15.3725073Z tidy error: /checkout/src/librustc_codegen_ssa/mir/place.rs:338: line longer than 100 chars
2019-12-22T21:57:15.3863668Z tidy error: /checkout/src/librustc/hir/lowering.rs:1478: line longer than 100 chars
2019-12-22T21:57:15.3896540Z tidy error: /checkout/src/librustc/traits/mod.rs:524: line longer than 100 chars
2019-12-22T21:57:15.4120588Z tidy error: /checkout/src/librustc/middle/resolve_lifetime.rs: ignoring file length unnecessarily
2019-12-22T21:57:15.4242631Z tidy error: /checkout/src/librustc/ty/wf.rs:208: line longer than 100 chars
2019-12-22T21:57:15.4242739Z tidy error: /checkout/src/librustc/ty/wf.rs:250: line longer than 100 chars
2019-12-22T21:57:15.4242829Z tidy error: /checkout/src/librustc/ty/wf.rs:263: line longer than 100 chars
2019-12-22T21:57:15.4242888Z tidy error: /checkout/src/librustc/ty/wf.rs:265: line longer than 100 chars
2019-12-22T21:57:15.4242947Z tidy error: /checkout/src/librustc/ty/wf.rs:271: line longer than 100 chars
2019-12-22T21:57:15.4243022Z tidy error: /checkout/src/librustc/ty/wf.rs:278: line longer than 100 chars
2019-12-22T21:57:15.4338485Z tidy error: /checkout/src/librustc/ty/context.rs: ignoring file length unnecessarily
2019-12-22T21:57:15.4376501Z tidy error: /checkout/src/librustc/ty/constness.rs:101: line longer than 100 chars
2019-12-22T21:57:15.4376624Z tidy error: /checkout/src/librustc/ty/constness.rs:114: line longer than 100 chars
2019-12-22T21:57:15.4382035Z tidy error: /checkout/src/librustc/lint/mod.rs:538: line longer than 100 chars
2019-12-22T21:57:15.4610669Z tidy error: /checkout/src/librustc/infer/error_reporting/nice_region_error/outlives_closure.rs:76: line longer than 100 chars
2019-12-22T21:57:15.4610771Z tidy error: /checkout/src/librustc/infer/error_reporting/nice_region_error/outlives_closure.rs:93: line longer than 100 chars
2019-12-22T21:57:15.4610878Z tidy error: /checkout/src/librustc/infer/error_reporting/nice_region_error/outlives_closure.rs:97: line longer than 100 chars
2019-12-22T21:57:15.4698016Z tidy error: /checkout/src/libsyntax_expand/parse/tests.rs:68: line longer than 100 chars
2019-12-22T21:57:15.4698106Z tidy error: /checkout/src/libsyntax_expand/parse/tests.rs:73: line longer than 100 chars
2019-12-22T21:57:15.4698197Z tidy error: /checkout/src/libsyntax_expand/parse/tests.rs:78: line longer than 100 chars
2019-12-22T21:57:15.4698257Z tidy error: /checkout/src/libsyntax_expand/parse/tests.rs:84: line longer than 100 chars
2019-12-22T21:57:15.4698355Z tidy error: /checkout/src/libsyntax_expand/parse/lexer/tests.rs:133: line longer than 100 chars
2019-12-22T21:57:15.4698428Z tidy error: /checkout/src/libsyntax_expand/parse/lexer/tests.rs:142: line longer than 100 chars
2019-12-22T21:57:15.4830799Z tidy error: /checkout/src/librustc_mir/borrow_check/type_check/mod.rs:1923: line longer than 100 chars
2019-12-22T21:57:15.4830922Z tidy error: /checkout/src/librustc_mir/borrow_check/type_check/mod.rs:1928: line longer than 100 chars
2019-12-22T21:57:15.4830989Z tidy error: /checkout/src/librustc_mir/borrow_check/type_check/mod.rs:2201: line longer than 100 chars
2019-12-22T21:57:15.4913672Z tidy error: /checkout/src/librustc_mir/borrow_check/diagnostics/mutability_errors.rs:193: line longer than 100 chars
2019-12-22T21:57:15.4913798Z tidy error: /checkout/src/librustc_mir/borrow_check/diagnostics/mutability_errors.rs:230: line longer than 100 chars
2019-12-22T21:57:15.4977126Z tidy error: /checkout/src/librustc_mir/monomorphize/collector.rs:886: line longer than 100 chars
2019-12-22T21:57:15.5044475Z tidy error: /checkout/src/librustc_mir/interpret/place.rs:1090: line longer than 100 chars
2019-12-22T21:57:15.5142646Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:413: line longer than 100 chars
2019-12-22T21:57:15.5152631Z tidy error: /checkout/src/librustc_mir/build/mod.rs:43: line longer than 100 chars
2019-12-22T21:57:15.5183112Z tidy error: /checkout/src/librustc_mir/build/matches/mod.rs:333: line longer than 100 chars
2019-12-22T21:57:15.5311919Z tidy error: /checkout/src/librustc_mir/const_eval.rs:716: line longer than 100 chars
2019-12-22T21:57:15.5312007Z tidy error: /checkout/src/librustc_mir/const_eval.rs:719: line longer than 100 chars
2019-12-22T21:57:15.5312094Z tidy error: /checkout/src/librustc_mir/const_eval.rs:730: line longer than 100 chars
2019-12-22T21:57:15.5312155Z tidy error: /checkout/src/librustc_mir/const_eval.rs:731: line longer than 100 chars
2019-12-22T21:57:15.5312231Z tidy error: /checkout/src/librustc_mir/const_eval.rs:748: line longer than 100 chars
2019-12-22T21:57:15.5489285Z tidy error: /checkout/src/librustdoc/html/markdown/tests.rs: ignoring line length unnecessarily
2019-12-22T21:57:15.5614169Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:906: line longer than 100 chars
2019-12-22T21:57:15.5614289Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:907: line longer than 100 chars
2019-12-22T21:57:15.5614353Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:908: line longer than 100 chars
2019-12-22T21:57:15.5641747Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:5257: line longer than 100 chars
2019-12-22T21:57:15.5656578Z tidy error: /checkout/src/librustc_typeck/check/_match.rs:184: line longer than 100 chars
2019-12-22T21:57:15.5685079Z tidy error: /checkout/src/librustc_typeck/check/wfcheck.rs:771: line longer than 100 chars
2019-12-22T21:57:15.5695861Z tidy error: /checkout/src/librustc_typeck/check/coercion.rs:927: line longer than 100 chars
2019-12-22T21:57:15.5742125Z tidy error: /checkout/src/librustc_typeck/check/method/confirm.rs:549: line longer than 100 chars
2019-12-22T21:57:15.5845356Z tidy error: /checkout/src/librustc_typeck/astconv.rs:2601: line longer than 100 chars
2019-12-22T21:57:15.5845480Z tidy error: /checkout/src/librustc_typeck/astconv.rs:2602: line longer than 100 chars
2019-12-22T21:57:15.5845542Z tidy error: /checkout/src/librustc_typeck/astconv.rs:2603: line longer than 100 chars
2019-12-22T21:57:15.5845606Z tidy error: /checkout/src/librustc_codegen_utils/symbol_names/v0.rs:199: line longer than 100 chars
2019-12-22T21:57:15.6098453Z tidy error: /checkout/src/libstd/sys/unix/os.rs:73: line longer than 100 chars
2019-12-22T21:57:15.6248374Z tidy error: /checkout/src/libstd/sys/sgx/abi/mem.rs:36: line longer than 100 chars
2019-12-22T21:57:15.6248493Z tidy error: /checkout/src/libstd/sys/sgx/abi/mem.rs:46: line longer than 100 chars
2019-12-22T21:57:15.6903344Z tidy error: /checkout/src/librustc_errors/emitter.rs:128: line longer than 100 chars
2019-12-22T21:57:15.6903452Z tidy error: /checkout/src/librustc_errors/emitter.rs:586: line longer than 100 chars
2019-12-22T21:57:16.0042697Z thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /rustc/eb3f7c2d3aec576f47eba854cfbd3c1187b8a2a0/src/libcore/macros/mod.rs:15:40
2019-12-22T21:57:16.0042946Z 
2019-12-22T21:57:16.0042992Z 
2019-12-22T21:57:16.0042992Z 
2019-12-22T21:57:16.0043442Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-22T21:57:16.0043555Z 
2019-12-22T21:57:16.0043579Z 
2019-12-22T21:57:16.0052285Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-22T21:57:16.0052605Z Build completed unsuccessfully in 0:01:25
2019-12-22T21:57:16.0052605Z Build completed unsuccessfully in 0:01:25
2019-12-22T21:57:16.0102147Z == clock drift check ==
2019-12-22T21:57:16.0112474Z   local time: Sun Dec 22 21:57:16 UTC 2019
2019-12-22T21:57:16.2780366Z   network time: Sun, 22 Dec 2019 21:57:16 GMT
2019-12-22T21:57:16.2783567Z == end clock drift check ==
2019-12-22T21:57:17.7800292Z 
2019-12-22T21:57:17.7957623Z ##[error]Bash exited with code '1'.
2019-12-22T21:57:17.7994933Z ##[section]Starting: Checkout
2019-12-22T21:57:17.7997156Z ==============================================================================
2019-12-22T21:57:17.7997222Z Task         : Get sources
2019-12-22T21:57:17.7997307Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RustcEncodable,
RustcDecodable,
HashStable,
)]

This comment has been minimized.

Copy link
@matthewjasper

matthewjasper Dec 22, 2019

Contributor

Was "merge_derives: false" discussed?

region_infer::values::LivenessValues,
places_conflict,
borrow_set::BorrowSet, facts::AllFacts, location::LocationTable, nll::ToRegionVid,
places_conflict, region_infer::values::LivenessValues,

This comment has been minimized.

Copy link
@matthewjasper

matthewjasper Dec 22, 2019

Contributor

This isn't great.

This comment has been minimized.

Copy link
@Mark-Simulacrum

Mark-Simulacrum Dec 22, 2019

Author Member

I consider this a failing of the import style -- I would prefer that we not have multi-line imports at all, as they make e.g. grepping for uses much harder (and lead to potential problems like this).

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:fmt-the-world branch from 4fe589e to eeb0de3 Dec 22, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 22, 2019

@matthewjasper I agree that both of those that you noted aren't great, but I think if we block this until we're happy with the specific output it's not going to land.

However, with the consideration that reverting merge_derives later is hard, but not applying it now is easy, I've enabled that option. I suspect that we'll want to shy towards defaults in the long run, but I would say that it's a rustfmt bug to merge them when it causes you to go really multiline.

Force-pushed tidy fixes and the above.

Also moves formatting to use edition 2018, and to be done in parallel.
This brings near-linear speed ups (at least with a small amount of
cores).
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2019

☔️ The latest upstream changes (presumably #67532) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:fmt-the-world branch from eeb0de3 to a06baa5 Dec 22, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 22, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2019

📌 Commit a06baa5 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2019

⌛️ Testing commit a06baa5 with merge 1280432...

bors added a commit that referenced this pull request Dec 22, 2019
Format the world

This PR modifies the formatting infrastructure a bit in the first commit (to enable the forgotten 2018 edition), as well as removes most directories from the ignore list in rustfmt.toml. It then follows that up with the second commit which runs `x.py fmt` and formats the entire repository.

We continue to not format the test directory (`src/test`) because of interactions with pretty printing and, in part, because re-blessing all of those files is somewhat harder to review, so is best suited for a follow up PR in my opinion.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 22, 2019

The job x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-22T23:40:42.7086920Z ---- [ui] ui/async-await/issues/issue-62009-1.rs stdout ----
2019-12-22T23:40:42.7087330Z diff of stderr:
2019-12-22T23:40:42.7087920Z 
2019-12-22T23:40:42.7088090Z 35    | 
2019-12-22T23:40:42.7088850Z 36   ::: $SRC_DIR/libstd/future.rs:LL:COL
2019-12-22T23:40:42.7090040Z - LL |     F: Future
2019-12-22T23:40:42.7090520Z + LL |     F: Future,
2019-12-22T23:40:42.7090520Z + LL |     F: Future,
2019-12-22T23:40:42.7091490Z 39    |        ------ required by this bound in `std::future::poll_with_tls_context`
2019-12-22T23:40:42.7092170Z 41 error: aborting due to 4 previous errors
2019-12-22T23:40:42.7092290Z 
2019-12-22T23:40:42.7092400Z 
2019-12-22T23:40:42.7092580Z The actual stderr differed from the expected stderr.
2019-12-22T23:40:42.7092580Z The actual stderr differed from the expected stderr.
2019-12-22T23:40:42.7093610Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/async-await/issues/issue-62009-1/issue-62009-1.stderr
2019-12-22T23:40:42.7094800Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:40:42.7096120Z To only update this specific test, also pass `--test-args async-await/issues/issue-62009-1.rs`
2019-12-22T23:40:42.7096890Z error: 1 errors occurred comparing output.
2019-12-22T23:40:42.7097090Z status: exit code: 1
2019-12-22T23:40:42.7097090Z status: exit code: 1
2019-12-22T23:40:42.7099180Z command: "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/async-await/issues/issue-62009-1" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--edition=2018" "-L" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/async-await/issues/issue-62009-1/auxiliary" "-A" "unused"
2019-12-22T23:40:42.7100900Z ------------------------------------------
2019-12-22T23:40:42.7101290Z 
2019-12-22T23:40:42.7102230Z ------------------------------------------
2019-12-22T23:40:42.7102700Z stderr:
2019-12-22T23:40:42.7102700Z stderr:
2019-12-22T23:40:42.7103570Z ------------------------------------------
2019-12-22T23:40:42.7103700Z error[E0728]: `await` is only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7104870Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs:7:5
2019-12-22T23:40:42.7105580Z LL | fn main() {
2019-12-22T23:40:42.7106360Z    |    ---- this is not `async`
2019-12-22T23:40:42.7106360Z    |    ---- this is not `async`
2019-12-22T23:40:42.7106830Z LL |     async { let (); }.await;
2019-12-22T23:40:42.7107070Z    |     ^^^^^^^^^^^^^^^^^^^^^^^ only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7107200Z 
2019-12-22T23:40:42.7107370Z error[E0728]: `await` is only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7108440Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs:9:5
2019-12-22T23:40:42.7109480Z LL |   fn main() {
2019-12-22T23:40:42.7110420Z    |      ---- this is not `async`
2019-12-22T23:40:42.7110880Z ...
2019-12-22T23:40:42.7111090Z LL | /     async {
2019-12-22T23:40:42.7111090Z LL | /     async {
2019-12-22T23:40:42.7111290Z LL | |     //~^ ERROR `await` is only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7111470Z LL | |         let task1 = print_dur().await;
2019-12-22T23:40:42.7111600Z LL | |     }.await;
2019-12-22T23:40:42.7111780Z    | |___________^ only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7111920Z 
2019-12-22T23:40:42.7112090Z error[E0728]: `await` is only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7113070Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs:13:5
2019-12-22T23:40:42.7113620Z LL | fn main() {
2019-12-22T23:40:42.7114500Z    |    ---- this is not `async`
2019-12-22T23:40:42.7114950Z ...
2019-12-22T23:40:42.7114950Z ...
2019-12-22T23:40:42.7115170Z LL |     (|_| 2333).await;
2019-12-22T23:40:42.7115380Z    |     ^^^^^^^^^^^^^^^^ only allowed inside `async` functions and blocks
2019-12-22T23:40:42.7115530Z 
2019-12-22T23:40:42.7116560Z error[E0277]: the trait bound `[closure@/Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs:13:5: 13:15]: std::future::Future` is not satisfied
2019-12-22T23:40:42.7117800Z   --> /Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs:13:5
2019-12-22T23:40:42.7118350Z    |
2019-12-22T23:40:42.7118560Z LL |     (|_| 2333).await;
2019-12-22T23:40:42.7119630Z    |     ^^^^^^^^^^^^^^^^ the trait `std::future::Future` is not implemented for `[closure@/Users/runner/runners/2.163.1/work/1/s/src/test/ui/async-await/issues/issue-62009-1.rs:13:5: 13:15]`
2019-12-22T23:40:42.7120240Z   ::: /Users/runner/runners/2.163.1/work/1/s/src/libstd/future.rs:78:8
2019-12-22T23:40:42.7120470Z    |
2019-12-22T23:40:42.7120630Z LL |     F: Future,
2019-12-22T23:40:42.7120630Z LL |     F: Future,
2019-12-22T23:40:42.7121750Z    |        ------ required by this bound in `std::future::poll_with_tls_context`
2019-12-22T23:40:42.7122320Z error: aborting due to 4 previous errors
2019-12-22T23:40:42.7122460Z 
2019-12-22T23:40:42.7122650Z Some errors have detailed explanations: E0277, E0728.
2019-12-22T23:40:42.7123530Z For more information about an error, try `rustc --explain E0277`.
---
2019-12-22T23:40:42.7126190Z ---- [ui] ui/closures/closure-move-sync.rs stdout ----
2019-12-22T23:40:42.7126650Z diff of stderr:
2019-12-22T23:40:42.7126820Z 
2019-12-22T23:40:42.7126980Z 6    | 
2019-12-22T23:40:42.7127150Z 7   ::: $SRC_DIR/libstd/thread/mod.rs:LL:COL
2019-12-22T23:40:42.7127270Z 8    |
2019-12-22T23:40:42.7128140Z - LL |     F: FnOnce() -> T, F: Send + 'static, T: Send + 'static
2019-12-22T23:40:42.7129300Z -    |                          ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7130480Z + LL |     F: Send + 'static,
2019-12-22T23:40:42.7131630Z +    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7132320Z 12    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Receiver<()>`
2019-12-22T23:40:42.7132550Z 13    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Receiver<()>`
2019-12-22T23:40:42.7132710Z 
2019-12-22T23:40:42.7132820Z 21    | 
2019-12-22T23:40:42.7132820Z 21    | 
2019-12-22T23:40:42.7133000Z 22   ::: $SRC_DIR/libstd/thread/mod.rs:LL:COL
2019-12-22T23:40:42.7133190Z 23    |
2019-12-22T23:40:42.7134010Z - LL |     F: FnOnce() -> T, F: Send + 'static, T: Send + 'static
2019-12-22T23:40:42.7135340Z -    |                          ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7136450Z + LL |     F: Send + 'static,
2019-12-22T23:40:42.7137590Z +    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7138500Z 27    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Sender<()>`
2019-12-22T23:40:42.7138690Z 28    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Sender<()>`
2019-12-22T23:40:42.7139180Z 
2019-12-22T23:40:42.7139360Z 
2019-12-22T23:40:42.7139360Z 
2019-12-22T23:40:42.7139530Z The actual stderr differed from the expected stderr.
2019-12-22T23:40:42.7140540Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/closures/closure-move-sync/closure-move-sync.stderr
2019-12-22T23:40:42.7141710Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:40:42.7142900Z To only update this specific test, also pass `--test-args closures/closure-move-sync.rs`
2019-12-22T23:40:42.7143530Z error: 1 errors occurred comparing output.
2019-12-22T23:40:42.7143740Z status: exit code: 1
2019-12-22T23:40:42.7143740Z status: exit code: 1
2019-12-22T23:40:42.7145470Z command: "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui/closures/closure-move-sync.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/closures/closure-move-sync" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/closures/closure-move-sync/auxiliary" "-A" "unused"
2019-12-22T23:40:42.7147060Z ------------------------------------------
2019-12-22T23:40:42.7147120Z 
2019-12-22T23:40:42.7148230Z ------------------------------------------
2019-12-22T23:40:42.7148720Z stderr:
2019-12-22T23:40:42.7148720Z stderr:
2019-12-22T23:40:42.7149750Z ------------------------------------------
2019-12-22T23:40:42.7149910Z error[E0277]: `std::sync::mpsc::Receiver<()>` cannot be shared between threads safely
2019-12-22T23:40:42.7151590Z    |
2019-12-22T23:40:42.7151590Z    |
2019-12-22T23:40:42.7151810Z LL |     let t = thread::spawn(|| {
2019-12-22T23:40:42.7152000Z    |             ^^^^^^^^^^^^^ `std::sync::mpsc::Receiver<()>` cannot be shared between threads safely
2019-12-22T23:40:42.7152320Z   ::: /Users/runner/runners/2.163.1/work/1/s/src/libstd/thread/mod.rs:616:8
2019-12-22T23:40:42.7152530Z    |
2019-12-22T23:40:42.7153370Z LL |     F: Send + 'static,
2019-12-22T23:40:42.7154510Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7154510Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7154990Z    |
2019-12-22T23:40:42.7155200Z    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Receiver<()>`
2019-12-22T23:40:42.7155470Z    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Receiver<()>`
2019-12-22T23:40:42.7156570Z    = note: required because it appears within the type `[closure@/Users/runner/runners/2.163.1/work/1/s/src/test/ui/closures/closure-move-sync.rs:7:27: 10:6 recv:&std::sync::mpsc::Receiver<()>]`
2019-12-22T23:40:42.7156690Z 
2019-12-22T23:40:42.7157150Z error[E0277]: `std::sync::mpsc::Sender<()>` cannot be shared between threads safely
2019-12-22T23:40:42.7158590Z    |
2019-12-22T23:40:42.7158590Z    |
2019-12-22T23:40:42.7158810Z LL |     thread::spawn(|| tx.send(()).unwrap());
2019-12-22T23:40:42.7159030Z    |     ^^^^^^^^^^^^^ `std::sync::mpsc::Sender<()>` cannot be shared between threads safely
2019-12-22T23:40:42.7159300Z   ::: /Users/runner/runners/2.163.1/work/1/s/src/libstd/thread/mod.rs:616:8
2019-12-22T23:40:42.7159730Z    |
2019-12-22T23:40:42.7160280Z LL |     F: Send + 'static,
2019-12-22T23:40:42.7160810Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7160810Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7161280Z    |
2019-12-22T23:40:42.7161490Z    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Sender<()>`
2019-12-22T23:40:42.7161720Z    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Sender<()>`
2019-12-22T23:40:42.7162810Z    = note: required because it appears within the type `[closure@/Users/runner/runners/2.163.1/work/1/s/src/test/ui/closures/closure-move-sync.rs:19:19: 19:42 tx:&std::sync::mpsc::Sender<()>]`
2019-12-22T23:40:42.7163390Z error: aborting due to 2 previous errors
2019-12-22T23:40:42.7163530Z 
2019-12-22T23:40:42.7164510Z For more information about this error, try `rustc --explain E0277`.
2019-12-22T23:40:42.7164580Z 
2019-12-22T23:40:42.7164580Z 
2019-12-22T23:40:42.7165690Z ------------------------------------------
2019-12-22T23:40:42.7166090Z 
2019-12-22T23:40:42.7166260Z 
2019-12-22T23:40:42.7167140Z ---- [ui] ui/no-send-res-ports.rs stdout ----
2019-12-22T23:40:42.7167610Z diff of stderr:
2019-12-22T23:40:42.7167760Z 
2019-12-22T23:40:42.7167860Z 6    | 
2019-12-22T23:40:42.7168040Z 7   ::: $SRC_DIR/libstd/thread/mod.rs:LL:COL
2019-12-22T23:40:42.7168220Z 8    |
2019-12-22T23:40:42.7169920Z - LL |     F: FnOnce() -> T, F: Send + 'static, T: Send + 'static
2019-12-22T23:40:42.7171500Z -    |                          ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7172760Z + LL |     F: Send + 'static,
2019-12-22T23:40:42.7173810Z +    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.7174350Z 11    |
2019-12-22T23:40:42.7175620Z 12    = help: within `[closure@$DIR/no-send-res-ports.rs:26:19: 30:6 x:main::Foo]`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
2019-12-22T23:40:42.7176610Z 13    = note: required because it appears within the type `Port<()>`
2019-12-22T23:40:42.7177350Z 
2019-12-22T23:40:42.7177490Z The actual stderr differed from the expected stderr.
2019-12-22T23:40:42.7178590Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/no-send-res-ports/no-send-res-ports.stderr
2019-12-22T23:40:42.7178590Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/no-send-res-ports/no-send-res-ports.stderr
2019-12-22T23:40:42.8281120Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:40:42.8281760Z To only update this specific test, also pass `--test-args no-send-res-ports.rs`
2019-12-22T23:40:42.8282270Z error: 1 errors occurred comparing output.
2019-12-22T23:40:42.8282390Z status: exit code: 1
2019-12-22T23:40:42.8282390Z status: exit code: 1
2019-12-22T23:40:42.8283790Z command: "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui/no-send-res-ports.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/no-send-res-ports" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/no-send-res-ports/auxiliary" "-A" "unused"
2019-12-22T23:40:42.8284910Z ------------------------------------------
2019-12-22T23:40:42.8285190Z 
2019-12-22T23:40:42.8285810Z ------------------------------------------
2019-12-22T23:40:42.8286130Z stderr:
2019-12-22T23:40:42.8286130Z stderr:
2019-12-22T23:40:42.8286710Z ------------------------------------------
2019-12-22T23:40:42.8287060Z error[E0277]: `std::rc::Rc<()>` cannot be sent between threads safely
2019-12-22T23:40:42.8288430Z    |
2019-12-22T23:40:42.8288430Z    |
2019-12-22T23:40:42.8288570Z LL |     thread::spawn(move|| {
2019-12-22T23:40:42.8288690Z    |     ^^^^^^^^^^^^^ `std::rc::Rc<()>` cannot be sent between threads safely
2019-12-22T23:40:42.8288910Z   ::: /Users/runner/runners/2.163.1/work/1/s/src/libstd/thread/mod.rs:616:8
2019-12-22T23:40:42.8289030Z    |
2019-12-22T23:40:42.8289610Z LL |     F: Send + 'static,
2019-12-22T23:40:42.8290400Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.8290400Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:40:42.8290740Z    |
2019-12-22T23:40:42.8291490Z    = help: within `[closure@/Users/runner/runners/2.163.1/work/1/s/src/test/ui/no-send-res-ports.rs:26:19: 30:6 x:main::Foo]`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
2019-12-22T23:40:42.8291880Z    = note: required because it appears within the type `Port<()>`
2019-12-22T23:40:42.8292040Z    = note: required because it appears within the type `main::Foo`
2019-12-22T23:40:42.8292790Z    = note: required because it appears within the type `[closure@/Users/runner/runners/2.163.1/work/1/s/src/test/ui/no-send-res-ports.rs:26:19: 30:6 x:main::Foo]`
2019-12-22T23:40:42.8293250Z error: aborting due to previous error
2019-12-22T23:40:42.8293330Z 
2019-12-22T23:40:42.8293920Z For more information about this error, try `rustc --explain E0277`.
2019-12-22T23:40:42.8294000Z 
2019-12-22T23:40:42.8294000Z 
2019-12-22T23:40:42.8294730Z ------------------------------------------
2019-12-22T23:40:42.8295030Z 
2019-12-22T23:40:42.8295130Z 
2019-12-22T23:40:42.8295710Z ---- [ui] ui/type_length_limit.rs stdout ----
2019-12-22T23:40:42.8296400Z diff of stderr:
2019-12-22T23:40:42.8296450Z 
2019-12-22T23:40:42.8297080Z 1 error: reached the type-length limit while instantiating `std::mem::drop::<std::option::Op... G), (G, G, G), (G, G, G))))))>>`
2019-12-22T23:40:42.8297640Z 2   --> $SRC_DIR/libcore/mem/mod.rs:LL:COL
2019-12-22T23:40:42.8297720Z 3    |
2019-12-22T23:40:42.8298210Z - LL | pub fn drop<T>(_x: T) { }
2019-12-22T23:40:42.8298730Z -    | ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-22T23:40:42.8299560Z + LL | pub fn drop<T>(_x: T) {}
2019-12-22T23:40:42.8299790Z 6    |
2019-12-22T23:40:42.8299790Z 6    |
2019-12-22T23:40:42.8299870Z 7    = note: consider adding a `#![type_length_limit="1094"]` attribute to your crate
2019-12-22T23:40:42.8300000Z 
2019-12-22T23:40:42.8300040Z 
2019-12-22T23:40:42.8300110Z The actual stderr differed from the expected stderr.
2019-12-22T23:40:42.8300800Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/type_length_limit/type_length_limit.stderr
2019-12-22T23:40:42.8300800Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/type_length_limit/type_length_limit.stderr
2019-12-22T23:40:42.8301380Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:40:42.8301930Z To only update this specific test, also pass `--test-args type_length_limit.rs`
2019-12-22T23:40:42.8302090Z error: 1 errors occurred comparing output.
2019-12-22T23:40:42.8302160Z status: exit code: 1
2019-12-22T23:40:42.8302160Z status: exit code: 1
2019-12-22T23:40:42.8303470Z command: "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui/type_length_limit.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/type_length_limit" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui/type_length_limit/auxiliary" "-A" "unused"
2019-12-22T23:40:42.8304320Z ------------------------------------------
2019-12-22T23:40:42.8304380Z 
2019-12-22T23:40:42.8304890Z ------------------------------------------
2019-12-22T23:40:42.8304980Z stderr:
2019-12-22T23:40:42.8304980Z stderr:
2019-12-22T23:40:42.8305730Z ------------------------------------------
2019-12-22T23:40:42.8306340Z error: reached the type-length limit while instantiating `std::mem::drop::<std::option::Op... G), (G, G, G), (G, G, G))))))>>`
2019-12-22T23:40:42.8307030Z    |
2019-12-22T23:40:42.8307030Z    |
2019-12-22T23:40:42.8307110Z LL | pub fn drop<T>(_x: T) {}
2019-12-22T23:40:42.8307250Z    |
2019-12-22T23:40:42.8307250Z    |
2019-12-22T23:40:42.8307340Z    = note: consider adding a `#![type_length_limit="1094"]` attribute to your crate
2019-12-22T23:40:42.8307460Z error: aborting due to previous error
2019-12-22T23:40:42.8307520Z 
2019-12-22T23:40:42.8307550Z 
2019-12-22T23:40:42.8308080Z ------------------------------------------
---
2019-12-22T23:40:42.8311180Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2019-12-22T23:40:42.8311290Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-22T23:40:42.8311370Z 
2019-12-22T23:40:42.8311400Z 
2019-12-22T23:40:42.8314190Z command did not execute successfully: "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui" "--build-base" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/test/ui" "--stage-id" "stage2-x86_64-apple-darwin" "--mode" "ui" "--target" "x86_64-apple-darwin" "--host" "x86_64-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.163.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.42.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-22T23:40:42.8315080Z 
2019-12-22T23:40:42.8315120Z 
2019-12-22T23:40:42.8315210Z failed to run: /Users/runner/runners/2.163.1/work/1/s/build/bootstrap/debug/bootstrap test
2019-12-22T23:40:42.8315310Z Build completed unsuccessfully in 0:49:49
2019-12-22T23:40:42.8315310Z Build completed unsuccessfully in 0:49:49
2019-12-22T23:40:42.8315380Z == clock drift check ==
2019-12-22T23:40:42.8315460Z   local time: Sun Dec 22 23:40:42 UTC 2019
2019-12-22T23:40:42.8315530Z   network time: Sun, 22 Dec 2019 23:40:42 GMT
2019-12-22T23:40:42.8315610Z == end clock drift check ==
2019-12-22T23:40:42.8315850Z 
2019-12-22T23:40:42.8397590Z ##[error]Bash exited with code '1'.
2019-12-22T23:40:42.8439950Z ##[section]Starting: Checkout
2019-12-22T23:40:42.8442610Z ==============================================================================
2019-12-22T23:40:42.8442700Z Task         : Get sources
2019-12-22T23:40:42.8442790Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 22, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-22T22:43:42.7089584Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-22T22:43:42.7296125Z ##[command]git config gc.auto 0
2019-12-22T22:43:42.7380378Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-22T22:43:42.7443024Z ##[command]git config --get-all http.proxy
2019-12-22T22:43:42.7646925Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67540/merge:refs/remotes/pull/67540/merge
---
2019-12-22T23:46:19.2212529Z .................................................................................................... 1600/9427
2019-12-22T23:46:23.9458017Z .................................................................................................... 1700/9427
2019-12-22T23:46:34.6246296Z .....................................................................................i.............. 1800/9427
2019-12-22T23:46:42.4873739Z .................................................................................................... 1900/9427
2019-12-22T23:46:49.5826473Z ......................................................................iiiii......................... 2000/9427
2019-12-22T23:47:11.2089725Z .................................................................................................... 2200/9427
2019-12-22T23:47:13.6958924Z .................................................................................................... 2300/9427
2019-12-22T23:47:16.4854138Z .................................................................................................... 2400/9427
2019-12-22T23:47:30.0801003Z .................................................................................................... 2500/9427
---
2019-12-22T23:50:27.3219377Z .i...............i.................................................................................. 4900/9427
2019-12-22T23:50:37.6576453Z .................................................................................................... 5000/9427
2019-12-22T23:50:42.7029929Z .............................................i...................................................... 5100/9427
2019-12-22T23:50:52.8100811Z .................................................................................................... 5200/9427
2019-12-22T23:50:58.8045020Z ............ii.ii...........i....................................................................... 5300/9427
2019-12-22T23:51:08.3268074Z .................................................................................................... 5500/9427
2019-12-22T23:51:19.8494352Z ..............................................................................................i..... 5600/9427
2019-12-22T23:51:28.1000734Z .................................................................................................... 5700/9427
2019-12-22T23:51:33.4034417Z .................................................................................................... 5800/9427
2019-12-22T23:51:33.4034417Z .................................................................................................... 5800/9427
2019-12-22T23:51:43.5191882Z ..................................................................................ii...i..ii........ 5900/9427
2019-12-22T23:52:07.0199565Z .................................................................................................... 6100/9427
2019-12-22T23:52:15.0837191Z .................................................................................................... 6200/9427
2019-12-22T23:52:23.4463215Z .......................................................................................F............ 6300/9427
2019-12-22T23:52:23.4463215Z .......................................................................................F............ 6300/9427
2019-12-22T23:52:36.9264556Z .........i..ii...................................................................................... 6400/9427
2019-12-22T23:52:56.8813341Z .....................................................................................i.............. 6600/9427
2019-12-22T23:52:59.1030274Z .................................................................................................... 6700/9427
2019-12-22T23:53:01.4539538Z .....................................................................................i.............. 6800/9427
2019-12-22T23:53:04.3112257Z .................................................................................................... 6900/9427
---
2019-12-22T23:54:41.2518467Z .................................................................................................... 7400/9427
2019-12-22T23:54:46.2157252Z .................................................................................................... 7500/9427
2019-12-22T23:54:51.5350287Z .................................................................................................... 7600/9427
2019-12-22T23:54:58.6340405Z .................................................................................................... 7700/9427
2019-12-22T23:55:09.6326044Z ...................................................................................................i 7800/9427
2019-12-22T23:55:16.7937795Z iii................................................................................................. 7900/9427
2019-12-22T23:55:31.4510192Z .................................................................................................... 8100/9427
2019-12-22T23:55:43.5584456Z .................................................................................................... 8200/9427
2019-12-22T23:55:55.7950134Z .................................................................................................... 8300/9427
2019-12-22T23:56:01.7545345Z .................................................................................................... 8400/9427
---
2019-12-22T23:57:59.9105831Z ---- [ui] ui/async-await/issues/issue-62009-1.rs stdout ----
2019-12-22T23:57:59.9106213Z diff of stderr:
2019-12-22T23:57:59.9106482Z 
2019-12-22T23:57:59.9106745Z 35    | 
2019-12-22T23:57:59.9107005Z 36   ::: $SRC_DIR/libstd/future.rs:LL:COL
2019-12-22T23:57:59.9107816Z - LL |     F: Future
2019-12-22T23:57:59.9108172Z + LL |     F: Future,
2019-12-22T23:57:59.9108172Z + LL |     F: Future,
2019-12-22T23:57:59.9109335Z 39    |        ------ required by this bound in `std::future::poll_with_tls_context`
2019-12-22T23:57:59.9110400Z 41 error: aborting due to 4 previous errors
2019-12-22T23:57:59.9112204Z 
2019-12-22T23:57:59.9112754Z 
2019-12-22T23:57:59.9113060Z The actual stderr differed from the expected stderr.
2019-12-22T23:57:59.9113060Z The actual stderr differed from the expected stderr.
2019-12-22T23:57:59.9113813Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/issues/issue-62009-1/issue-62009-1.stderr
2019-12-22T23:57:59.9114501Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:57:59.9115153Z To only update this specific test, also pass `--test-args async-await/issues/issue-62009-1.rs`
2019-12-22T23:57:59.9116489Z error: 1 errors occurred comparing output.
2019-12-22T23:57:59.9116848Z status: exit code: 1
2019-12-22T23:57:59.9116848Z status: exit code: 1
2019-12-22T23:57:59.9118468Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/async-await/issues/issue-62009-1.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/issues/issue-62009-1" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/issues/issue-62009-1/auxiliary" "-A" "unused"
2019-12-22T23:57:59.9120361Z ------------------------------------------
2019-12-22T23:57:59.9120676Z 
2019-12-22T23:57:59.9126040Z ------------------------------------------
2019-12-22T23:57:59.9126351Z stderr:
2019-12-22T23:57:59.9126351Z stderr:
2019-12-22T23:57:59.9126680Z ------------------------------------------
2019-12-22T23:57:59.9126742Z error[E0728]: `await` is only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9127057Z   --> /checkout/src/test/ui/async-await/issues/issue-62009-1.rs:7:5
2019-12-22T23:57:59.9127184Z LL | fn main() {
2019-12-22T23:57:59.9127426Z    |    ---- this is not `async`
2019-12-22T23:57:59.9127426Z    |    ---- this is not `async`
2019-12-22T23:57:59.9129385Z LL |     async { let (); }.await;
2019-12-22T23:57:59.9129508Z    |     ^^^^^^^^^^^^^^^^^^^^^^^ only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9129549Z 
2019-12-22T23:57:59.9129602Z error[E0728]: `await` is only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9130060Z   --> /checkout/src/test/ui/async-await/issues/issue-62009-1.rs:9:5
2019-12-22T23:57:59.9130164Z LL |   fn main() {
2019-12-22T23:57:59.9130430Z    |      ---- this is not `async`
2019-12-22T23:57:59.9130481Z ...
2019-12-22T23:57:59.9130528Z LL | /     async {
2019-12-22T23:57:59.9130528Z LL | /     async {
2019-12-22T23:57:59.9130607Z LL | |     //~^ ERROR `await` is only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9130676Z LL | |         let task1 = print_dur().await;
2019-12-22T23:57:59.9130726Z LL | |     }.await;
2019-12-22T23:57:59.9130780Z    | |___________^ only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9130834Z 
2019-12-22T23:57:59.9130887Z error[E0728]: `await` is only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9131188Z   --> /checkout/src/test/ui/async-await/issues/issue-62009-1.rs:13:5
2019-12-22T23:57:59.9131308Z LL | fn main() {
2019-12-22T23:57:59.9131547Z    |    ---- this is not `async`
2019-12-22T23:57:59.9131616Z ...
2019-12-22T23:57:59.9131616Z ...
2019-12-22T23:57:59.9131663Z LL |     (|_| 2333).await;
2019-12-22T23:57:59.9131716Z    |     ^^^^^^^^^^^^^^^^ only allowed inside `async` functions and blocks
2019-12-22T23:57:59.9131750Z 
2019-12-22T23:57:59.9132191Z error[E0277]: the trait bound `[closure@/checkout/src/test/ui/async-await/issues/issue-62009-1.rs:13:5: 13:15]: std::future::Future` is not satisfied
2019-12-22T23:57:59.9132573Z   --> /checkout/src/test/ui/async-await/issues/issue-62009-1.rs:13:5
2019-12-22T23:57:59.9132641Z    |
2019-12-22T23:57:59.9132708Z LL |     (|_| 2333).await;
2019-12-22T23:57:59.9133104Z    |     ^^^^^^^^^^^^^^^^ the trait `std::future::Future` is not implemented for `[closure@/checkout/src/test/ui/async-await/issues/issue-62009-1.rs:13:5: 13:15]`
2019-12-22T23:57:59.9133242Z   ::: /checkout/src/libstd/future.rs:78:8
2019-12-22T23:57:59.9133291Z    |
2019-12-22T23:57:59.9133338Z LL |     F: Future,
2019-12-22T23:57:59.9133338Z LL |     F: Future,
2019-12-22T23:57:59.9133720Z    |        ------ required by this bound in `std::future::poll_with_tls_context`
2019-12-22T23:57:59.9133810Z error: aborting due to 4 previous errors
2019-12-22T23:57:59.9133842Z 
2019-12-22T23:57:59.9133910Z Some errors have detailed explanations: E0277, E0728.
2019-12-22T23:57:59.9134184Z For more information about an error, try `rustc --explain E0277`.
---
2019-12-22T23:57:59.9135031Z ---- [ui] ui/closures/closure-move-sync.rs stdout ----
2019-12-22T23:57:59.9135086Z diff of stderr:
2019-12-22T23:57:59.9135135Z 
2019-12-22T23:57:59.9135179Z 6    | 
2019-12-22T23:57:59.9135229Z 7   ::: $SRC_DIR/libstd/thread/mod.rs:LL:COL
2019-12-22T23:57:59.9135277Z 8    |
2019-12-22T23:57:59.9135668Z - LL |     F: FnOnce() -> T, F: Send + 'static, T: Send + 'static
2019-12-22T23:57:59.9135999Z -    |                          ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9136233Z + LL |     F: Send + 'static,
2019-12-22T23:57:59.9136521Z +    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9142363Z 12    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Receiver<()>`
2019-12-22T23:57:59.9142740Z 13    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Receiver<()>`
2019-12-22T23:57:59.9142804Z 
2019-12-22T23:57:59.9142990Z 21    | 
2019-12-22T23:57:59.9142990Z 21    | 
2019-12-22T23:57:59.9143062Z 22   ::: $SRC_DIR/libstd/thread/mod.rs:LL:COL
2019-12-22T23:57:59.9143291Z 23    |
2019-12-22T23:57:59.9144224Z - LL |     F: FnOnce() -> T, F: Send + 'static, T: Send + 'static
2019-12-22T23:57:59.9144548Z -    |                          ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9144817Z + LL |     F: Send + 'static,
2019-12-22T23:57:59.9145083Z +    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9145210Z 27    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Sender<()>`
2019-12-22T23:57:59.9145279Z 28    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Sender<()>`
2019-12-22T23:57:59.9145320Z 
2019-12-22T23:57:59.9145349Z 
2019-12-22T23:57:59.9145349Z 
2019-12-22T23:57:59.9145417Z The actual stderr differed from the expected stderr.
2019-12-22T23:57:59.9145776Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/closure-move-sync/closure-move-sync.stderr
2019-12-22T23:57:59.9146051Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:57:59.9146369Z To only update this specific test, also pass `--test-args closures/closure-move-sync.rs`
2019-12-22T23:57:59.9146469Z error: 1 errors occurred comparing output.
2019-12-22T23:57:59.9146537Z status: exit code: 1
2019-12-22T23:57:59.9146537Z status: exit code: 1
2019-12-22T23:57:59.9147481Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/closures/closure-move-sync.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/closure-move-sync" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/closure-move-sync/auxiliary" "-A" "unused"
2019-12-22T23:57:59.9147868Z ------------------------------------------
2019-12-22T23:57:59.9147905Z 
2019-12-22T23:57:59.9148180Z ------------------------------------------
2019-12-22T23:57:59.9148232Z stderr:
2019-12-22T23:57:59.9148232Z stderr:
2019-12-22T23:57:59.9148467Z ------------------------------------------
2019-12-22T23:57:59.9148528Z error[E0277]: `std::sync::mpsc::Receiver<()>` cannot be shared between threads safely
2019-12-22T23:57:59.9149349Z    |
2019-12-22T23:57:59.9149349Z    |
2019-12-22T23:57:59.9149397Z LL |     let t = thread::spawn(|| {
2019-12-22T23:57:59.9149481Z    |             ^^^^^^^^^^^^^ `std::sync::mpsc::Receiver<()>` cannot be shared between threads safely
2019-12-22T23:57:59.9149866Z   ::: /checkout/src/libstd/thread/mod.rs:616:8
2019-12-22T23:57:59.9150114Z    |
2019-12-22T23:57:59.9150430Z LL |     F: Send + 'static,
2019-12-22T23:57:59.9150699Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9150699Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9150771Z    |
2019-12-22T23:57:59.9150827Z    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Receiver<()>`
2019-12-22T23:57:59.9150996Z    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Receiver<()>`
2019-12-22T23:57:59.9151457Z    = note: required because it appears within the type `[closure@/checkout/src/test/ui/closures/closure-move-sync.rs:7:27: 10:6 recv:&std::sync::mpsc::Receiver<()>]`
2019-12-22T23:57:59.9151512Z 
2019-12-22T23:57:59.9151568Z error[E0277]: `std::sync::mpsc::Sender<()>` cannot be shared between threads safely
2019-12-22T23:57:59.9151921Z    |
2019-12-22T23:57:59.9151921Z    |
2019-12-22T23:57:59.9151981Z LL |     thread::spawn(|| tx.send(()).unwrap());
2019-12-22T23:57:59.9152059Z    |     ^^^^^^^^^^^^^ `std::sync::mpsc::Sender<()>` cannot be shared between threads safely
2019-12-22T23:57:59.9152164Z   ::: /checkout/src/libstd/thread/mod.rs:616:8
2019-12-22T23:57:59.9152229Z    |
2019-12-22T23:57:59.9152455Z LL |     F: Send + 'static,
2019-12-22T23:57:59.9152726Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9152726Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9152798Z    |
2019-12-22T23:57:59.9152853Z    = help: the trait `std::marker::Sync` is not implemented for `std::sync::mpsc::Sender<()>`
2019-12-22T23:57:59.9152918Z    = note: required because of the requirements on the impl of `std::marker::Send` for `&std::sync::mpsc::Sender<()>`
2019-12-22T23:57:59.9153332Z    = note: required because it appears within the type `[closure@/checkout/src/test/ui/closures/closure-move-sync.rs:19:19: 19:42 tx:&std::sync::mpsc::Sender<()>]`
2019-12-22T23:57:59.9153432Z error: aborting due to 2 previous errors
2019-12-22T23:57:59.9153493Z 
2019-12-22T23:57:59.9153768Z For more information about this error, try `rustc --explain E0277`.
2019-12-22T23:57:59.9153806Z 
2019-12-22T23:57:59.9153806Z 
2019-12-22T23:57:59.9154042Z ------------------------------------------
2019-12-22T23:57:59.9154096Z 
2019-12-22T23:57:59.9154124Z 
2019-12-22T23:57:59.9154375Z ---- [ui] ui/no-send-res-ports.rs stdout ----
2019-12-22T23:57:59.9154427Z diff of stderr:
2019-12-22T23:57:59.9154477Z 
2019-12-22T23:57:59.9154521Z 6    | 
2019-12-22T23:57:59.9154571Z 7   ::: $SRC_DIR/libstd/thread/mod.rs:LL:COL
2019-12-22T23:57:59.9154618Z 8    |
2019-12-22T23:57:59.9154946Z - LL |     F: FnOnce() -> T, F: Send + 'static, T: Send + 'static
2019-12-22T23:57:59.9155231Z -    |                          ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9155488Z + LL |     F: Send + 'static,
2019-12-22T23:57:59.9155822Z +    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9155875Z 11    |
2019-12-22T23:57:59.9182566Z 12    = help: within `[closure@$DIR/no-send-res-ports.rs:26:19: 30:6 x:main::Foo]`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
2019-12-22T23:57:59.9182659Z 13    = note: required because it appears within the type `Port<()>`
2019-12-22T23:57:59.9182728Z 
2019-12-22T23:57:59.9182812Z The actual stderr differed from the expected stderr.
2019-12-22T23:57:59.9183175Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/no-send-res-ports/no-send-res-ports.stderr
2019-12-22T23:57:59.9183175Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/no-send-res-ports/no-send-res-ports.stderr
2019-12-22T23:57:59.9183456Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:57:59.9183801Z To only update this specific test, also pass `--test-args no-send-res-ports.rs`
2019-12-22T23:57:59.9183897Z error: 1 errors occurred comparing output.
2019-12-22T23:57:59.9183965Z status: exit code: 1
2019-12-22T23:57:59.9183965Z status: exit code: 1
2019-12-22T23:57:59.9185074Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/no-send-res-ports.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/no-send-res-ports" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/no-send-res-ports/auxiliary" "-A" "unused"
2019-12-22T23:57:59.9185605Z ------------------------------------------
2019-12-22T23:57:59.9185648Z 
2019-12-22T23:57:59.9185932Z ------------------------------------------
2019-12-22T23:57:59.9185988Z stderr:
2019-12-22T23:57:59.9185988Z stderr:
2019-12-22T23:57:59.9186251Z ------------------------------------------
2019-12-22T23:57:59.9186314Z error[E0277]: `std::rc::Rc<()>` cannot be sent between threads safely
2019-12-22T23:57:59.9186682Z    |
2019-12-22T23:57:59.9186682Z    |
2019-12-22T23:57:59.9186733Z LL |     thread::spawn(move|| {
2019-12-22T23:57:59.9186802Z    |     ^^^^^^^^^^^^^ `std::rc::Rc<()>` cannot be sent between threads safely
2019-12-22T23:57:59.9186908Z   ::: /checkout/src/libstd/thread/mod.rs:616:8
2019-12-22T23:57:59.9186975Z    |
2019-12-22T23:57:59.9187235Z LL |     F: Send + 'static,
2019-12-22T23:57:59.9187531Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9187531Z    |        ---- required by this bound in `std::thread::spawn`
2019-12-22T23:57:59.9187603Z    |
2019-12-22T23:57:59.9188018Z    = help: within `[closure@/checkout/src/test/ui/no-send-res-ports.rs:26:19: 30:6 x:main::Foo]`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<()>`
2019-12-22T23:57:59.9188092Z    = note: required because it appears within the type `Port<()>`
2019-12-22T23:57:59.9188171Z    = note: required because it appears within the type `main::Foo`
2019-12-22T23:57:59.9188555Z    = note: required because it appears within the type `[closure@/checkout/src/test/ui/no-send-res-ports.rs:26:19: 30:6 x:main::Foo]`
2019-12-22T23:57:59.9188675Z error: aborting due to previous error
2019-12-22T23:57:59.9188744Z 
2019-12-22T23:57:59.9189051Z For more information about this error, try `rustc --explain E0277`.
2019-12-22T23:57:59.9189091Z 
2019-12-22T23:57:59.9189091Z 
2019-12-22T23:57:59.9189419Z ------------------------------------------
2019-12-22T23:57:59.9189457Z 
2019-12-22T23:57:59.9189488Z 
2019-12-22T23:57:59.9190291Z ---- [ui] ui/type_length_limit.rs stdout ----
2019-12-22T23:57:59.9190371Z diff of stderr:
2019-12-22T23:57:59.9190404Z 
2019-12-22T23:57:59.9190774Z 1 error: reached the type-length limit while instantiating `std::mem::drop::<std::option::Op... G), (G, G, G), (G, G, G))))))>>`
2019-12-22T23:57:59.9191049Z 2   --> $SRC_DIR/libcore/mem/mod.rs:LL:COL
2019-12-22T23:57:59.9191120Z 3    |
2019-12-22T23:57:59.9191369Z - LL | pub fn drop<T>(_x: T) { }
2019-12-22T23:57:59.9191619Z -    | ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-12-22T23:57:59.9191696Z + LL | pub fn drop<T>(_x: T) {}
2019-12-22T23:57:59.9191798Z 6    |
2019-12-22T23:57:59.9191798Z 6    |
2019-12-22T23:57:59.9191856Z 7    = note: consider adding a `#![type_length_limit="1094"]` attribute to your crate
2019-12-22T23:57:59.9191949Z 
2019-12-22T23:57:59.9191979Z 
2019-12-22T23:57:59.9192040Z The actual stderr differed from the expected stderr.
2019-12-22T23:57:59.9192403Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/type_length_limit/type_length_limit.stderr
2019-12-22T23:57:59.9192403Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/type_length_limit/type_length_limit.stderr
2019-12-22T23:57:59.9192699Z To update references, rerun the tests and pass the `--bless` flag
2019-12-22T23:57:59.9193004Z To only update this specific test, also pass `--test-args type_length_limit.rs`
2019-12-22T23:57:59.9193109Z error: 1 errors occurred comparing output.
2019-12-22T23:57:59.9193161Z status: exit code: 1
2019-12-22T23:57:59.9193161Z status: exit code: 1
2019-12-22T23:57:59.9194211Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/type_length_limit.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/type_length_limit" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/type_length_limit/auxiliary" "-A" "unused"
2019-12-22T23:57:59.9194728Z ------------------------------------------
2019-12-22T23:57:59.9194769Z 
2019-12-22T23:57:59.9195055Z ------------------------------------------
2019-12-22T23:57:59.9195108Z stderr:
2019-12-22T23:57:59.9195108Z stderr:
2019-12-22T23:57:59.9195363Z ------------------------------------------
2019-12-22T23:57:59.9195741Z error: reached the type-length limit while instantiating `std::mem::drop::<std::option::Op... G), (G, G, G), (G, G, G))))))>>`
2019-12-22T23:57:59.9196095Z    |
2019-12-22T23:57:59.9196095Z    |
2019-12-22T23:57:59.9196159Z LL | pub fn drop<T>(_x: T) {}
2019-12-22T23:57:59.9196260Z    |
2019-12-22T23:57:59.9196260Z    |
2019-12-22T23:57:59.9196329Z    = note: consider adding a `#![type_length_limit="1094"]` attribute to your crate
2019-12-22T23:57:59.9196429Z error: aborting due to previous error
2019-12-22T23:57:59.9196462Z 
2019-12-22T23:57:59.9196491Z 
2019-12-22T23:57:59.9196769Z ------------------------------------------
---
2019-12-22T23:57:59.9200691Z test result: FAILED. 9376 passed; 4 failed; 47 ignored; 0 measured; 0 filtered out
2019-12-22T23:57:59.9200769Z 
2019-12-22T23:57:59.9200854Z 
2019-12-22T23:57:59.9200886Z 
2019-12-22T23:57:59.9202960Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-22T23:57:59.9203249Z 
2019-12-22T23:57:59.9203281Z 
2019-12-22T23:57:59.9203634Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2019-12-22T23:57:59.9203707Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-22T23:57:59.9203707Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-22T23:57:59.9203772Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-22T23:57:59.9203988Z Build completed unsuccessfully in 1:07:38
2019-12-22T23:57:59.9204039Z == clock drift check ==
2019-12-22T23:57:59.9225169Z   local time: Sun Dec 22 23:57:59 UTC 2019
2019-12-22T23:58:00.0169989Z   network time: Sun, 22 Dec 2019 23:58:00 GMT
2019-12-22T23:58:00.0170241Z == end clock drift check ==
2019-12-22T23:58:01.0870964Z 
2019-12-22T23:58:01.1007109Z ##[error]Bash exited with code '1'.
2019-12-22T23:58:01.1050919Z ##[section]Starting: Checkout
2019-12-22T23:58:01.1052916Z ==============================================================================
2019-12-22T23:58:01.1053001Z Task         : Get sources
2019-12-22T23:58:01.1053060Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@lzutao

This comment has been minimized.

Copy link
Contributor

lzutao commented Dec 23, 2019

And that's cause a bunch of merge conflicts :)

@mark-i-m

This comment has been minimized.

Copy link
Member

mark-i-m commented Dec 23, 2019

I'm really glad this happened, but a bit of warning would have been nice...

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Dec 23, 2019

The blog has an announcement about this PR merging, but it was published once it was fait accompli.

@Mark-Simulacrum recommends using this snippet:

# This should be the name of the remote for rust-lang/rust
git fetch upstream
# This rebases up to the bors merge right before formatting landed;
# it needs to be done manually.
git rebase -i 9b98af84c4aa66392236fff59c86da2130d46d46
# This rebases onto the formatting PR (given the previous command, only that).
# We tell git to resolve all conflicts in favor of your code (`-Xtheirs`),
# and the `--exec` command specifies that after each commit lands, it will be formatted.
# This command will fail if your PR has intermediary commits with syntax conflicts.
git rebase -i a916ac22b9f7f1f0f7aba0a41a789b3ecd765018 \
    --exec './x.py fmt && git add -u && git commit --amend` \
    # This exec is optional, and won't work if your intermediate commits don't build,
    # but it helps make sure that the formatting resolution didn't introduce any errors.
    # It's recommended to run it afterwards before pushing at least.
    --exec './x.py check' \
    -Xtheirs
@Mark-Simulacrum Mark-Simulacrum deleted the Mark-Simulacrum:fmt-the-world branch Dec 23, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 23, 2019

This was brought up a couple times at compiler team meetings and the long term plan has been to do it around the holidays; I agree that it would've been a good idea to publish something on internals or so a bit earlier.

@RalfJung

This comment has been minimized.

Copy link
Member

RalfJung commented Jan 3, 2020

What this PR did do the Miri error printing code is quite the disaster. Previously, we consistently had a write! macro at the beginning of the first line after the pattern, now the style is all over the place depending on how long the error message is (sometimes it's on the same line as the =>, sometimes it's on the next line, and sometimes the write! is on the same line as the => but the arguments are on the next line -- the latter is totally unreadable IMO). Is there anything we can do about that?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Jan 3, 2020

#[rustfmt::skip] should just work, and is the recommendation I believe for such cases. (It can be applied at module-level granularity, but I believe will not be inherited).

@RalfJung

This comment has been minimized.

Copy link
Member

RalfJung commented Jan 3, 2020

This basically means I have to add #[rustfmt::skip] to all but the most trivial match, as rustfmt tends to destroy all of them. The long ones just show that better. Also I might still want the code inside the match arms to be formatted, it's just the match itself that rustfmt does a poor job on.

IMO this is a serious deficiency in rustfmt. (In fact I think almost all of my frustration about rustfmt stems from how it handles matches.) Cc rust-lang/rustfmt#3995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.