Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the barrier cache during ARM EHABI unwinding #67779

Merged
merged 1 commit into from Jan 2, 2020

Conversation

@Amanieu
Copy link
Contributor

Amanieu commented Jan 1, 2020

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 1, 2020

@bors r+

Do we need to beta-nominate this?

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2020

📌 Commit 057ad39 has been approved by Mark-Simulacrum

@Amanieu

This comment has been minimized.

Copy link
Contributor Author

Amanieu commented Jan 1, 2020

I don't think that's necessary, at the moment it's just a test failure on ARM targets (tier-2 so we don't block releases on test failures). Also FFI unwinding is still officially UB according to the docs.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

⌛️ Testing commit 057ad39 with merge 766fba3...

bors added a commit that referenced this pull request Jan 2, 2020
Update the barrier cache during ARM EHABI unwinding

Fixes #67242

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 766fba3 to master...

@bors bors added the merged-by-bors label Jan 2, 2020
@bors bors merged commit 057ad39 into rust-lang:master Jan 2, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200101.30 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.