Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement uncommon_codepoints lint. #67810

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@crlf0710
Copy link
Contributor

crlf0710 commented Jan 2, 2020

Part of #55467 . The checks of $crate and {{root}} are very unfortunate. But i'm not sure where they belongs to.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 2, 2020

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Jan 2, 2020

@crlf0710 crlf0710 force-pushed the crlf0710:uncommon_codepoints_lint branch from 3540478 to 549ac20 Jan 2, 2020
@crlf0710 crlf0710 force-pushed the crlf0710:uncommon_codepoints_lint branch from 549ac20 to a204e81 Jan 2, 2020
@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jan 2, 2020

@bors r+ roll-up=maybe

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

📌 Commit a204e81 has been approved by Manishearth

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jan 2, 2020

@bors rollup=maybe

dammit autocorrect

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jan 2, 2020
…r=Manishearth

Implement uncommon_codepoints lint.

Part of rust-lang#55467 .  The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 2, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-02T16:46:15.8355363Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-02T16:46:15.8589095Z ##[command]git config gc.auto 0
2020-01-02T16:46:15.8663499Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-02T16:46:15.8716409Z ##[command]git config --get-all http.proxy
2020-01-02T16:46:15.8850227Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67810/merge:refs/remotes/pull/67810/merge
---
2020-01-02T17:44:53.3066175Z .................................................................................................... 1500/9469
2020-01-02T17:44:58.9555259Z .................................................................................................... 1600/9469
2020-01-02T17:45:03.7030120Z .................................................................................................... 1700/9469
2020-01-02T17:45:12.7479418Z .................................................................................................... 1800/9469
2020-01-02T17:45:20.6447496Z .i.................................................................................................. 1900/9469
2020-01-02T17:45:27.0319594Z .......................................................................................iiiii........ 2000/9469
2020-01-02T17:45:48.0209131Z .................................................................................................... 2200/9469
2020-01-02T17:45:50.2765458Z .................................................................................................... 2300/9469
2020-01-02T17:45:52.6639189Z .................................................................................................... 2400/9469
2020-01-02T17:45:58.5445652Z .................................................................................................... 2500/9469
---
2020-01-02T17:48:49.6330262Z ..................i..F............i................................................................. 4900/9469
2020-01-02T17:48:59.0253114Z .................................................................................................... 5000/9469
2020-01-02T17:49:04.4965669Z ...............................................................i.................................... 5100/9469
2020-01-02T17:49:12.2404253Z .................................................................................................... 5200/9469
2020-01-02T17:49:19.4687545Z ..............................ii.ii...........i..................................................... 5300/9469
2020-01-02T17:49:28.3495570Z .................................................................................................... 5500/9469
2020-01-02T17:49:37.9721029Z .................................................................................................... 5600/9469
2020-01-02T17:49:44.5440051Z ..............i..................................................................................... 5700/9469
2020-01-02T17:49:50.4110986Z .................................................................................................... 5800/9469
2020-01-02T17:49:50.4110986Z .................................................................................................... 5800/9469
2020-01-02T17:50:00.8978693Z .................................................................................................... 5900/9469
2020-01-02T17:50:12.3233160Z ..ii...i..ii...........i............................................................................ 6000/9469
2020-01-02T17:50:28.4864419Z .................................................................................................... 6200/9469
2020-01-02T17:50:35.8399075Z .................................................................................................... 6300/9469
2020-01-02T17:50:35.8399075Z .................................................................................................... 6300/9469
2020-01-02T17:50:53.0699531Z .............................i..ii.................................................................. 6400/9469
2020-01-02T17:51:12.2345712Z .................................................................................................... 6600/9469
2020-01-02T17:51:14.2492922Z ....i............................................................................................... 6700/9469
2020-01-02T17:51:16.4852031Z .................................................................................................... 6800/9469
2020-01-02T17:51:18.9186934Z ....i............................................................................................... 6900/9469
---
2020-01-02T17:52:53.1293939Z .................................................................................................... 7500/9469
2020-01-02T17:52:57.5693219Z .................................................................................................... 7600/9469
2020-01-02T17:53:02.2906366Z .................................................................................................... 7700/9469
2020-01-02T17:53:12.6762973Z .................................................................................................... 7800/9469
2020-01-02T17:53:19.8693354Z ......................................iiii.......................................................... 7900/9469
2020-01-02T17:53:33.9277802Z .................................................................................................... 8100/9469
2020-01-02T17:53:42.2679425Z .................................................................................................... 8200/9469
2020-01-02T17:53:55.7404175Z .................................................................................................... 8300/9469
2020-01-02T17:54:03.2799779Z .................................................................................................... 8400/9469
---
2020-01-02T17:55:53.5474024Z 
2020-01-02T17:55:53.5474138Z 
2020-01-02T17:55:53.5474277Z The actual stderr differed from the expected stderr.
2020-01-02T17:55:53.5474737Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48508/issue-48508.stderr
2020-01-02T17:55:53.5475145Z To update references, rerun the tests and pass the `--bless` flag
2020-01-02T17:55:53.5475587Z To only update this specific test, also pass `--test-args issues/issue-48508.rs`
2020-01-02T17:55:53.5475901Z error: 1 errors occurred comparing output.
2020-01-02T17:55:53.5476069Z status: exit code: 0
2020-01-02T17:55:53.5476069Z status: exit code: 0
2020-01-02T17:55:53.5477334Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-48508.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48508/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-g" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-48508/auxiliary"
2020-01-02T17:55:53.5478008Z ------------------------------------------
2020-01-02T17:55:53.5478166Z 
2020-01-02T17:55:53.5478778Z ------------------------------------------
2020-01-02T17:55:53.5478990Z stderr:
---
2020-01-02T17:55:53.5541579Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-02T17:55:53.5541664Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-02T17:55:53.5555262Z 
2020-01-02T17:55:53.5555416Z 
2020-01-02T17:55:53.5567468Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-02T17:55:53.5568363Z 
2020-01-02T17:55:53.5568398Z 
2020-01-02T17:55:53.5571334Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-02T17:55:53.5571417Z Build completed unsuccessfully in 1:03:19
2020-01-02T17:55:53.5571417Z Build completed unsuccessfully in 1:03:19
2020-01-02T17:55:53.5632464Z == clock drift check ==
2020-01-02T17:55:53.5659020Z   local time: Thu Jan  2 17:55:53 UTC 2020
2020-01-02T17:55:54.1149525Z   network time: Thu, 02 Jan 2020 17:55:54 GMT
2020-01-02T17:55:54.1150118Z == end clock drift check ==
2020-01-02T17:55:55.1110962Z 
2020-01-02T17:55:55.1229419Z ##[error]Bash exited with code '1'.
2020-01-02T17:55:55.1266044Z ##[section]Starting: Checkout
2020-01-02T17:55:55.1268147Z ==============================================================================
2020-01-02T17:55:55.1268221Z Task         : Get sources
2020-01-02T17:55:55.1268271Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Jan 2, 2020

@bors r- ^---

@crlf0710 crlf0710 force-pushed the crlf0710:uncommon_codepoints_lint branch from a204e81 to 485e98a Jan 3, 2020
@crlf0710

This comment has been minimized.

Copy link
Contributor Author

crlf0710 commented Jan 3, 2020

One of the existing tests triggered this lint. I added #[allow] to that test.

@crlf0710

This comment has been minimized.

Copy link
Contributor Author

crlf0710 commented Jan 3, 2020

@Manishearth @Centril I think @estebank will be away this week... Would you mind review this?

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jan 3, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 3, 2020

📌 Commit 485e98a has been approved by Manishearth

Centril added a commit to Centril/rust that referenced this pull request Jan 3, 2020
…r=Manishearth

Implement uncommon_codepoints lint.

Part of rust-lang#55467 .  The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
bors added a commit that referenced this pull request Jan 4, 2020
Rollup of 8 pull requests

Successful merges:

 - #66913 (Suggest calling method when first argument is `self`)
 - #67531 (no longer promote non-pattern const functions)
 - #67770 (More reductions in error handling diversity)
 - #67773 (Add a test for #37333)
 - #67789 (Cleanup linkchecker whitelist)
 - #67810 (Implement uncommon_codepoints lint.)
 - #67835 (tweak wording of mismatched delimiter errors)
 - #67845 (Also remove const-hack for abs)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jan 4, 2020
…r=Manishearth

Implement uncommon_codepoints lint.

Part of rust-lang#55467 .  The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
bors added a commit that referenced this pull request Jan 4, 2020
Rollup of 8 pull requests

Successful merges:

 - #66913 (Suggest calling method when first argument is `self`)
 - #67531 (no longer promote non-pattern const functions)
 - #67773 (Add a test for #37333)
 - #67786 (Nix reexports from `rustc_span` in `syntax`)
 - #67789 (Cleanup linkchecker whitelist)
 - #67810 (Implement uncommon_codepoints lint.)
 - #67835 (tweak wording of mismatched delimiter errors)
 - #67845 (Also remove const-hack for abs)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Jan 4, 2020
Rollup of 8 pull requests

Successful merges:

 - #66913 (Suggest calling method when first argument is `self`)
 - #67531 (no longer promote non-pattern const functions)
 - #67773 (Add a test for #37333)
 - #67786 (Nix reexports from `rustc_span` in `syntax`)
 - #67789 (Cleanup linkchecker whitelist)
 - #67810 (Implement uncommon_codepoints lint.)
 - #67835 (tweak wording of mismatched delimiter errors)
 - #67845 (Also remove const-hack for abs)

Failed merges:

r? @ghost
@bors bors merged commit 485e98a into rust-lang:master Jan 4, 2020
4 checks passed
4 checks passed
pr Build #20200103.1 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@crlf0710 crlf0710 deleted the crlf0710:uncommon_codepoints_lint branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.