Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve some `Drop`-related error messages #67823

Merged
merged 2 commits into from Jan 4, 2020
Merged

Conversation

@euclio
Copy link
Contributor

euclio commented Jan 3, 2020

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 3, 2020

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_typeck/check/dropck.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/dropck.rs Outdated Show resolved Hide resolved
euclio added 2 commits Jan 3, 2020
- Use the span of the predicate
- Use the def's description instead of "struct/enum" (notably incorrect
  for unions)
- Align formatting with other error messages
@euclio euclio force-pushed the euclio:drop-improvements branch from 38ac816 to e9990bc Jan 4, 2020
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Jan 4, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 4, 2020

📌 Commit e9990bc has been approved by petrochenkov

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2020
…enkov

improve some `Drop`-related error messages
bors added a commit that referenced this pull request Jan 4, 2020
Rollup of 4 pull requests

Successful merges:

 - #67822 (Revert `const_err` lint checking of casts)
 - #67823 (improve some `Drop`-related error messages)
 - #67837 (Clean up err codes)
 - #67848 (Remove unused `#[link_name = "m"]` attributes)

Failed merges:

r? @ghost
@bors bors merged commit e9990bc into rust-lang:master Jan 4, 2020
4 checks passed
4 checks passed
pr Build #20200104.1 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@euclio euclio deleted the euclio:drop-improvements branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.