Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize ManuallyDrop::take #68066

Merged
merged 1 commit into from Jan 20, 2020
Merged

Conversation

@CAD97
Copy link
Contributor

CAD97 commented Jan 9, 2020

Tracking issue: closes #55422
FCP merge: #55422 (comment)

Reclaims the doc improvements from closed #62198.


Stable version is a simple change if necessary.

Proposal: [relnotes] (this changes how to best take advantage of ManuallyDrop, esp. wrt. Drop::drop and finalize-by-value members)

@jonas-schievink jonas-schievink added this to the 1.42 milestone Jan 9, 2020
@CAD97 CAD97 mentioned this pull request Jan 9, 2020
3 of 5 tasks complete
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 9, 2020

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-09T18:21:57.4773862Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-09T18:21:57.4863339Z ##[command]git config gc.auto 0
2020-01-09T18:21:57.4954161Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-09T18:21:57.5028742Z ##[command]git config --get-all http.proxy
2020-01-09T18:21:57.5169928Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68066/merge:refs/remotes/pull/68066/merge
---
2020-01-09T18:26:51.9814565Z     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2020-01-09T18:26:56.9953112Z error: the feature `manually_drop_take` has been stable since 1.42.0 and no longer requires an attribute to enable
2020-01-09T18:26:56.9955545Z    --> src/libstd/lib.rs:278:12
2020-01-09T18:26:56.9956314Z     |
2020-01-09T18:26:56.9956947Z 278 | #![feature(manually_drop_take)]
2020-01-09T18:26:56.9958816Z     |
2020-01-09T18:26:56.9959516Z     = note: `-D stable-features` implied by `-D warnings`
2020-01-09T18:26:56.9959820Z 
2020-01-09T18:26:57.1484266Z error: aborting due to previous error
---
2020-01-09T18:26:57.1740185Z   local time: Thu Jan  9 18:26:57 UTC 2020
2020-01-09T18:26:57.4632250Z   network time: Thu, 09 Jan 2020 18:26:57 GMT
2020-01-09T18:26:57.4635094Z == end clock drift check ==
2020-01-09T18:26:58.7467296Z 
2020-01-09T18:26:58.7630996Z ##[error]Bash exited with code '1'.
2020-01-09T18:26:58.7657976Z ##[section]Starting: Checkout
2020-01-09T18:26:58.7659892Z ==============================================================================
2020-01-09T18:26:58.7659949Z Task         : Get sources
2020-01-09T18:26:58.7659999Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@CAD97 CAD97 force-pushed the CAD97:stabilize-manuallydrop-take branch from 0226413 to 4e98966 Jan 9, 2020
@Centril Centril added the T-libs label Jan 9, 2020
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 20, 2020

Approving per FCP conclusion (with no further comments) on #55422; @bors r=Amanieu,Mark-Simulacrum -- I verified that the PR is still in good shape as well.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2020

📌 Commit 4e98966 has been approved by Amanieu,Mark-Simulacrum

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2020

⌛️ Testing commit 4e98966 with merge b5a3341...

bors added a commit that referenced this pull request Jan 20, 2020
…ark-Simulacrum

Stabilize ManuallyDrop::take

Tracking issue: closes #55422
FCP merge: #55422 (comment)

Reclaims the doc improvements from closed #62198.

-----

Stable version is a simple change if necessary.

Proposal: [relnotes] (this changes how to best take advantage of `ManuallyDrop`, esp. wrt. `Drop::drop` and finalize-by-value members)
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 20, 2020

☀️ Test successful - checks-azure
Approved by: Amanieu,Mark-Simulacrum
Pushing b5a3341 to master...

@bors bors added the merged-by-bors label Jan 20, 2020
@bors bors merged commit 4e98966 into rust-lang:master Jan 20, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200109.41 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@bors bors mentioned this pull request Jan 20, 2020
0 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.