-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jemalloc! #6895
jemalloc! #6895
Conversation
r? @brson |
Woo! 🌟 |
This looks really great. I'm glad it was so easy to integrate. Before landing, I'd like to collect some performance numbers on the three major platforms so we can say something about the impact it has. I opened #6897 on this, but may not be able to do it for a few days. Pushing to try now. |
I see the following error when I build on x86_64-linux
|
Isn't tcmalloc generally supposed to be faster? I feel like we should not make any moves here until we've concretely measured performance. |
@pcwalton: the problem with tcmalloc is that Google isn't including many of their Chromium improvements in the We could extract |
Aha, never mind then. That's unfortunate re. tcmalloc, but I suppose it can't be helped. |
Linux build failure: |
librustrt needs to link against jemalloc's dependencies (in this case, pthreads). I do not know how to accomplish this. |
I still want to do a little testing on mac and in multithreaded scenarios. Sorry for the delay. |
replace span_lint with span_lint_and_sugg along with error message fixes: rust-lang#6874 changelog: none apologies if this may not be the most idiomatic way of doing it, any advice on changes (if any) would be greatly appreciated.
No description provided.