Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querify object_safety_violations. #69242

Merged
merged 2 commits into from Feb 22, 2020
Merged

Conversation

@cjgillot
Copy link
Contributor

cjgillot commented Feb 17, 2020

Split from #69076

r? @Zoxc

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 17, 2020

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Feb 17, 2020

Awaiting bors try build completion

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 17, 2020

⌛️ Trying commit 6e15faf with merge 5ed36c1...

bors added a commit that referenced this pull request Feb 17, 2020
Querify object_safety_violations.

Split from #69076

r? @Zoxc
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 17, 2020

💔 Test failed - checks-azure

@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Feb 18, 2020

Failure seems spurious.

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 18, 2020

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Feb 18, 2020

Awaiting bors try build completion

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2020

⌛️ Trying commit 6e15faf with merge 4e3c536...

bors added a commit that referenced this pull request Feb 18, 2020
Querify object_safety_violations.

Split from #69076

r? @Zoxc
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 18, 2020

☀️ Try build successful - checks-azure
Build commit: 4e3c536 (4e3c536f7b0abc3f8ab5d0b62c6b8e53d6632bec)

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Feb 18, 2020

Queued 4e3c536 with parent 6317721, future comparison URL.

@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Feb 18, 2020

The is_object_safe query can probably be removed then, and replaced with a method on TyCtxt

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Feb 18, 2020

Finished benchmarking try commit 4e3c536, comparison URL.

@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Feb 19, 2020

Perf seems good. Do we try with is_object_safe removed?

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 19, 2020

Yes we can probably make is_object_safe a method calling object_safety_violations now.

@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Feb 20, 2020

Added a commit doing that.

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Feb 21, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit 310f470 has been approved by Zoxc

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2020

⌛️ Testing commit 310f470 with merge 1d7e818...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 22, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 1d7e818 to master...

@bors bors added the merged-by-bors label Feb 22, 2020
@bors bors merged commit 1d7e818 into rust-lang:master Feb 22, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200219.31 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@cjgillot cjgillot deleted the cjgillot:object_violations branch Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.