Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] Use unhygienic token matching for identifying macro variables #69410

Closed
wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

All other comparisons in macro_rules use "stupid" token matching instead of name resolution.

macro m(a $a: ident) {
    $a /* <- NEW!: matches "$a" from the macro LHS regardless of hygienic contexts */
}

m!(a /* <- OLD: matches "a" from the macro LHS regardless of hygienic contexts */ b)

r? @ghost

@petrochenkov
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 23, 2020

⌛ Trying commit 739bcfe with merge e6563ac70cbfd3196492061900e9e9793e065e4d...

@petrochenkov petrochenkov added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 23, 2020
@petrochenkov
Copy link
Contributor Author

Inspired by #68746.

@bors
Copy link
Contributor

bors commented Feb 24, 2020

☀️ Try build successful - checks-azure
Build commit: e6563ac70cbfd3196492061900e9e9793e065e4d (e6563ac70cbfd3196492061900e9e9793e065e4d)

@petrochenkov
Copy link
Contributor Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-69410 created and queued.
🤖 Automatically detected try build e6563ac70cbfd3196492061900e9e9793e065e4d
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-69410 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-69410 is completed!
📊 3 regressed and 0 fixed (90999 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 26, 2020
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2020
@petrochenkov
Copy link
Contributor Author

Regressions:

  • rbalicki2.rustactoe.78e20cb04be08e6b7e56a72f3f6fe0f14a18dda4 - I couldn't reproduce this one.
  • defmac-0.2.1 - the macro intentionally uses macro variables with same name and different contexts.
  • ndarray-0.13.0 - depends on defmac-0.2.1 in --test mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants